Merge lp:~hyuchia/noise/releases-info into lp:~elementary-apps/noise/trunk

Proposed by Diego Islas Ocampo on 2017-03-03
Status: Merged
Approved by: Daniel Fore on 2017-04-20
Approved revision: 2052
Merged at revision: 2058
Proposed branch: lp:~hyuchia/noise/releases-info
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 97 lines (+55/-35)
1 file modified
data/org.pantheon.noise.appdata.xml.in (+55/-35)
To merge this branch: bzr merge lp:~hyuchia/noise/releases-info
Reviewer Review Type Date Requested Status
Jeremy Wootten code 2017-03-03 Approve on 2017-03-18
Review via email: mp+318864@code.launchpad.net

Commit message

Add the release information to the AppData.xml to provide appcenter support

Description of the change

Add the release information to the AppData.xml to provide appcenter support

To post a comment you must log in.
Cody Garver (codygarver) wrote :

In order to ease the burden on translators, please use the following common descriptions:

* Security fixes
* Various crash fixes
* New translations
* Minor bug fixes

Please do not use the following:
* Minor bug fixes and translations updates.
* Apply minor bug fixes
* Translations Updates

Also I am not sure about the <p> paragraphs, why are they not all <li> list items?

Diego Islas Ocampo (hyuchia) wrote :

The paragraphs are mainly to keep appstream-util happy, but I think they should be added so there is a small description of every release instead of just a list of changes, the description can be used for a preview of the update and the description + list for an expanded view.

I'll change the descriptions for the common ones but should I also limit the file to 4 releases (or maybe just the ones for the current elementary release cycle)? That may also help ease the burden.

Cody Garver (codygarver) wrote :

Yeah I think you're right, start at 0.4

lp:~hyuchia/noise/releases-info updated on 2017-03-09
2052. By Diego Islas Ocampo on 2017-03-09

Update descriptions and reduce releases to current cycle

Diego Islas Ocampo (hyuchia) wrote :

All right, I've removed the releases from other cycles and used the common descriptions.

Jeremy Wootten (jeremywootten) wrote :

Passes appstreamcli validate --pedantic.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/org.pantheon.noise.appdata.xml.in'
2--- data/org.pantheon.noise.appdata.xml.in 2016-12-01 11:45:45 +0000
3+++ data/org.pantheon.noise.appdata.xml.in 2017-03-09 17:57:23 +0000
4@@ -1,38 +1,58 @@
5 <?xml version="1.0" encoding="UTF-8"?>
6 <!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
7-<component type="desktop">
8- <id>org.pantheon.noise.desktop</id>
9- <metadata_license>CC0-1.0</metadata_license>
10- <project_group>elementary</project_group>
11- <project_license>GPL-3.0+</project_license>
12- <_name>Music</_name>
13- <_summary>The official elementary music player</_summary>
14- <description>
15- <_p>
16- Music is a fast and beautiful audio player with a focus on
17- music and libraries. It handles external devices, CDs, and
18- album art.
19- </_p>
20- </description>
21- <releases>
22- <release timestamp="1480592595" version="0.4.0.2"/>
23- <release timestamp="1427915704" version="0.3.1"/>
24- <release timestamp="1401003480" version="0.3.0"/>
25- <release timestamp="1376719060" version="0.2.4"/>
26- <release timestamp="1374379743" version="0.2.3"/>
27- <release timestamp="1372369509" version="0.2.2"/>
28- <release timestamp="1370825702" version="0.2.1"/>
29- <release timestamp="1355236601" version="0.2.0"/>
30- <release timestamp="1320168563" version="0.1.0"/>
31- </releases>
32- <provides>
33- <binary>noise</binary>
34- <library>libnoise-core.so.0</library>
35- </provides>
36- <developer_name>elementary LLC.</developer_name>
37- <url type="homepage">http://elementary.io/</url>
38- <url type="bugtracker">https://bugs.launchpad.net/noise</url>
39- <url type="donation">https://elementary.io/get-involved#funding</url>
40- <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>
41- <update_contact>contact_at_elementary.io</update_contact>
42+<component type="desktop-application">
43+ <id>org.pantheon.noise.desktop</id>
44+ <metadata_license>CC0-1.0</metadata_license>
45+ <project_group>elementary</project_group>
46+ <project_license>GPL-3.0+</project_license>
47+ <_name>Music</_name>
48+ <_summary>The official elementary music player</_summary>
49+ <description>
50+ <_p>
51+ Music is a fast and beautiful audio player with a focus on
52+ music and libraries. It handles external devices, CDs, and
53+ album art.
54+ </_p>
55+ </description>
56+ <releases>
57+ <release version="0.4.0.2" date="2016-12-01" urgency="medium">
58+ ⁠<description>
59+ <_p>Minor bug fixes.</_p>
60+ ⁠</description>
61+ </release>
62+ <release version="0.4.0.1" date="2016-09-20" urgency="medium">
63+ ⁠<description>
64+ <_p>Add rounded bottom window corner.</_p>
65+ <ul>
66+ <_li>Minor bug fixes</_li>
67+ <_li>New translations</_li>
68+ </ul>
69+ ⁠</description>
70+ </release>
71+ <release version="0.4.0" date="2016-08-10" urgency="medium">
72+ ⁠<description>
73+ <_p>Release for Loki.</_p>
74+ <ul>
75+ <_li>Add support for Opus Ogg</_li>
76+ <_li>Fix Ctrl+Q support for non-Latin keyboard layouts</_li>
77+ <_li>Reorganize media edition layout</_li>
78+ <_li>Port grid to support HiDPI displays</_li>
79+ <_li>Update icons to latest elementary icon release</_li>
80+ <_li>Respect privacy mode</_li>
81+ <_li>Minor bug fixes</_li>
82+ <_li>New translations</_li>
83+ </ul>
84+ ⁠</description>
85+ </release>
86+ </releases>
87+ <provides>
88+ <binary>noise</binary>
89+ <library>libnoise-core.so.0</library>
90+ </provides>
91+ <developer_name>elementary LLC.</developer_name>
92+ <url type="homepage">http://elementary.io/</url>
93+ <url type="bugtracker">https://bugs.launchpad.net/noise</url>
94+ <url type="donation">https://elementary.io/get-involved#funding</url>
95+ <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>
96+ <update_contact>contact_at_elementary.io</update_contact>
97 </component>

Subscribers

People subscribed via source and target branches