Merge lp:~hyuchia/noise/fix-1623663 into lp:~elementary-apps/noise/trunk

Proposed by Diego Islas Ocampo
Status: Merged
Approved by: Jeremy Wootten
Approved revision: 2046
Merged at revision: 2046
Proposed branch: lp:~hyuchia/noise/fix-1623663
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 31 lines (+6/-1)
1 file modified
src/Dialogs/MediaEditor.vala (+6/-1)
To merge this branch: bzr merge lp:~hyuchia/noise/fix-1623663
Reviewer Review Type Date Requested Status
Jeremy Wootten code, function Approve
Review via email: mp+317813@code.launchpad.net

Commit message

Description of the change

Add scroll to song comment in the Media Editor Dialog

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Works as expected, thanks.

review: Approve (code, function)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Dialogs/MediaEditor.vala'
2--- src/Dialogs/MediaEditor.vala 2016-12-31 17:15:12 +0000
3+++ src/Dialogs/MediaEditor.vala 2017-02-21 03:52:54 +0000
4@@ -35,6 +35,7 @@
5 private Gtk.Entry composer_entry;
6 private Gtk.Entry grouping_entry;
7 private Gtk.TextView comment_textview;
8+ private Gtk.ScrolledWindow comment_scrolledwindow;
9 private Gtk.SpinButton track_spinbutton;
10 private Gtk.SpinButton disk_spinbutton;
11 private Gtk.SpinButton year_spinbutton;
12@@ -100,6 +101,10 @@
13 composer_entry = new Gtk.Entry ();
14 grouping_entry = new Gtk.Entry ();
15 comment_textview = new Gtk.TextView ();
16+ comment_textview.set_wrap_mode (Gtk.WrapMode.WORD_CHAR);
17+ comment_scrolledwindow = new Gtk.ScrolledWindow (null, null);
18+ comment_scrolledwindow.set_policy (Gtk.PolicyType.EXTERNAL, Gtk.PolicyType.AUTOMATIC);
19+ comment_scrolledwindow.add (comment_textview);
20 track_spinbutton = new Gtk.SpinButton.with_range (0, 500, 1);
21 disk_spinbutton = new Gtk.SpinButton.with_range (0, 500, 1);
22 var local_time = new DateTime.now_local ();
23@@ -109,7 +114,7 @@
24
25 var comment_frame = new Gtk.Frame (null);
26 comment_frame.expand = true;
27- comment_frame.add (comment_textview);
28+ comment_frame.add (comment_scrolledwindow);
29
30 grid.attach (title_label, 0, 0, 1, 1);
31 grid.attach (title_entry, 0, 1, 1, 1);

Subscribers

People subscribed via source and target branches