Merge lp:~hyuchia/noise/fix-1594598 into lp:~elementary-apps/noise/trunk

Proposed by Diego Islas Ocampo
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp:~hyuchia/noise/fix-1594598
Merge into: lp:~elementary-apps/noise/trunk
Diff against target: 1122 lines (+342/-343)
14 files modified
core/Settings.vala (+3/-3)
data/CMakeLists.txt (+7/-7)
data/io.elementary.noise.appdata.xml.in (+38/-0)
data/io.elementary.noise.desktop.in.in (+19/-0)
data/org.pantheon.noise.appdata.xml.in (+0/-38)
data/org.pantheon.noise.desktop.in.in (+0/-19)
plugins/LastFM/noise-lastfm.application (+1/-1)
plugins/MPRIS/MPRIS.vala (+74/-74)
schemas/CMakeLists.txt (+1/-1)
schemas/io.elementary.noise.gschema.xml (+186/-0)
schemas/org.pantheon.noise.gschema.xml (+0/-186)
src/LocalBackend/LocalLibrary.vala (+4/-5)
src/Noise.vala (+3/-3)
src/Objects/HistoryPlaylist.vala (+6/-6)
To merge this branch: bzr merge lp:~hyuchia/noise/fix-1594598
Reviewer Review Type Date Requested Status
elementary Apps team Pending
Review via email: mp+318298@code.launchpad.net

Description of the change

Removed all references to org.pantheon and replaced them with the io.elementary scheme.

To post a comment you must log in.
lp:~hyuchia/noise/fix-1594598 updated
2049. By Diego Islas Ocampo

Remove translation conflicts

2050. By Diego Islas Ocampo

Merge with latest trunk

2051. By Diego Islas Ocampo

Use right scheme for paths

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hey Diego, This branch has a lot of changes in it that aren't related to changing the app ID. Can you open a new PR on GitHub with only those changes? https://github.com/elementary/music

Unmerged revisions

2051. By Diego Islas Ocampo

Use right scheme for paths

2050. By Diego Islas Ocampo

Merge with latest trunk

2049. By Diego Islas Ocampo

Remove translation conflicts

2048. By Diego Islas Ocampo

Use the right reversed elementary Scheme

2047. By Diego Islas Ocampo

Remove unused variable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'core/Settings.vala'
2--- core/Settings.vala 2016-12-31 17:15:12 +0000
3+++ core/Settings.vala 2017-03-02 02:52:40 +0000
4@@ -52,7 +52,7 @@
5 }
6
7 private SavedState () {
8- base ("org.pantheon.noise.saved-state");
9+ base ("io.elementary.noise.saved-state");
10 }
11 }
12
13@@ -89,7 +89,7 @@
14 }
15
16 private Main () {
17- base ("org.pantheon.noise.settings");
18+ base ("io.elementary.noise.settings");
19 if (music_folder == "") {
20 music_folder = GLib.Environment.get_user_special_dir (GLib.UserDirectory.MUSIC);
21 }
22@@ -113,7 +113,7 @@
23 }
24
25 private Equalizer () {
26- base ("org.pantheon.noise.equalizer");
27+ base ("io.elementary.noise.equalizer");
28 }
29
30 public Gee.Collection<Noise.EqualizerPreset> getPresets () {
31
32=== modified file 'data/CMakeLists.txt'
33--- data/CMakeLists.txt 2016-07-15 17:21:12 +0000
34+++ data/CMakeLists.txt 2017-03-02 02:52:40 +0000
35@@ -2,16 +2,16 @@
36
37 # We need to create two temporary desktop files in order to have all translations available.
38 set (APP_NAME "Music")
39-configure_file(org.pantheon.noise.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.desktop.in)
40+configure_file(io.elementary.noise.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.desktop.in)
41 set (APP_NAME "Noise")
42-configure_file(org.pantheon.noise.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/noise-original.desktop.in)
43+configure_file(io.elementary.noise.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/noise-original.desktop.in)
44 if (BUILD_FOR_ELEMENTARY)
45- configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.desktop ${CMAKE_SOURCE_DIR}/po/)
46+ configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.desktop ${CMAKE_SOURCE_DIR}/po/)
47 else ()
48- configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/noise-original.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.desktop ${CMAKE_SOURCE_DIR}/po/)
49+ configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/noise-original.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.desktop ${CMAKE_SOURCE_DIR}/po/)
50 endif ()
51
52-configure_file_translation(${CMAKE_CURRENT_SOURCE_DIR}/org.pantheon.noise.appdata.xml.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.appdata.xml ${CMAKE_SOURCE_DIR}/po/)
53+configure_file_translation(${CMAKE_CURRENT_SOURCE_DIR}/io.elementary.noise.appdata.xml.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.appdata.xml ${CMAKE_SOURCE_DIR}/po/)
54
55-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.appdata.xml DESTINATION share/metainfo)
56-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.noise.desktop DESTINATION share/applications)
57+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.appdata.xml DESTINATION share/metainfo)
58+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.noise.desktop DESTINATION share/applications)
59
60=== added file 'data/io.elementary.noise.appdata.xml.in'
61--- data/io.elementary.noise.appdata.xml.in 1970-01-01 00:00:00 +0000
62+++ data/io.elementary.noise.appdata.xml.in 2017-03-02 02:52:40 +0000
63@@ -0,0 +1,38 @@
64+<?xml version="1.0" encoding="UTF-8"?>
65+<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
66+<component type="desktop">
67+ <id>io.elementary.noise.desktop</id>
68+ <metadata_license>CC0-1.0</metadata_license>
69+ <project_group>elementary</project_group>
70+ <project_license>GPL-3.0+</project_license>
71+ <_name>Music</_name>
72+ <_summary>The official elementary music player</_summary>
73+ <description>
74+ <_p>
75+ Music is a fast and beautiful audio player with a focus on
76+ music and libraries. It handles external devices, CDs, and
77+ album art.
78+ </_p>
79+ </description>
80+ <releases>
81+ <release timestamp="1480592595" version="0.4.0.2"/>
82+ <release timestamp="1427915704" version="0.3.1"/>
83+ <release timestamp="1401003480" version="0.3.0"/>
84+ <release timestamp="1376719060" version="0.2.4"/>
85+ <release timestamp="1374379743" version="0.2.3"/>
86+ <release timestamp="1372369509" version="0.2.2"/>
87+ <release timestamp="1370825702" version="0.2.1"/>
88+ <release timestamp="1355236601" version="0.2.0"/>
89+ <release timestamp="1320168563" version="0.1.0"/>
90+ </releases>
91+ <provides>
92+ <binary>noise</binary>
93+ <library>libnoise-core.so.0</library>
94+ </provides>
95+ <developer_name>elementary LLC.</developer_name>
96+ <url type="homepage">http://elementary.io/</url>
97+ <url type="bugtracker">https://bugs.launchpad.net/noise</url>
98+ <url type="donation">https://elementary.io/get-involved#funding</url>
99+ <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>
100+ <update_contact>contact_at_elementary.io</update_contact>
101+</component>
102
103=== added file 'data/io.elementary.noise.desktop.in.in'
104--- data/io.elementary.noise.desktop.in.in 1970-01-01 00:00:00 +0000
105+++ data/io.elementary.noise.desktop.in.in 2017-03-02 02:52:40 +0000
106@@ -0,0 +1,19 @@
107+[Desktop Entry]
108+Type=Application
109+_Name=@APP_NAME@
110+_GenericName=Music Player
111+_Comment=Listen to music
112+Exec=noise %U
113+Icon=multimedia-audio-player
114+Terminal=false
115+Categories=Audio;Music;Player;AudioVideo;GNOME;GTK;
116+MimeType=x-content/audio-player;x-content/audio-cdda;application/ogg;application/x-extension-m4a;application/x-extension-mp4;application/x-flac;application/x-ogg;audio/3gpp;audio/aac;audio/ac3;audio/AMR;audio/AMR-WB;audio/basic;audio/flac;audio/midi;audio/mp2;audio/mp4;audio/mpeg;audio/ogg;audio/vnd.rn-realaudio;audio/x-aiff;audio/x-ape;audio/x-flac;audio/x-gsm;audio/x-it;audio/x-m4a;audio/x-matroska;audio/x-mod;audio/x-mp3;audio/x-mpeg;audio/x-mpegurl;audio/x-ms-asf;audio/x-ms-asx;audio/x-ms-wax;audio/x-ms-wma;audio/x-musepack;audio/x-opus+ogg;audio/x-pn-aiff;audio/x-pn-au;audio/x-pn-realaudio;audio/x-pn-realaudio-plugin;audio/x-pn-wav;audio/x-pn-windows-acm;audio/x-realaudio;audio/x-real-audio;audio/x-sbc;audio/x-scpls;audio/x-speex;audio/x-tta;audio/x-vorbis;audio/x-vorbis+ogg;audio/x-wav;audio/x-wavpack;audio/x-xm;
117+StartupNotify=true
118+_Keywords=Noise;Audio;Player;MP3;iPod;Play;Playlist;Media;CD;Phone;Songs;
119+X-GNOME-UsesNotifications=true
120+X-PulseAudio-Properties=media.role=music
121+Actions=AboutDialog;
122+
123+[Desktop Action AboutDialog]
124+Exec=noise --about
125+_Name=About @APP_NAME@
126
127=== removed file 'data/org.pantheon.noise.appdata.xml.in'
128--- data/org.pantheon.noise.appdata.xml.in 2016-12-01 11:45:45 +0000
129+++ data/org.pantheon.noise.appdata.xml.in 1970-01-01 00:00:00 +0000
130@@ -1,38 +0,0 @@
131-<?xml version="1.0" encoding="UTF-8"?>
132-<!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
133-<component type="desktop">
134- <id>org.pantheon.noise.desktop</id>
135- <metadata_license>CC0-1.0</metadata_license>
136- <project_group>elementary</project_group>
137- <project_license>GPL-3.0+</project_license>
138- <_name>Music</_name>
139- <_summary>The official elementary music player</_summary>
140- <description>
141- <_p>
142- Music is a fast and beautiful audio player with a focus on
143- music and libraries. It handles external devices, CDs, and
144- album art.
145- </_p>
146- </description>
147- <releases>
148- <release timestamp="1480592595" version="0.4.0.2"/>
149- <release timestamp="1427915704" version="0.3.1"/>
150- <release timestamp="1401003480" version="0.3.0"/>
151- <release timestamp="1376719060" version="0.2.4"/>
152- <release timestamp="1374379743" version="0.2.3"/>
153- <release timestamp="1372369509" version="0.2.2"/>
154- <release timestamp="1370825702" version="0.2.1"/>
155- <release timestamp="1355236601" version="0.2.0"/>
156- <release timestamp="1320168563" version="0.1.0"/>
157- </releases>
158- <provides>
159- <binary>noise</binary>
160- <library>libnoise-core.so.0</library>
161- </provides>
162- <developer_name>elementary LLC.</developer_name>
163- <url type="homepage">http://elementary.io/</url>
164- <url type="bugtracker">https://bugs.launchpad.net/noise</url>
165- <url type="donation">https://elementary.io/get-involved#funding</url>
166- <url type="help">https://elementaryos.stackexchange.com/questions/tagged/noise</url>
167- <update_contact>contact_at_elementary.io</update_contact>
168-</component>
169
170=== removed file 'data/org.pantheon.noise.desktop.in.in'
171--- data/org.pantheon.noise.desktop.in.in 2016-08-10 13:20:46 +0000
172+++ data/org.pantheon.noise.desktop.in.in 1970-01-01 00:00:00 +0000
173@@ -1,19 +0,0 @@
174-[Desktop Entry]
175-Type=Application
176-_Name=@APP_NAME@
177-_GenericName=Music Player
178-_Comment=Listen to music
179-Exec=noise %U
180-Icon=multimedia-audio-player
181-Terminal=false
182-Categories=Audio;Music;Player;AudioVideo;GNOME;GTK;
183-MimeType=x-content/audio-player;x-content/audio-cdda;application/ogg;application/x-extension-m4a;application/x-extension-mp4;application/x-flac;application/x-ogg;audio/3gpp;audio/aac;audio/ac3;audio/AMR;audio/AMR-WB;audio/basic;audio/flac;audio/midi;audio/mp2;audio/mp4;audio/mpeg;audio/ogg;audio/vnd.rn-realaudio;audio/x-aiff;audio/x-ape;audio/x-flac;audio/x-gsm;audio/x-it;audio/x-m4a;audio/x-matroska;audio/x-mod;audio/x-mp3;audio/x-mpeg;audio/x-mpegurl;audio/x-ms-asf;audio/x-ms-asx;audio/x-ms-wax;audio/x-ms-wma;audio/x-musepack;audio/x-opus+ogg;audio/x-pn-aiff;audio/x-pn-au;audio/x-pn-realaudio;audio/x-pn-realaudio-plugin;audio/x-pn-wav;audio/x-pn-windows-acm;audio/x-realaudio;audio/x-real-audio;audio/x-sbc;audio/x-scpls;audio/x-speex;audio/x-tta;audio/x-vorbis;audio/x-vorbis+ogg;audio/x-wav;audio/x-wavpack;audio/x-xm;
184-StartupNotify=true
185-_Keywords=Noise;Audio;Player;MP3;iPod;Play;Playlist;Media;CD;Phone;Songs;
186-X-GNOME-UsesNotifications=true
187-X-PulseAudio-Properties=media.role=music
188-Actions=AboutDialog;
189-
190-[Desktop Action AboutDialog]
191-Exec=noise --about
192-_Name=About @APP_NAME@
193
194=== modified file 'plugins/LastFM/noise-lastfm.application'
195--- plugins/LastFM/noise-lastfm.application 2016-07-15 17:21:12 +0000
196+++ plugins/LastFM/noise-lastfm.application 2017-03-02 02:52:40 +0000
197@@ -1,7 +1,7 @@
198 <?xml version="1.0" encoding="UTF-8"?>
199 <application id="noise-lastfm">
200 <description>Music</description>
201- <desktop-entry>org.pantheon.noise.desktop</desktop-entry>
202+ <desktop-entry>io.elementary.noise.desktop</desktop-entry>
203 <translations>noise</translations>
204 <services>
205 <service id="lastfm-scrobble">
206
207=== modified file 'plugins/MPRIS/MPRIS.vala'
208--- plugins/MPRIS/MPRIS.vala 2016-12-31 17:15:12 +0000
209+++ plugins/MPRIS/MPRIS.vala 2017-03-02 02:52:40 +0000
210@@ -29,10 +29,10 @@
211 public MprisRoot root = null;
212 // Uncomment this when the bug on the playlist selection is fixed
213 //public MprisPlaylists playlists = null;
214-
215+
216 private unowned DBusConnection conn;
217 private uint owner_id;
218-
219+
220 public void initialize () {
221 owner_id = Bus.own_name(BusType.SESSION,
222 "org.mpris.MediaPlayer2.Noise",
223@@ -49,7 +49,7 @@
224 soundMenu.initialize ();
225 }
226 }
227-
228+
229 private void on_bus_acquired (DBusConnection connection, string name) {
230 this.conn = connection;
231 debug ("bus acquired");
232@@ -68,7 +68,7 @@
233
234 private void on_name_acquired(DBusConnection connection, string name) {
235 debug ("name acquired");
236- }
237+ }
238
239 private void on_name_lost(DBusConnection connection, string name) {
240 debug ("name_lost");
241@@ -78,42 +78,42 @@
242 [DBus(name = "org.mpris.MediaPlayer2")]
243 public class MprisRoot : GLib.Object {
244
245- public bool CanQuit {
246- get {
247- return true;
248- }
249- }
250-
251- public bool CanRaise {
252- get {
253- return true;
254- }
255- }
256-
257+ public bool CanQuit {
258+ get {
259+ return true;
260+ }
261+ }
262+
263+ public bool CanRaise {
264+ get {
265+ return true;
266+ }
267+ }
268+
269 public bool HasTrackList {
270 get {
271 return false;
272 }
273 }
274- public string DesktopEntry {
275+ public string DesktopEntry {
276 owned get {
277- return "org.pantheon.noise";
278- }
279+ return "io.elementary.noise";
280+ }
281 }
282-
283+
284 public string Identity {
285 owned get {
286 return ((Noise.App) GLib.Application.get_default ()).get_name ();
287 }
288 }
289-
290+
291 public string[] SupportedUriSchemes {
292 owned get {
293 string[] sa = {"http", "file", "https", "ftp"};
294 return sa;
295 }
296 }
297-
298+
299 public string[] SupportedMimeTypes {
300 owned get {
301 return Noise.MEDIA_CONTENT_TYPES;
302@@ -123,7 +123,7 @@
303 public void Quit () {
304 Noise.App.main_window.destroy ();
305 }
306-
307+
308 public void Raise () {
309 Noise.App.main_window.present ();
310 }
311@@ -145,7 +145,7 @@
312 PREVIOUS,
313 STOP
314 }
315-
316+
317 public MprisPlayer(DBusConnection conn) {
318 this.conn = conn;
319 _metadata = new HashTable<string,Variant>(str_hash, str_equal);
320@@ -172,7 +172,7 @@
321 private void playing_changed() {
322 trigger_metadata_update ();
323 }
324-
325+
326 private void trigger_metadata_update() {
327 if(update_metadata_source != 0)
328 Source.remove(update_metadata_source);
329@@ -180,7 +180,7 @@
330 update_metadata_source = Timeout.add(300, () => {
331 //print("trigger_metadata_update %s\n", global.current_artist);
332 Variant variant = this.PlaybackStatus;
333-
334+
335 queue_property_for_notification("PlaybackStatus", variant);
336 queue_property_for_notification("Metadata", _metadata);
337 update_metadata_source = 0;
338@@ -236,32 +236,32 @@
339 }
340
341 private ObjectPath get_track_id (Noise.Media m) {
342- return new ObjectPath ("/org/pantheon/noise/Track/%lld".printf (m.rowid));
343+ return new ObjectPath ("/io/elementary/noise/Track/%lld".printf (m.rowid));
344 }
345
346 private bool send_property_change() {
347-
348+
349 if(changed_properties == null)
350 return false;
351-
352+
353 var builder = new VariantBuilder(VariantType.ARRAY);
354 var invalidated_builder = new VariantBuilder(new VariantType("as"));
355-
356+
357 foreach(string name in changed_properties.get_keys()) {
358 Variant variant = changed_properties.lookup(name);
359 builder.add("{sv}", name, variant);
360 }
361-
362+
363 changed_properties = null;
364-
365+
366 try {
367 conn.emit_signal (null,
368- "/org/mpris/MediaPlayer2",
369- "org.freedesktop.DBus.Properties",
370- "PropertiesChanged",
371- new Variant("(sa{sv}as)",
372- INTERFACE_NAME,
373- builder,
374+ "/org/mpris/MediaPlayer2",
375+ "org.freedesktop.DBus.Properties",
376+ "PropertiesChanged",
377+ new Variant("(sa{sv}as)",
378+ INTERFACE_NAME,
379+ builder,
380 invalidated_builder)
381 );
382 }
383@@ -271,20 +271,20 @@
384 send_property_source = 0;
385 return false;
386 }
387-
388+
389 private void queue_property_for_notification(string property, Variant val) {
390 // putting the properties into a hashtable works as akind of event compression
391-
392+
393 if(changed_properties == null)
394 changed_properties = new HashTable<string,Variant>(str_hash, str_equal);
395-
396+
397 changed_properties.insert(property, val);
398-
399+
400 if(send_property_source == 0) {
401 send_property_source = Idle.add(send_property_change);
402 }
403 }
404-
405+
406 public string PlaybackStatus {
407 owned get { //TODO signal org.freedesktop.DBus.Properties.PropertiesChanged
408 if(Noise.App.player.playing)
409@@ -297,7 +297,7 @@
410 return "Stopped";
411 }
412 }
413-
414+
415 public string LoopStatus {
416 owned get {
417 switch(Noise.Settings.Main.get_default ().repeat_mode) {
418@@ -310,7 +310,7 @@
419 case(Noise.Settings.Repeat.ALL):
420 return "Playlist";
421 }
422-
423+
424 return "Playlist";
425 }
426 set {
427@@ -328,12 +328,12 @@
428 Noise.App.player.set_repeat_mode (Noise.Settings.Repeat.ALL);
429 break;
430 }
431-
432+
433 Variant variant = value;
434 queue_property_for_notification("LoopStatus", variant);
435 }
436 }
437-
438+
439 public double Rate {
440 get {
441 return (double)1.0;
442@@ -341,7 +341,7 @@
443 set {
444 }
445 }
446-
447+
448 public bool Shuffle {
449 get {
450 if (Noise.Settings.Main.get_default ().shuffle_mode == Noise.Settings.Shuffle.ALL)
451@@ -355,19 +355,19 @@
452 else {
453 Noise.App.player.set_shuffle_mode (Noise.Settings.Shuffle.OFF);
454 }
455-
456+
457 Variant variant = value;
458 queue_property_for_notification ("Shuffle", variant);
459 }
460 }
461-
462+
463 public HashTable<string,Variant>? Metadata { //a{sv}
464 owned get {
465 update_metadata (Noise.App.player.current_media);
466 return _metadata;
467 }
468 }
469-
470+
471 public double Volume {
472 get{
473 return Noise.App.player.volume;
474@@ -376,13 +376,13 @@
475 Noise.App.player.volume = value;
476 }
477 }
478-
479+
480 public int64 Position {
481 get {
482 return (Noise.App.player.player.get_position()/(int64)Noise.TimeUtils.MILI_INV);
483 }
484 }
485-
486+
487 /*public double MinimumRate {
488 get {
489 return (double)1.0;
490@@ -400,49 +400,49 @@
491 return true;
492 }
493 }
494-
495+
496 public bool CanGoPrevious {
497 get {
498 return true;
499 }
500 }
501-
502+
503 public bool CanPlay {
504 get {
505 return true;
506 }
507 }
508-
509+
510 public bool CanPause {
511 get {
512 return true;
513 }
514 }
515-
516+
517 public bool CanSeek {
518 get {
519 return true;
520 }
521 }
522-
523+
524 public bool CanControl {
525 get {
526 return true;
527 }
528 }
529-
530+
531 public signal void Seeked(int64 Position);
532
533 public void Next() {
534 // inhibit notifications
535 Noise.App.main_window.play_next_media(true);
536 }
537-
538+
539 public void Previous() {
540 // inhibit notifications
541 Noise.App.main_window.play_previous_media(true);
542 }
543-
544+
545 public void Pause() {
546 // inhibit notifications
547 if(Noise.App.player.playing)
548@@ -458,7 +458,7 @@
549 if(Noise.App.player.playing)
550 Noise.App.player.stop_playback();
551 }
552-
553+
554 public void Play() {
555 // inhibit notifications
556 if(!Noise.App.player.playing)
557@@ -477,16 +477,16 @@
558 Next ();
559 }
560 }
561-
562+
563 public void SetPosition(string dobj, int64 Position) {
564 Noise.App.player.player.set_position(Position * (int64)Noise.TimeUtils.MILI_INV);
565 }
566-
567+
568 public void OpenUri(string Uri) {
569-
570+
571 }
572 }
573-
574+
575 [DBus(name = "org.mpris.MediaPlayer2.Playlists")]
576 public class MprisPlaylists : GLib.Object {
577 public struct MprisPlaylist {
578@@ -503,7 +503,7 @@
579 private unowned DBusConnection conn;
580 private MaybePlaylist active_playlist;
581 private const string INTERFACE_NAME = "org.mpris.MediaPlayer2.Playlists";
582- const string PLAYLIST_ID = "/org/pantheon/noise/Playlists/%d";
583+ const string PLAYLIST_ID = "/io/elementary/noise/Playlists/%d";
584
585 private uint send_property_source = 0;
586 private HashTable<string,Variant> changed_properties = null;
587@@ -556,12 +556,12 @@
588
589 try {
590 conn.emit_signal(null,
591- "/org/mpris/MediaPlayer2",
592- "org.freedesktop.DBus.Properties",
593- "PropertiesChanged",
594- new Variant("(sa{sv}as)",
595- INTERFACE_NAME,
596- builder,
597+ "/org/mpris/MediaPlayer2",
598+ "org.freedesktop.DBus.Properties",
599+ "PropertiesChanged",
600+ new Variant("(sa{sv}as)",
601+ INTERFACE_NAME,
602+ builder,
603 invalidated_builder)
604 );
605 message("Sent properties changed signal\n");
606@@ -575,7 +575,7 @@
607 }
608
609 public void ActivatePlaylist(ObjectPath path) {
610- string playlist_id = path.replace ("/org/pantheon/noise/Playlists/", "");
611+ string playlist_id = path.replace ("/io/elementary/noise/Playlists/", "");
612
613 Noise.Playlist p = Noise.libraries_manager.local_library.playlist_from_id (int.parse (playlist_id));
614 if(p == null) {
615
616=== modified file 'schemas/CMakeLists.txt'
617--- schemas/CMakeLists.txt 2013-09-16 06:58:34 +0000
618+++ schemas/CMakeLists.txt 2017-03-02 02:52:40 +0000
619@@ -1,2 +1,2 @@
620 include (GSettings)
621-add_schema ("org.pantheon.noise.gschema.xml")
622+add_schema ("io.elementary.noise.gschema.xml")
623
624=== added file 'schemas/io.elementary.noise.gschema.xml'
625--- schemas/io.elementary.noise.gschema.xml 1970-01-01 00:00:00 +0000
626+++ schemas/io.elementary.noise.gschema.xml 2017-03-02 02:52:40 +0000
627@@ -0,0 +1,186 @@
628+<?xml version="1.0" encoding="UTF-8"?>
629+<schemalist>
630+ <enum id="io.elementary.noise.repeat">
631+ <value value="0" nick="off"/>
632+ <value value="1" nick="media"/>
633+ <value value="2" nick="album"/>
634+ <value value="3" nick="artist"/>
635+ <value value="4" nick="all"/>
636+ </enum>
637+ <enum id="io.elementary.noise.shuffle">
638+ <value value="0" nick="off"/>
639+ <value value="1" nick="all"/>
640+ </enum>
641+ <enum id="io.elementary.noise.windowstate">
642+ <value value="0" nick="normal"/>
643+ <value value="1" nick="maximized"/>
644+ </enum>
645+ <schema path="/io/elementary/noise/settings/" id="io.elementary.noise.settings">
646+ <key type="s" name="music-folder">
647+ <default>''</default>
648+ <summary>Path to music folder</summary>
649+ <description>Where music is copied to, saved, and managed</description>
650+ </key>
651+ <key type="s" name="music-mount-name">
652+ <default>''</default>
653+ <summary>Name of mount volume</summary>
654+ <description>Used to attempt to automount the music folder when noise starts if it already isn't.</description>
655+ </key>
656+ <key type="b" name="update-folder-hierarchy">
657+ <default>false</default>
658+ <summary>Whether or not to auto-organize folders and rename files</summary>
659+ <description>Whether or not to auto-organize folders and rename files</description>
660+ </key>
661+ <key type="b" name="write-metadata-to-file">
662+ <default>false</default>
663+ <summary>Whether or not to write metadata to file</summary>
664+ <description>Whether or not to write metadata to file</description>
665+ </key>
666+ <key type="b" name="copy-imported-music">
667+ <default>false</default>
668+ <summary>Whether or not to copy imported files to music folder</summary>
669+ <description>Whether or not to copy imported files to music folder</description>
670+ </key>
671+ <key type="b" name="close-while-playing">
672+ <default>false</default>
673+ <summary>Whether to close the player's window instead of hiding/minimizing it when a song is still playing. The window can be brought back by activating its desktop file.</summary>
674+ <description>When enabled, the window will be closed even if a song is still being played (i.e. close = quit). Otherwise, if a song is being played, the application will not be closed, but minimized/hidden. The player is minimized or hidden depending on the values of the minimize-while-playing-shells key.</description>
675+ </key>
676+ <key type="as" name="minimize-while-playing-shells">
677+ <default>['GNOME']</default>
678+ <summary>List of desktop shells for which the player's window will be minimized instead of hidden when the close-while-playing option is set to false.</summary>
679+ <description>For the Pantheon and GNOME desktop shells, the player's window is simply minimized due to the lack of a minimize button; the window is hidden for all the rest of desktop shells, unless they are added to this key. In fact, any dock-based shell should be part of this key, except those that lack a sound menu or in which the dock space is often limited (e.g. Unity). See the description of close-while-playing for more information.</description>
680+ </key>
681+ <key type="s" name="last-playlist-playing">
682+ <default>''</default>
683+ <summary>'s' for smart playlist or 'p' for static playlist + ID of last playlist playing</summary>
684+ <description>'s' for smart playlist or 'p' for static playlist + ID of last playlist playing</description>
685+ </key>
686+ <key type="x" name="last-media-playing">
687+ <default>0</default>
688+ <summary>ID of last media playing</summary>
689+ <description>ID of last media playing</description>
690+ </key>
691+ <key type="i" name="last-media-position">
692+ <default>0</default>
693+ <summary>Position, in seconds, of media</summary>
694+ <description>Position, in seconds, of media when noise last closed</description>
695+ </key>
696+ <key enum="io.elementary.noise.shuffle" name="shuffle-mode">
697+ <default>'off'</default>
698+ <summary>An index representing the shuffle mode</summary>
699+ <description>An index representing the shuffle mode</description>
700+ </key>
701+ <key enum="io.elementary.noise.repeat" name="repeat-mode">
702+ <default>'off'</default>
703+ <summary>An index representing the repeat mode</summary>
704+ <description>An index representing the repeat mode</description>
705+ </key>
706+ <key type="s" name="search-string">
707+ <default>''</default>
708+ <summary>String of last search</summary>
709+ <description>String of last search</description>
710+ </key>
711+ <key type="s" name="path-string">
712+ <default>'$ALBUM_ARTIST/$ALBUM/$TRACK - $TITLE'</default>
713+ <summary>String of the destination path to save files</summary>
714+ <description>String of the destination path to save files</description>
715+ </key>
716+ <key type="as" name="plugins-disabled">
717+ <default>[]</default>
718+ <summary>List of disabled plugins</summary>
719+ <description>Plugin modules to not load during startup</description>
720+ </key>
721+ </schema>
722+
723+ <schema path="/io/elementary/noise/saved-state/" id="io.elementary.noise.saved-state">
724+ <key type="i" name="window-width">
725+ <default>1100</default>
726+ <summary>Window width</summary>
727+ <description>Window width</description>
728+ </key>
729+ <key type="i" name="window-height">
730+ <default>600</default>
731+ <summary>Window height</summary>
732+ <description>Window height</description>
733+ </key>
734+ <key enum="io.elementary.noise.windowstate" name="window-state">
735+ <default>'normal'</default>
736+ <summary>The saved state of the window.</summary>
737+ <description>The saved state of the window.</description>
738+ </key>
739+ <key type="i" name="sidebar-width">
740+ <default>200</default>
741+ <summary>Sidebar width</summary>
742+ <description>Sidebar width</description>
743+ </key>
744+ <key type="i" name="more-width">
745+ <default>150</default>
746+ <summary>Right panel width</summary>
747+ <description>Right panel width</description>
748+ </key>
749+ <key type="i" name="view-mode">
750+ <default>1</default>
751+ <summary>Index of which view type to use</summary>
752+ <description>Index of which view type to use</description>
753+ </key>
754+ <key type="b" name="more-visible">
755+ <default>false</default>
756+ <summary>Whether or not the right panel is showing</summary>
757+ <description>Whether or not the right panel is showing</description>
758+ </key>
759+ <key type="b" name="column-browser-enabled">
760+ <default>false</default>
761+ <summary>Whether or not the column browser is enabled</summary>
762+ <description>Whether or not the column browser is enabled</description>
763+ </key>
764+ <key type="b" name="show-album-art-in-list-view">
765+ <default>false</default>
766+ <summary>Enables/disables album-art showing in the list view</summary>
767+ <description>Whether or not to show album art in the list view</description>
768+ </key>
769+ <key type="i" name="column-browser-width">
770+ <default>200</default>
771+ <summary>column-browser column width</summary>
772+ <description>column-browser column width</description>
773+ </key>
774+ <key type="i" name="column-browser-height">
775+ <default>200</default>
776+ <summary>column-browser column height</summary>
777+ <description>column-browser column height</description>
778+ </key>
779+ <key type="i" name="column-browser-position">
780+ <default>0</default>
781+ <summary>column-browser columns position</summary>
782+ <description>column-browser columns position</description>
783+ </key>
784+ <key type="as" name="column-browser-visible-columns">
785+ <default>['3', '5', '6']</default>
786+ <summary>Enabled column-browser columns for the music library view</summary>
787+ <description>Enabled column-browser columns for the music library view</description>
788+ </key>
789+ </schema>
790+
791+ <schema path="/io/elementary/noise/equalizer/" id="io.elementary.noise.equalizer">
792+ <key type="b" name="equalizer-enabled">
793+ <default>false</default>
794+ <summary>Whether or not the equalizer is enabled</summary>
795+ <description>Whether or not the equalizer is enabled</description>
796+ </key>
797+ <key type="s" name="selected-preset">
798+ <default>''</default>
799+ <summary>Contains the name of the user-selected preset</summary>
800+ <description>Contains information regarding the user-selected preset</description>
801+ </key>
802+ <key type="as" name="custom-presets">
803+ <default>[]</default>
804+ <summary>Custom Equalizer Presets</summary>
805+ <description>Contains the list of presets added by the user. Gain values are between -80 and 80</description>
806+ </key>
807+ <key type="b" name="auto-switch-preset">
808+ <default>true</default>
809+ <summary>Whether or not to use the auto preset</summary>
810+ <description>Whether or not to use the auto preset</description>
811+ </key>
812+ </schema>
813+</schemalist>
814
815=== removed file 'schemas/org.pantheon.noise.gschema.xml'
816--- schemas/org.pantheon.noise.gschema.xml 2015-08-24 16:05:21 +0000
817+++ schemas/org.pantheon.noise.gschema.xml 1970-01-01 00:00:00 +0000
818@@ -1,186 +0,0 @@
819-<?xml version="1.0" encoding="UTF-8"?>
820-<schemalist>
821- <enum id="org.pantheon.noise.repeat">
822- <value value="0" nick="off"/>
823- <value value="1" nick="media"/>
824- <value value="2" nick="album"/>
825- <value value="3" nick="artist"/>
826- <value value="4" nick="all"/>
827- </enum>
828- <enum id="org.pantheon.noise.shuffle">
829- <value value="0" nick="off"/>
830- <value value="1" nick="all"/>
831- </enum>
832- <enum id="org.pantheon.noise.windowstate">
833- <value value="0" nick="normal"/>
834- <value value="1" nick="maximized"/>
835- </enum>
836- <schema path="/org/pantheon/noise/settings/" id="org.pantheon.noise.settings">
837- <key type="s" name="music-folder">
838- <default>''</default>
839- <summary>Path to music folder</summary>
840- <description>Where music is copied to, saved, and managed</description>
841- </key>
842- <key type="s" name="music-mount-name">
843- <default>''</default>
844- <summary>Name of mount volume</summary>
845- <description>Used to attempt to automount the music folder when noise starts if it already isn't.</description>
846- </key>
847- <key type="b" name="update-folder-hierarchy">
848- <default>false</default>
849- <summary>Whether or not to auto-organize folders and rename files</summary>
850- <description>Whether or not to auto-organize folders and rename files</description>
851- </key>
852- <key type="b" name="write-metadata-to-file">
853- <default>false</default>
854- <summary>Whether or not to write metadata to file</summary>
855- <description>Whether or not to write metadata to file</description>
856- </key>
857- <key type="b" name="copy-imported-music">
858- <default>false</default>
859- <summary>Whether or not to copy imported files to music folder</summary>
860- <description>Whether or not to copy imported files to music folder</description>
861- </key>
862- <key type="b" name="close-while-playing">
863- <default>false</default>
864- <summary>Whether to close the player's window instead of hiding/minimizing it when a song is still playing. The window can be brought back by activating its desktop file.</summary>
865- <description>When enabled, the window will be closed even if a song is still being played (i.e. close = quit). Otherwise, if a song is being played, the application will not be closed, but minimized/hidden. The player is minimized or hidden depending on the values of the minimize-while-playing-shells key.</description>
866- </key>
867- <key type="as" name="minimize-while-playing-shells">
868- <default>['GNOME']</default>
869- <summary>List of desktop shells for which the player's window will be minimized instead of hidden when the close-while-playing option is set to false.</summary>
870- <description>For the Pantheon and GNOME desktop shells, the player's window is simply minimized due to the lack of a minimize button; the window is hidden for all the rest of desktop shells, unless they are added to this key. In fact, any dock-based shell should be part of this key, except those that lack a sound menu or in which the dock space is often limited (e.g. Unity). See the description of close-while-playing for more information.</description>
871- </key>
872- <key type="s" name="last-playlist-playing">
873- <default>''</default>
874- <summary>'s' for smart playlist or 'p' for static playlist + ID of last playlist playing</summary>
875- <description>'s' for smart playlist or 'p' for static playlist + ID of last playlist playing</description>
876- </key>
877- <key type="x" name="last-media-playing">
878- <default>0</default>
879- <summary>ID of last media playing</summary>
880- <description>ID of last media playing</description>
881- </key>
882- <key type="i" name="last-media-position">
883- <default>0</default>
884- <summary>Position, in seconds, of media</summary>
885- <description>Position, in seconds, of media when noise last closed</description>
886- </key>
887- <key enum="org.pantheon.noise.shuffle" name="shuffle-mode">
888- <default>'off'</default>
889- <summary>An index representing the shuffle mode</summary>
890- <description>An index representing the shuffle mode</description>
891- </key>
892- <key enum="org.pantheon.noise.repeat" name="repeat-mode">
893- <default>'off'</default>
894- <summary>An index representing the repeat mode</summary>
895- <description>An index representing the repeat mode</description>
896- </key>
897- <key type="s" name="search-string">
898- <default>''</default>
899- <summary>String of last search</summary>
900- <description>String of last search</description>
901- </key>
902- <key type="s" name="path-string">
903- <default>'$ALBUM_ARTIST/$ALBUM/$TRACK - $TITLE'</default>
904- <summary>String of the destination path to save files</summary>
905- <description>String of the destination path to save files</description>
906- </key>
907- <key type="as" name="plugins-disabled">
908- <default>[]</default>
909- <summary>List of disabled plugins</summary>
910- <description>Plugin modules to not load during startup</description>
911- </key>
912- </schema>
913-
914- <schema path="/org/pantheon/noise/saved-state/" id="org.pantheon.noise.saved-state">
915- <key type="i" name="window-width">
916- <default>1100</default>
917- <summary>Window width</summary>
918- <description>Window width</description>
919- </key>
920- <key type="i" name="window-height">
921- <default>600</default>
922- <summary>Window height</summary>
923- <description>Window height</description>
924- </key>
925- <key enum="org.pantheon.noise.windowstate" name="window-state">
926- <default>'normal'</default>
927- <summary>The saved state of the window.</summary>
928- <description>The saved state of the window.</description>
929- </key>
930- <key type="i" name="sidebar-width">
931- <default>200</default>
932- <summary>Sidebar width</summary>
933- <description>Sidebar width</description>
934- </key>
935- <key type="i" name="more-width">
936- <default>150</default>
937- <summary>Right panel width</summary>
938- <description>Right panel width</description>
939- </key>
940- <key type="i" name="view-mode">
941- <default>1</default>
942- <summary>Index of which view type to use</summary>
943- <description>Index of which view type to use</description>
944- </key>
945- <key type="b" name="more-visible">
946- <default>false</default>
947- <summary>Whether or not the right panel is showing</summary>
948- <description>Whether or not the right panel is showing</description>
949- </key>
950- <key type="b" name="column-browser-enabled">
951- <default>false</default>
952- <summary>Whether or not the column browser is enabled</summary>
953- <description>Whether or not the column browser is enabled</description>
954- </key>
955- <key type="b" name="show-album-art-in-list-view">
956- <default>false</default>
957- <summary>Enables/disables album-art showing in the list view</summary>
958- <description>Whether or not to show album art in the list view</description>
959- </key>
960- <key type="i" name="column-browser-width">
961- <default>200</default>
962- <summary>column-browser column width</summary>
963- <description>column-browser column width</description>
964- </key>
965- <key type="i" name="column-browser-height">
966- <default>200</default>
967- <summary>column-browser column height</summary>
968- <description>column-browser column height</description>
969- </key>
970- <key type="i" name="column-browser-position">
971- <default>0</default>
972- <summary>column-browser columns position</summary>
973- <description>column-browser columns position</description>
974- </key>
975- <key type="as" name="column-browser-visible-columns">
976- <default>['3', '5', '6']</default>
977- <summary>Enabled column-browser columns for the music library view</summary>
978- <description>Enabled column-browser columns for the music library view</description>
979- </key>
980- </schema>
981-
982- <schema path="/org/pantheon/noise/equalizer/" id="org.pantheon.noise.equalizer">
983- <key type="b" name="equalizer-enabled">
984- <default>false</default>
985- <summary>Whether or not the equalizer is enabled</summary>
986- <description>Whether or not the equalizer is enabled</description>
987- </key>
988- <key type="s" name="selected-preset">
989- <default>''</default>
990- <summary>Contains the name of the user-selected preset</summary>
991- <description>Contains information regarding the user-selected preset</description>
992- </key>
993- <key type="as" name="custom-presets">
994- <default>[]</default>
995- <summary>Custom Equalizer Presets</summary>
996- <description>Contains the list of presets added by the user. Gain values are between -80 and 80</description>
997- </key>
998- <key type="b" name="auto-switch-preset">
999- <default>true</default>
1000- <summary>Whether or not to use the auto preset</summary>
1001- <description>Whether or not to use the auto preset</description>
1002- </key>
1003- </schema>
1004-</schemalist>
1005
1006=== modified file 'src/LocalBackend/LocalLibrary.vala'
1007--- src/LocalBackend/LocalLibrary.vala 2016-12-31 17:15:12 +0000
1008+++ src/LocalBackend/LocalLibrary.vala 2017-03-02 02:52:40 +0000
1009@@ -157,7 +157,7 @@
1010
1011 return false;
1012 }
1013-
1014+
1015 public void remove_all_static_playlists () {
1016 var list = new Gee.TreeSet<int64?> ();
1017 lock (_playlists) {
1018@@ -176,7 +176,7 @@
1019 string m_folder = folder;
1020 m_folder = m_folder.replace ("/media", "");
1021 m_folder = m_folder.replace (GLib.Environment.get_home_dir ()+ "/", "");
1022-
1023+
1024 if (start_file_operations (_("Importing music from %s…").printf ("<b>" + Markup.escape_text (m_folder) + "</b>"))) {
1025 remove_all_static_playlists ();
1026
1027@@ -263,7 +263,7 @@
1028 // get a list of the current files
1029 var music_folder_dir = Settings.Main.get_default ().music_folder;
1030 FileUtils.count_music_files (File.new_for_path (music_folder_dir), files);
1031-
1032+
1033 foreach (var m in get_medias ()) {
1034 if (!m.isTemporary && !m.isPreview && m.uri.contains (music_folder_dir))
1035
1036@@ -518,7 +518,7 @@
1037
1038
1039 /******************** Media stuff ******************/
1040-
1041+
1042 public override void search_medias (string search) {
1043 if (search == "") {
1044 lock (_searched_medias) {
1045@@ -532,7 +532,6 @@
1046 uint parsed_rating;
1047 string parsed_search_string;
1048 String.base_search_method (search, out parsed_rating, out parsed_search_string);
1049- bool rating_search = parsed_rating > 0;
1050 // If we search for a special rating, don't search for something else.
1051 try {
1052 if (parsed_rating > 0) {
1053
1054=== modified file 'src/Noise.vala'
1055--- src/Noise.vala 2016-12-31 17:15:12 +0000
1056+++ src/Noise.vala 2017-03-02 02:52:40 +0000
1057@@ -46,9 +46,9 @@
1058 exec_name = "noise";
1059
1060 app_copyright = "2012-2016";
1061- application_id = "org.pantheon.noise";
1062+ application_id = "io.elementary.noise";
1063 app_icon = "multimedia-audio-player";
1064- app_launcher = "org.pantheon.noise.desktop";
1065+ app_launcher = "io.elementary.noise.desktop";
1066 app_years = "2012-2016";
1067
1068 main_url = "https://launchpad.net/noise";
1069@@ -61,7 +61,7 @@
1070
1071 about_artists = {"Daniel Foré <daniel@elementary.io>", null};
1072 about_translators = _("translator-credits");
1073-
1074+
1075 var present_action = new SimpleAction ("app.present", null);
1076 present_action.activate.connect (() => {
1077 if (main_window != null) {
1078
1079=== modified file 'src/Objects/HistoryPlaylist.vala'
1080--- src/Objects/HistoryPlaylist.vala 2016-12-31 17:15:12 +0000
1081+++ src/Objects/HistoryPlaylist.vala 2017-03-02 02:52:40 +0000
1082@@ -76,7 +76,7 @@
1083 event.timestamp = time;
1084 event.interpretation = Zeitgeist.ZG.ACCESS_EVENT;
1085 event.manifestation = Zeitgeist.ZG.USER_ACTIVITY;
1086- event.actor = "application://org.pantheon.noise.desktop";
1087+ event.actor = "application://io.elementary.noise.desktop";
1088 event.add_subject (subject);
1089
1090 try {
1091@@ -270,18 +270,18 @@
1092 var event = new Zeitgeist.Event ();
1093 event.manifestation = Zeitgeist.ZG.USER_ACTIVITY;
1094 event.actor = "application://%s".printf (id);
1095-
1096+
1097 var events = new GenericArray<Zeitgeist.Event> ();
1098 events.add (event);
1099-
1100+
1101 var event2 = new Zeitgeist.Event ();
1102 event2.manifestation = Zeitgeist.ZG.USER_ACTIVITY;
1103 var subj = new Zeitgeist.Subject ();
1104 subj.uri = "application://%s".printf (id);
1105 event2.add_subject (subj);
1106-
1107+
1108 events.add (event2);
1109-
1110+
1111 try {
1112 uint32[] results = yield log.find_event_ids (new Zeitgeist.TimeRange.anytime (),
1113 events,
1114@@ -289,7 +289,7 @@
1115 0,
1116 Zeitgeist.ResultType.MOST_RECENT_EVENTS,
1117 null);
1118-
1119+
1120 var counter = results.length/100;
1121 store.set_value (iter, 5, counter);
1122 } catch (Error e) {

Subscribers

People subscribed via source and target branches