Merge lp:~hyuchia/audience/fix-1594598 into lp:~audience-members/audience/trunk

Proposed by Diego Islas Ocampo
Status: Needs review
Proposed branch: lp:~hyuchia/audience/fix-1594598
Merge into: lp:~audience-members/audience/trunk
Diff against target: 389 lines (+159/-159)
9 files modified
data/CMakeLists.txt (+8/-8)
data/io.elementary.audience.appdata.xml.in (+66/-0)
data/io.elementary.audience.desktop.in.in (+19/-0)
data/io.elementary.audience.gschema.xml (+63/-0)
data/org.pantheon.audience.appdata.xml.in (+0/-66)
data/org.pantheon.audience.desktop.in.in (+0/-19)
data/org.pantheon.audience.gschema.xml (+0/-63)
src/Audience.vala (+2/-2)
src/Settings.vala (+1/-1)
To merge this branch: bzr merge lp:~hyuchia/audience/fix-1594598
Reviewer Review Type Date Requested Status
Jeremy Wootten code Needs Fixing
Review via email: mp+318706@code.launchpad.net

Description of the change

Set the right scheme, replacing the org.pantheon for io.elementary and the corresponding paths.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Instead of removing and adding files, you should use bzr mv. This will reduce the diff and make it easier to see what has actually changed in the files.

review: Needs Fixing (code)
Revision history for this message
Danielle Foré (danrabbit) wrote :

Audience has migrated to GitHub. Please resubmit as a PR here: https://github.com/elementary/videos

Unmerged revisions

731. By Diego Islas Ocampo

Use the right reversed elementary Scheme

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'build'
2=== added directory 'build/data'
3=== modified file 'data/CMakeLists.txt'
4--- data/CMakeLists.txt 2016-08-02 03:30:25 +0000
5+++ data/CMakeLists.txt 2017-03-02 02:26:06 +0000
6@@ -4,21 +4,21 @@
7
8 # We need to create two temporary desktop files in order to have all translations available.
9 set (APP_NAME "Videos")
10-configure_file(org.pantheon.audience.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.desktop.in)
11+configure_file(io.elementary.audience.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.desktop.in)
12 set (APP_NAME "Audience")
13-configure_file(org.pantheon.audience.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/audience-original.desktop.in)
14+configure_file(io.elementary.audience.desktop.in.in ${CMAKE_CURRENT_BINARY_DIR}/audience-original.desktop.in)
15
16 if (BUILD_FOR_ELEMENTARY)
17- configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.desktop ${CMAKE_SOURCE_DIR}/po/)
18+ configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.desktop ${CMAKE_SOURCE_DIR}/po/)
19 else ()
20- configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/audience-original.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.desktop ${CMAKE_SOURCE_DIR}/po/)
21+ configure_file_translation(${CMAKE_CURRENT_BINARY_DIR}/audience-original.desktop.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.desktop ${CMAKE_SOURCE_DIR}/po/)
22 endif ()
23
24-configure_file_translation (org.pantheon.audience.appdata.xml.in ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.appdata.xml ${CMAKE_SOURCE_DIR}/po/)
25+configure_file_translation (io.elementary.audience.appdata.xml.in ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.appdata.xml ${CMAKE_SOURCE_DIR}/po/)
26
27-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.desktop DESTINATION ${DATADIR}/applications/)
28-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.audience.appdata.xml DESTINATION ${DATADIR}/appdata/)
29+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.desktop DESTINATION ${DATADIR}/applications/)
30+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/io.elementary.audience.appdata.xml DESTINATION ${DATADIR}/appdata/)
31
32 include (GSettings)
33
34-add_schema (org.pantheon.audience.gschema.xml)
35+add_schema (io.elementary.audience.gschema.xml)
36
37=== added file 'data/io.elementary.audience.appdata.xml.in'
38--- data/io.elementary.audience.appdata.xml.in 1970-01-01 00:00:00 +0000
39+++ data/io.elementary.audience.appdata.xml.in 2017-03-02 02:26:06 +0000
40@@ -0,0 +1,66 @@
41+<?xml version="1.0" encoding="UTF-8"?>
42+<!-- Copyright 2015-2016 elementary, LLC <contact@elementary.io> -->
43+<component type="desktop">
44+ <id>io.elementary.audience.desktop</id>
45+ <metadata_license>CC0-1.0</metadata_license>
46+ <project_group>elementary</project_group>
47+ <project_license>GPL-3.0+</project_license>
48+ <_name>Audience</_name>
49+ <_summary>Watch videos and movies</_summary>
50+ <description>
51+ <_p>
52+ A modern video player that focuses on displaying video content instead of
53+ player controls. It remembers your last played video and playback position
54+ so you can pick up from where you left off.
55+ </_p>
56+ <_p>
57+ Additional features include:
58+ </_p>
59+ <ul>
60+ <_li>Subtitle support</_li>
61+ <_li>Play queue</_li>
62+ <_li>Thumbnail previews on the seek bar</_li>
63+ </ul>
64+ </description>
65+ <provides>
66+ <binary>audience</binary>
67+ </provides>
68+ <releases>
69+ <release version="0.2.1.2" date="2017-01-19" urgency="medium">
70+ <description>
71+ <ul>
72+ <_li>Translation updates</_li>
73+ </ul>
74+ </description>
75+ </release>
76+ <release version="0.2.1.1" date="2016-10-31" urgency="medium">
77+ <description>
78+ <ul>
79+ <_li>Fix appstream date format</_li>
80+ </ul>
81+ </description>
82+ </release>
83+ <release version="0.2.1" date="2016-10-31" urgency="medium">
84+ <description>
85+ <ul>
86+ <_li>Added a library view with search</_li>
87+ <_li>Fixed a bug that prevents keyboard navigation</_li>
88+ <_li>Translation updates</_li>
89+ </ul>
90+ </description>
91+ </release>
92+ <release version="0.2.0.2" date="2016-05-05" urgency="medium">
93+ <description>
94+ <ul>
95+ <_li>Minor bug fixes</_li>
96+ </ul>
97+ </description>
98+ </release>
99+ </releases>
100+ <developer_name>elementary LLC.</developer_name>
101+ <url type="homepage">http://elementary.io/</url>
102+ <url type="bugtracker">https://bugs.launchpad.net/audience</url>
103+ <url type="donation">https://elementary.io/get-involved#funding</url>
104+ <url type="help">https://elementaryos.stackexchange.com/questions/tagged/videos</url>
105+ <update_contact>contact_AT_elementary.io</update_contact>
106+</component>
107
108=== added file 'data/io.elementary.audience.desktop.in.in'
109--- data/io.elementary.audience.desktop.in.in 1970-01-01 00:00:00 +0000
110+++ data/io.elementary.audience.desktop.in.in 2017-03-02 02:26:06 +0000
111@@ -0,0 +1,19 @@
112+[Desktop Entry]
113+Version=1.0
114+_Name=@APP_NAME@
115+_GenericName=Video Player
116+_Comment=Watch videos and movies
117+Exec=audience %U
118+Icon=multimedia-video-player
119+StartupNotify=true
120+Terminal=false
121+Type=Application
122+Categories=AudioVideo;Video;Player;TV;
123+MimeType=application/x-musepack;application/musepack;application/x-ape;application/x-id3;application/ogg;application/x-ogg;application/x-vorbis+ogg;application/x-flac;video/quicktime;video/x-quicktime;application/x-quicktimeplayer;application/smil;application/vnd.rn-realmedia;video/vnd.rn-realvideo;application/asx;video/x-ms-asf-plugin;video/x-msvideo;video/msvideo;application/x-mplayer2;application/x-ms-wmv;video/x-ms-asf;video/x-ms-wm;video/x-ms-wmv;video/x-ms-wmp;video/x-ms-wvx;application/x-drm-v2;video/mpeg;video/x-mpeg;video/x-mpeg2;video/mp4;video/3gpp;video/fli;video/x-fli;video/x-flv;video/vnd.vivo;application/x-nsv-vp3-mp3;video/x-matroska;video/matroska;video/x-mng;video/webm;video/x-webm;video/mp2t;video/vnd.mpegurl;video/x-ogm+ogg;
124+X-GNOME-Gettext-Domain=audience
125+X-PulseAudio-Properties=media.role=video
126+Actions=AboutDialog;
127+
128+[Desktop Action AboutDialog]
129+Exec=audience --about
130+Name=About @APP_NAME@
131
132=== added file 'data/io.elementary.audience.gschema.xml'
133--- data/io.elementary.audience.gschema.xml 1970-01-01 00:00:00 +0000
134+++ data/io.elementary.audience.gschema.xml 2017-03-02 02:26:06 +0000
135@@ -0,0 +1,63 @@
136+<schemalist>
137+ <schema path="/io/elementary/audience/" id="io.elementary.audience" gettext-domain="audience">
138+ <key name="subtitle-font" type="s">
139+ <default>"Open Sans Bold"</default>
140+ <summary>Set the default font of video subtitles</summary>
141+ </key>
142+ <key name="move-window" type="b">
143+ <default>true</default>
144+ <summary>Move the window</summary>
145+ <description>Allow moving the window by dragging on the canvas</description>
146+ </key>
147+ <key name="keep-aspect" type="b">
148+ <default>true</default>
149+ <summary>Keep the video's aspect ratio</summary>
150+ <description>Lock window resizing to the aspect ration of the current video</description>
151+ </key>
152+ <key name="resume-videos" type="b">
153+ <default>true</default>
154+ <summary>Resume videos</summary>
155+ <description>Resume video at the point they were stopped when audience was closed</description>
156+ </key>
157+ <key name="last-played-videos" type="as">
158+ <default>[]</default>
159+ <summary>List of last played videos</summary>
160+ <description>A list of the last played</description>
161+ </key>
162+ <key name="current-video" type="s">
163+ <default>""</default>
164+ <summary>last played video</summary>
165+ <description></description>
166+ </key>
167+ <key name="last-stopped" type="d">
168+ <default>0</default>
169+ <summary>Last stopped time of last played video</summary>
170+ <description>Last stopped time of last played video</description>
171+ </key>
172+ <key name="last-folder" type="s">
173+ <default>"-1"</default>
174+ <summary>The last visited folder</summary>
175+ <description>The last folder you visited</description>
176+ </key>
177+ <key name="playback-wait" type="b">
178+ <default>false</default>
179+ <summary>Don't instantly start video playback</summary>
180+ <description>Audience doesn't play an opened file instantly, but waits until you explicitely play it, allowing you to seek to some place or do some settings before watching</description>
181+ </key>
182+ <key name="stay-on-top" type="b">
183+ <default>false</default>
184+ <summary>Cause the audience window to stay on top by default when it's playing</summary>
185+ <description>Set the option to keep the audience window above all other windows by default when audience is currently playing</description>
186+ </key>
187+ <key name="library-folder" type="s">
188+ <default>""</default>
189+ <summary>Library folder</summary>
190+ <description></description>
191+ </key>
192+ <key name="poster-names" type="as">
193+ <default>['poster.jpg','Poster.jpg','cover.jpg','Cover.jpg']</default>
194+ <summary>Poster file names</summary>
195+ <description></description>
196+ </key>
197+ </schema>
198+</schemalist>
199
200=== removed file 'data/org.pantheon.audience.appdata.xml.in'
201--- data/org.pantheon.audience.appdata.xml.in 2017-01-19 22:20:11 +0000
202+++ data/org.pantheon.audience.appdata.xml.in 1970-01-01 00:00:00 +0000
203@@ -1,66 +0,0 @@
204-<?xml version="1.0" encoding="UTF-8"?>
205-<!-- Copyright 2015-2016 elementary, LLC <contact@elementary.io> -->
206-<component type="desktop">
207- <id>org.pantheon.audience.desktop</id>
208- <metadata_license>CC0-1.0</metadata_license>
209- <project_group>elementary</project_group>
210- <project_license>GPL-3.0+</project_license>
211- <_name>Audience</_name>
212- <_summary>Watch videos and movies</_summary>
213- <description>
214- <_p>
215- A modern video player that focuses on displaying video content instead of
216- player controls. It remembers your last played video and playback position
217- so you can pick up from where you left off.
218- </_p>
219- <_p>
220- Additional features include:
221- </_p>
222- <ul>
223- <_li>Subtitle support</_li>
224- <_li>Play queue</_li>
225- <_li>Thumbnail previews on the seek bar</_li>
226- </ul>
227- </description>
228- <provides>
229- <binary>audience</binary>
230- </provides>
231- <releases>
232- <release version="0.2.1.2" date="2017-01-19" urgency="medium">
233- <description>
234- <ul>
235- <_li>Translation updates</_li>
236- </ul>
237- </description>
238- </release>
239- <release version="0.2.1.1" date="2016-10-31" urgency="medium">
240- <description>
241- <ul>
242- <_li>Fix appstream date format</_li>
243- </ul>
244- </description>
245- </release>
246- <release version="0.2.1" date="2016-10-31" urgency="medium">
247- <description>
248- <ul>
249- <_li>Added a library view with search</_li>
250- <_li>Fixed a bug that prevents keyboard navigation</_li>
251- <_li>Translation updates</_li>
252- </ul>
253- </description>
254- </release>
255- <release version="0.2.0.2" date="2016-05-05" urgency="medium">
256- <description>
257- <ul>
258- <_li>Minor bug fixes</_li>
259- </ul>
260- </description>
261- </release>
262- </releases>
263- <developer_name>elementary LLC.</developer_name>
264- <url type="homepage">http://elementary.io/</url>
265- <url type="bugtracker">https://bugs.launchpad.net/audience</url>
266- <url type="donation">https://elementary.io/get-involved#funding</url>
267- <url type="help">https://elementaryos.stackexchange.com/questions/tagged/videos</url>
268- <update_contact>contact_AT_elementary.io</update_contact>
269-</component>
270
271=== removed file 'data/org.pantheon.audience.desktop.in.in'
272--- data/org.pantheon.audience.desktop.in.in 2016-08-02 03:31:45 +0000
273+++ data/org.pantheon.audience.desktop.in.in 1970-01-01 00:00:00 +0000
274@@ -1,19 +0,0 @@
275-[Desktop Entry]
276-Version=1.0
277-_Name=@APP_NAME@
278-_GenericName=Video Player
279-_Comment=Watch videos and movies
280-Exec=audience %U
281-Icon=multimedia-video-player
282-StartupNotify=true
283-Terminal=false
284-Type=Application
285-Categories=AudioVideo;Video;Player;TV;
286-MimeType=application/x-musepack;application/musepack;application/x-ape;application/x-id3;application/ogg;application/x-ogg;application/x-vorbis+ogg;application/x-flac;video/quicktime;video/x-quicktime;application/x-quicktimeplayer;application/smil;application/vnd.rn-realmedia;video/vnd.rn-realvideo;application/asx;video/x-ms-asf-plugin;video/x-msvideo;video/msvideo;application/x-mplayer2;application/x-ms-wmv;video/x-ms-asf;video/x-ms-wm;video/x-ms-wmv;video/x-ms-wmp;video/x-ms-wvx;application/x-drm-v2;video/mpeg;video/x-mpeg;video/x-mpeg2;video/mp4;video/3gpp;video/fli;video/x-fli;video/x-flv;video/vnd.vivo;application/x-nsv-vp3-mp3;video/x-matroska;video/matroska;video/x-mng;video/webm;video/x-webm;video/mp2t;video/vnd.mpegurl;video/x-ogm+ogg;
287-X-GNOME-Gettext-Domain=audience
288-X-PulseAudio-Properties=media.role=video
289-Actions=AboutDialog;
290-
291-[Desktop Action AboutDialog]
292-Exec=audience --about
293-Name=About @APP_NAME@
294
295=== removed file 'data/org.pantheon.audience.gschema.xml'
296--- data/org.pantheon.audience.gschema.xml 2016-09-18 18:48:48 +0000
297+++ data/org.pantheon.audience.gschema.xml 1970-01-01 00:00:00 +0000
298@@ -1,63 +0,0 @@
299-<schemalist>
300- <schema path="/org/pantheon/audience/" id="org.pantheon.audience" gettext-domain="audience">
301- <key name="subtitle-font" type="s">
302- <default>"Open Sans Bold"</default>
303- <summary>Set the default font of video subtitles</summary>
304- </key>
305- <key name="move-window" type="b">
306- <default>true</default>
307- <summary>Move the window</summary>
308- <description>Allow moving the window by dragging on the canvas</description>
309- </key>
310- <key name="keep-aspect" type="b">
311- <default>true</default>
312- <summary>Keep the video's aspect ratio</summary>
313- <description>Lock window resizing to the aspect ration of the current video</description>
314- </key>
315- <key name="resume-videos" type="b">
316- <default>true</default>
317- <summary>Resume videos</summary>
318- <description>Resume video at the point they were stopped when audience was closed</description>
319- </key>
320- <key name="last-played-videos" type="as">
321- <default>[]</default>
322- <summary>List of last played videos</summary>
323- <description>A list of the last played</description>
324- </key>
325- <key name="current-video" type="s">
326- <default>""</default>
327- <summary>last played video</summary>
328- <description></description>
329- </key>
330- <key name="last-stopped" type="d">
331- <default>0</default>
332- <summary>Last stopped time of last played video</summary>
333- <description>Last stopped time of last played video</description>
334- </key>
335- <key name="last-folder" type="s">
336- <default>"-1"</default>
337- <summary>The last visited folder</summary>
338- <description>The last folder you visited</description>
339- </key>
340- <key name="playback-wait" type="b">
341- <default>false</default>
342- <summary>Don't instantly start video playback</summary>
343- <description>Audience doesn't play an opened file instantly, but waits until you explicitely play it, allowing you to seek to some place or do some settings before watching</description>
344- </key>
345- <key name="stay-on-top" type="b">
346- <default>false</default>
347- <summary>Cause the audience window to stay on top by default when it's playing</summary>
348- <description>Set the option to keep the audience window above all other windows by default when audience is currently playing</description>
349- </key>
350- <key name="library-folder" type="s">
351- <default>""</default>
352- <summary>Library folder</summary>
353- <description></description>
354- </key>
355- <key name="poster-names" type="as">
356- <default>['poster.jpg','Poster.jpg','cover.jpg','Cover.jpg']</default>
357- <summary>Poster file names</summary>
358- <description></description>
359- </key>
360- </schema>
361-</schemalist>
362
363=== modified file 'src/Audience.vala'
364--- src/Audience.vala 2016-09-22 17:36:54 +0000
365+++ src/Audience.vala 2017-03-02 02:26:06 +0000
366@@ -56,8 +56,8 @@
367
368 app_years = "2011-2016";
369 app_icon = "multimedia-video-player";
370- app_launcher = "org.pantheon.audience.desktop";
371- application_id = "org.pantheon.audience";
372+ app_launcher = "io.elementary.audience.desktop";
373+ application_id = "io.elementary.audience";
374
375 main_url = "https://code.launchpad.net/audience";
376 bug_url = "https://bugs.launchpad.net/audience";
377
378=== modified file 'src/Settings.vala'
379--- src/Settings.vala 2016-09-19 21:14:24 +0000
380+++ src/Settings.vala 2017-03-02 02:26:06 +0000
381@@ -33,7 +33,7 @@
382 public string[] poster_names {get; set;}
383
384 public Settings () {
385- base ("org.pantheon.audience");
386+ base ("io.elementary.audience");
387 }
388
389 }

Subscribers

People subscribed via source and target branches