Merge lp:~hyuchia/appcenter/release-info into lp:~elementary-apps/appcenter/appcenter

Proposed by Diego Islas Ocampo
Status: Merged
Approved by: Jeremy Wootten
Approved revision: 413
Merged at revision: 410
Proposed branch: lp:~hyuchia/appcenter/release-info
Merge into: lp:~elementary-apps/appcenter/appcenter
Diff against target: 103 lines (+58/-29)
2 files modified
data/CMakeLists.txt (+1/-1)
data/appcenter.appdata.xml.in (+57/-28)
To merge this branch: bzr merge lp:~hyuchia/appcenter/release-info
Reviewer Review Type Date Requested Status
Jeremy Wootten code Approve
Review via email: mp+318870@code.launchpad.net

Commit message

* Add release information to the AppData.xml

Description of the change

Add release information to the AppData.xml file for appcenter support.

To post a comment you must log in.
Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Misspelling noted inline

lp:~hyuchia/appcenter/release-info updated
411. By Diego Islas Ocampo

Fix typo

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

appstream-utils validate gave the following errors:

• tag-missing : <translation> not specified
• tag-invalid : <project_group> is not valid
• style-invalid : Not enough <screenshot> tags
• style-invalid : <ul> cannot start a description [(null)]
• style-invalid : <li> is too short [Minor Bug Fixes]
• style-invalid : Not enough <p> tags for a good description

The last three do not occur in trunk, however validate-relax does not give these last three errors (only gives tag missing error) so they may not be important.

lp:~hyuchia/appcenter/release-info updated
412. By Diego Islas Ocampo

Add release description paragraphs

413. By Diego Islas Ocampo

Update AppData installation path

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Passes appstreamcli validate (with minor warning regarding one of the translations).
I am not sure whether leaving the old version in /usr/share/appdata matters - maybe the package can deal with that?

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/CMakeLists.txt'
2--- data/CMakeLists.txt 2016-06-19 21:09:16 +0000
3+++ data/CMakeLists.txt 2017-03-07 03:35:01 +0000
4@@ -6,5 +6,5 @@
5
6 install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter.desktop DESTINATION share/applications)
7 install (FILES ${CMAKE_CURRENT_BINARY_DIR}/org.pantheon.appcenter-daemon.desktop DESTINATION share/applications)
8-install (FILES ${CMAKE_CURRENT_BINARY_DIR}/appcenter.appdata.xml DESTINATION share/appdata)
9+install (FILES ${CMAKE_CURRENT_BINARY_DIR}/appcenter.appdata.xml DESTINATION share/metainfo)
10
11
12=== modified file 'data/appcenter.appdata.xml.in'
13--- data/appcenter.appdata.xml.in 2016-06-18 14:56:43 +0000
14+++ data/appcenter.appdata.xml.in 2017-03-07 03:35:01 +0000
15@@ -1,31 +1,60 @@
16 <?xml version="1.0" encoding="UTF-8"?>
17 <!-- Copyright 2015 elementary, LLC <contact@elementary.io> -->
18-<component type="desktop">
19- <id>org.pantheon.appcenter.desktop</id>
20- <metadata_license>CC0-1.0</metadata_license>
21- <project_group>elementary</project_group>
22- <project_license>GPL-3.0+</project_license>
23- <_name>AppCenter</_name>
24- <_summary>Browse and manage apps</_summary>
25- <description>
26- <_p>
27- An app store for indie and open source developers. Browse by categories or
28- search and discover new apps. AppCenter is also used for updating your
29- system to the latest and greatest version for new features and fixes.
30- </_p>
31- </description>
32- <releases>
33- <release timestamp="1318750600" version="0.1"/>
34- </releases>
35- <provides>
36- <binary>appcenter</binary>
37- <binary>appcenter-daemon</binary>
38- <dbus type="user">org.pantheon.AppCenter</dbus>
39- </provides>
40- <developer_name>elementary LLC.</developer_name>
41- <url type="homepage">http://elementary.io/</url>
42- <url type="bugtracker">https://bugs.launchpad.net/appcenter</url>
43- <url type="donation">https://elementary.io/get-involved#funding</url>
44- <url type="help">https://elementaryos.stackexchange.com/questions/tagged/appcenter</url>
45- <update_contact>contact_at_elementary.io</update_contact>
46+<component type="desktop-application">
47+ <id>org.pantheon.appcenter.desktop</id>
48+ <metadata_license>CC0-1.0</metadata_license>
49+ <project_group>elementary</project_group>
50+ <project_license>GPL-3.0+</project_license>
51+ <_name>AppCenter</_name>
52+ <_summary>Browse and manage apps</_summary>
53+ <description>
54+ <_p>
55+ An app store for indie and open source developers. Browse by categories or
56+ search and discover new apps. AppCenter is also used for updating your
57+ system to the latest and greatest version for new features and fixes.
58+ </_p>
59+ </description>
60+ <releases>
61+ <release version="0.1.3" date="2016-12-05" urgency="medium">
62+ <description>
63+ <_p>Bug fixes and improve perfomance.</_p>
64+ <ul>
65+ <_li>Fix crash caused by entries with missing packages</_li>
66+ <_li>Translations Updates</_li>
67+ </ul>
68+ </description>
69+ </release>
70+ <release version="0.1.2" date="2016-10-29" urgency="medium">
71+ <description>
72+ <_p>Add capability to search by category and apply minor bug fixes.</_p>
73+ <ul>
74+ <_li>It is now possible to search apps inside a category</_li>
75+ <_li>Prevent multiple authentication dialogs when resuming from suspend</_li>
76+ <_li>Translations Updates</_li>
77+ </ul>
78+ </description>
79+ </release>
80+ <release version="0.1.1" date="2016-09-26" urgency="medium">
81+ <description>
82+ <_p>Search perfomance has beeen improved, the category name is now shown on the headbar and minor bugs have been fixed.</_p>
83+ <ul>
84+ <_li>Fix Steam installation</_li>
85+ <_li>Make search asynchronous</_li>
86+ <_li>Translations Updates</_li>
87+ </ul>
88+ </description>
89+ </release>
90+ <release version="0.1.0" date="2016-08-15"/>
91+ </releases>
92+ <provides>
93+ <binary>appcenter</binary>
94+ <binary>appcenter-daemon</binary>
95+ <dbus type="user">org.pantheon.AppCenter</dbus>
96+ </provides>
97+ <developer_name>elementary LLC.</developer_name>
98+ <url type="homepage">http://elementary.io/</url>
99+ <url type="bugtracker">https://bugs.launchpad.net/appcenter</url>
100+ <url type="donation">https://elementary.io/get-involved#funding</url>
101+ <url type="help">https://elementaryos.stackexchange.com/questions/tagged/appcenter</url>
102+ <update_contact>contact_at_elementary.io</update_contact>
103 </component>

Subscribers

People subscribed via source and target branches