Do

Merge lp:~hyperair/do/auto-disable-plugin-about-button into lp:do

  1. auto-disable-plugin-about-button
  2. Merge into trunk
Proposed by Chow Loong Jin
Status: Needs review
Proposed branch: lp:~hyperair/do/auto-disable-plugin-about-button
Merge into: lp:do
Diff against target: 14 lines (+3/-1)
1 file modified
Do/src/Do.UI/ManagePluginsPreferencesWidget.cs (+3/-1)
To merge this branch: bzr merge lp:~hyperair/do/auto-disable-plugin-about-button
Reviewer Review Type Date Requested Status
Do Core Team Pending
Review via email: mp+242039@code.launchpad.net

Description of the change

Disable the About button for plugins that don't have URLs. GNOME Do previously auto-generated a davebsd-wiki URL for plugins that didn't have the URL populated in their addin.xml files, but this logic is no longer present, so About does nothing when URL is missing.

This branch disables the About button completely so that users don't click on it expecting to see something.

To post a comment you must log in.
Revision history for this message
Chow Loong Jin (hyperair) wrote :

Related merge request: https://code.launchpad.net/~hyperair/do-plugins/drop-obsolete-urls/+merge/242038
Related bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=769980

Reply

Unmerged revisions

1410. By Chow Loong Jin

Disable About button when no URL is set for a plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Do/src/Do.UI/ManagePluginsPreferencesWidget.cs'
2--- Do/src/Do.UI/ManagePluginsPreferencesWidget.cs 2014-05-31 23:30:02 +0000
3+++ Do/src/Do.UI/ManagePluginsPreferencesWidget.cs 2014-11-18 04:13:56 +0000
4@@ -161,7 +161,9 @@
5 .SelectMany (id => PluginManager.ConfigurablesForAddin (id))
6 .Any ();
7
8- btn_about.Sensitive = nview.GetSelectedAddins ().Any ();
9+ btn_about.Sensitive = nview.GetSelectedAddins ()
10+ .Where (id => !string.IsNullOrEmpty (AddinManager.Registry.GetAddin (id).Description.Url))
11+ .Any ();
12 }
13
14 private void OnPluginToggled (string id, bool enabled)