Merge ~hyac109/plainbox-provider-certification-client:bootstrap-include-interface into plainbox-provider-certification-client:master

Proposed by Kristin Chuang
Status: Merged
Approved by: Kristin Chuang
Approved revision: ce64d5a386f7f8c45520d2c5373ca178dec0dd13
Merged at revision: 6c3b395ad197fdd70075f388160e100ac5fcccc3
Proposed branch: ~hyac109/plainbox-provider-certification-client:bootstrap-include-interface
Merge into: plainbox-provider-certification-client:master
Diff against target: 108 lines (+6/-6)
3 files modified
units/client-cert-iot-ubuntucore-16.pxu (+2/-2)
units/client-cert-iot-ubuntucore-18.pxu (+2/-2)
units/client-cert-iot-ubuntucore-20.pxu (+2/-2)
Reviewer Review Type Date Requested Status
Sylvain Pineau Approve
Review via email: mp+397216@code.launchpad.net

Commit message

move interface job from mandatory_include to bootstrap_include

Description of the change

This merge proposal aims to deal with the introduction of the plug checking job "snappy/check-plug_{{ snap }}_{{ name }}" (see MP: https://code.launchpad.net/~hyac109/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/397211), but will be beneficial to any future interface-dependent jobs that are added to a plan which nests the client-cert-iot-ubuntucore-.* whitelists (i.e. all future OEM projects):

snappy/check-plug_{{ snap }}_{{ name }} requires the "interface" resource job to be run first. To eliminate manual errors of forgetting to bootstrap_include the interface job when including the new job into a test plan, the client-cert-iot-ubuntucore-.* whitelists have been updated with the following changes:

- remove "interface" from mandatory_include
- add "interface" into bootstrap_include

An example outcome of a test plan that nests the updated client-cert-iot-ubuntucore-20 whitelist + includes the jobs snappy/check-plug_checkbox-snappy_.*:
https://certification.canonical.com/hardware/202011-28361/submission/199336/test-results/

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/client-cert-iot-ubuntucore-16.pxu b/units/client-cert-iot-ubuntucore-16.pxu
2index 884eb1b..e2adfcf 100644
3--- a/units/client-cert-iot-ubuntucore-16.pxu
4+++ b/units/client-cert-iot-ubuntucore-16.pxu
5@@ -22,7 +22,6 @@ mandatory_include:
6 dmi_attachment
7 dmesg_attachment
8 dpkg
9- interface
10 lsb
11 lspci_attachment
12 lsusb_attachment
13@@ -44,6 +43,7 @@ bootstrap_include:
14 bootloader
15 cpuinfo
16 device
17+ interface
18 net_if_management
19 nested_part:
20 self-manual
21@@ -99,7 +99,6 @@ mandatory_include:
22 dmi_attachment
23 dmesg_attachment
24 dpkg
25- interface
26 lsb
27 lspci_attachment
28 lsusb_attachment
29@@ -121,6 +120,7 @@ bootstrap_include:
30 bootloader
31 cpuinfo
32 device
33+ interface
34 net_if_management
35 nested_part:
36 self-automated
37diff --git a/units/client-cert-iot-ubuntucore-18.pxu b/units/client-cert-iot-ubuntucore-18.pxu
38index e7b16e5..cadc19f 100644
39--- a/units/client-cert-iot-ubuntucore-18.pxu
40+++ b/units/client-cert-iot-ubuntucore-18.pxu
41@@ -22,7 +22,6 @@ mandatory_include:
42 dmi_attachment
43 dmesg_attachment
44 dpkg
45- interface
46 lsb
47 lspci_attachment
48 lsusb_attachment
49@@ -44,6 +43,7 @@ bootstrap_include:
50 bootloader
51 cpuinfo
52 device
53+ interface
54 net_if_management
55 nested_part:
56 self-manual
57@@ -99,7 +99,6 @@ mandatory_include:
58 dmi_attachment
59 dmesg_attachment
60 dpkg
61- interface
62 lsb
63 lspci_attachment
64 lsusb_attachment
65@@ -121,6 +120,7 @@ bootstrap_include:
66 bootloader
67 cpuinfo
68 device
69+ interface
70 net_if_management
71 nested_part:
72 self-automated
73diff --git a/units/client-cert-iot-ubuntucore-20.pxu b/units/client-cert-iot-ubuntucore-20.pxu
74index aaaee38..6399c88 100644
75--- a/units/client-cert-iot-ubuntucore-20.pxu
76+++ b/units/client-cert-iot-ubuntucore-20.pxu
77@@ -22,7 +22,6 @@ mandatory_include:
78 dmi_attachment
79 dmesg_attachment
80 dpkg
81- interface
82 lsb
83 lspci_attachment
84 lsusb_attachment
85@@ -44,6 +43,7 @@ bootstrap_include:
86 bootloader
87 cpuinfo
88 device
89+ interface
90 net_if_management
91 nested_part:
92 self-manual
93@@ -100,7 +100,6 @@ mandatory_include:
94 dmi_attachment
95 dmesg_attachment
96 dpkg
97- interface
98 lsb
99 lspci_attachment
100 lsusb_attachment
101@@ -122,6 +121,7 @@ bootstrap_include:
102 bootloader
103 cpuinfo
104 device
105+ interface
106 net_if_management
107 nested_part:
108 self-automated

Subscribers

People subscribed via source and target branches