Merge lp:~huwshimi/maas/icon-underlines into lp:~maas-committers/maas/trunk

Proposed by Huw Wilkins
Status: Merged
Approved by: Huw Wilkins
Approved revision: no longer in the source branch.
Merged at revision: 1308
Proposed branch: lp:~huwshimi/maas/icon-underlines
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 23 lines (+2/-0)
2 files modified
src/maasserver/templates/maasserver/nodegroup_edit.html (+1/-0)
src/maasserver/templates/maasserver/settings_cluster_listing_row.html (+1/-0)
To merge this branch: bzr merge lp:~huwshimi/maas/icon-underlines
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+131404@code.launchpad.net

Commit message

Add icon classes to fix edit link hovers.

Description of the change

Added the "icon" class to edit links so that the hover underline doesn't appear.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

I'll have to trust your judgment on the CSS class. And there's not much else to review here!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/templates/maasserver/nodegroup_edit.html'
2--- src/maasserver/templates/maasserver/nodegroup_edit.html 2012-10-15 09:32:06 +0000
3+++ src/maasserver/templates/maasserver/nodegroup_edit.html 2012-10-25 13:22:21 +0000
4@@ -39,6 +39,7 @@
5 <td>{{ interface.display_management }}</td>
6 <td>
7 <a href="{% url 'cluster-interface-edit' uuid=cluster.uuid interface=interface.interface %}"
8+ class="icon"
9 title="Edit interface {{ interface.interface }}">
10 <img src="{{ STATIC_URL }}img/edit.png"
11 alt="edit"
12
13=== modified file 'src/maasserver/templates/maasserver/settings_cluster_listing_row.html'
14--- src/maasserver/templates/maasserver/settings_cluster_listing_row.html 2012-10-04 07:43:24 +0000
15+++ src/maasserver/templates/maasserver/settings_cluster_listing_row.html 2012-10-25 13:22:21 +0000
16@@ -3,6 +3,7 @@
17 <td>{{ cluster.cluster_name }}</td>
18 <td>
19 <a href="{% url 'cluster-edit' cluster.uuid %}"
20+ class="icon"
21 title="Edit cluster {{ cluster.cluster_name }}">
22 <img src="{{ STATIC_URL }}img/edit.png"
23 alt="edit"