Merge lp:~huwshimi/launchpad/tag-field-space-394342 into lp:launchpad

[Huw Wilkins]

[r=lifeless,mbp,wgrant][ui=none] [r=lifeless,mbp,wgrant][bug=394342] Removed initial space character from bug tag field when editing and there are no tags.

Removed initial space character from bug tag field when editing and there are no tags.

TO TEST:
View a bug that has no tags. Click "Add tags". The field should be completely empty (used to contain a single space character).

[Martin Pool (mbp)]

s/sting/string

is there a style guide saying there must be trailing semicolons

review: Needs Fixing

[Martin Pool (mbp)]

review: Approve

[William Grant (wgrant)]

review: Approve (code*)

[Robert Collins (lifeless)]

review: Approve

=== modified file 'lib/lp/bugs/javascript/bug_tags_entry.js'
--- lib/lp/bugs/javascript/bug_tags_entry.js	2011-02-08 03:15:37 +0000
+++ lib/lp/bugs/javascript/bug_tags_entry.js	2011-02-21 04:37:07 +0000
@@ -46,8 +46,14 @@
     tag_list_span.all(A).each(function(anchor) {
         tags.push(anchor.get(INNER_HTML));
     });
-
-    tag_input.set(VALUE, tags.join(' ') + ' ');
+    
+    var tag_list = tags.join(' ');
+    /* If there are tags then add a space to the end of the string so the user 
+       doesn't have to type one. */
+    if (tag_list != "") {
+        tag_list += ' ';
+    }
+    tag_input.set(VALUE, tag_list);
 };
 
 /**