Launchpad itself

Merge lp:~huwshimi/launchpad/gear-icon-visibility-894729 into lp:launchpad

  1. gear-icon-visibility-894729
  2. Merge into devel
Proposed by Huw Wilkins
Status: Merged
Approved by: Ian Booth
Approved revision: no longer in the source branch.
Merged at revision: 14542
Proposed branch: lp:~huwshimi/launchpad/gear-icon-visibility-894729
Merge into: lp:launchpad
Diff against target: 44 lines (+6/-4)
3 files modified
lib/lp/app/javascript/configutils.js (+1/-0)
lib/lp/app/javascript/ordering/assets/ordering-core.css (+4/-3)
lib/lp/app/javascript/ordering/ordering.js (+1/-1)
To merge this branch: bzr merge lp:~huwshimi/launchpad/gear-icon-visibility-894729
Reviewer Review Type Date Requested Status
Ian Booth (community) Approve
Review via email: mp+85986@code.launchpad.net

Commit message

[r=wallyworld][bug=894729] Bug listing config icon now is on the left, is a darker grey and has a tooltip.

Description of the change

There were reports that the gear icon was too subtle. I've moved the icon to the left so that it will be more frequently in the users field of vision and have also made the icon a lot darker.

While outside of this bug I also added a tooltip to the icon to help people understand what the icon is there for.

Here's a screenshot of the changes: https://launchpadlibrarian.net/87611663/configure_icon.png

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) wrote :

Looks like a nice improvement.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/images/config.png'
2Binary files lib/canonical/launchpad/images/config.png 2011-11-03 20:22:52 +0000 and lib/canonical/launchpad/images/config.png 2011-12-16 03:50:31 +0000 differ
3=== modified file 'lib/lp/app/javascript/configutils.js'
4--- lib/lp/app/javascript/configutils.js 2011-11-08 14:57:08 +0000
5+++ lib/lp/app/javascript/configutils.js 2011-12-16 03:50:31 +0000
6@@ -64,6 +64,7 @@
7 renderUI: function() {
8 var anchor = Y.Node.create(
9 '<a></a>').addClass('sprite').addClass('config');
10+ anchor.set('title', 'Customise visible bug information');
11 this.set('anchor', anchor);
12 var content = this.get(CONTENT_BOX);
13 content.append(anchor);
14
15=== modified file 'lib/lp/app/javascript/ordering/assets/ordering-core.css'
16--- lib/lp/app/javascript/ordering/assets/ordering-core.css 2011-12-05 07:00:37 +0000
17+++ lib/lp/app/javascript/ordering/assets/ordering-core.css 2011-12-16 03:50:31 +0000
18@@ -32,9 +32,10 @@
19 }
20
21 .yui3-orderbybar .config-widget {
22- float: right;
23- border-left: 1px solid #EEE;
24- margin: 3px;
25+ float: left;
26+ border-right: 1px solid #EEE;
27+ margin: 4px 3px;
28+ padding-right: 4px;
29 min-width: 20px;
30 min-height: 20px;
31 }
32
33=== modified file 'lib/lp/app/javascript/ordering/ordering.js'
34--- lib/lp/app/javascript/ordering/ordering.js 2011-12-08 13:23:00 +0000
35+++ lib/lp/app/javascript/ordering/ordering.js 2011-12-16 03:50:31 +0000
36@@ -356,7 +356,7 @@
37 if (this.get('config_slot')) {
38 var config_div = Y.Node.create('<div></div>').addClass(
39 'config-widget');
40- div.appendChild(config_div);
41+ div.prepend(config_div);
42 this.set('config_node', config_div);
43 }
44 this.get('srcNode').appendChild(div);