Merge lp:~huwshimi/launchpad/bug-listing-two-line into lp:launchpad

Proposed by huwshimi on 2012-01-12
Status: Merged
Approved by: huwshimi on 2012-01-12
Approved revision: no longer in the source branch.
Merged at revision: 14672
Proposed branch: lp:~huwshimi/launchpad/bug-listing-two-line
Merge into: lp:launchpad
Diff against target: 147 lines (+57/-60)
2 files modified
lib/canonical/launchpad/icing/css/components/bug_listing.css (+3/-6)
lib/lp/bugs/templates/buglisting.mustache (+54/-54)
To merge this branch: bzr merge lp:~huwshimi/launchpad/bug-listing-two-line
Reviewer Review Type Date Requested Status
Deryck Hodge (community) 2012-01-12 Approve on 2012-01-12
Review via email: mp+88350@code.launchpad.net

Commit Message

[r=deryck][bug=907765] Bug listing titles have more space. Extra fields are on a new line.

Description of the Change

Bug titles were wrapping too soon. This was because we tried to fit extra info on the first.

This branch moves extra info to a new line and gives the bug titles more space.

A large portion of the template was moved into a new div, requiring a change in indentation.

To post a comment you must log in.
Deryck Hodge (deryck) wrote :

Looks good, just ec2 land it so tests catch any HTML mis-steps.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/icing/css/components/bug_listing.css'
2--- lib/canonical/launchpad/icing/css/components/bug_listing.css 2011-12-21 06:19:51 +0000
3+++ lib/canonical/launchpad/icing/css/components/bug_listing.css 2012-01-12 11:34:29 +0000
4@@ -15,13 +15,10 @@
5 float: left;
6 padding-right: 10px;
7 }
8-div.buglisting-col2,
9-div.buglisting-col3 {
10+div.buglisting-col2 {
11 float: left;
12 margin-top: 2px;
13- }
14-div.buglisting-col2 {
15- width: 40%;
16+ width: 68%;
17 }
18 div#client-listing .status,
19 div#client-listing .importance {
20@@ -33,7 +30,7 @@
21 line-height: 12px;
22 text-align: center;
23 margin: 5px 10px 0 0;
24-}
25+ }
26 div#client-listing .importance {
27 width: 65px;
28 }
29
30=== modified file 'lib/lp/bugs/templates/buglisting.mustache'
31--- lib/lp/bugs/templates/buglisting.mustache 2011-12-20 00:00:03 +0000
32+++ lib/lp/bugs/templates/buglisting.mustache 2012-01-12 11:34:29 +0000
33@@ -22,60 +22,60 @@
34 {{/show_id}}
35 <a href="{{bug_url}}" class="bugtitle">{{title}}</a>
36 </div>
37- </div>
38- <div class="buglisting-col3">
39- {{#show_targetname}}
40- <span class="{{bugtarget_css}} field">
41- {{bugtarget}}
42- </span>
43- {{/show_targetname}}
44- {{#show_milestone_name}}
45- <span class="sprite milestone field">
46- {{#milestone_name}}
47- {{milestone_name}}
48- {{/milestone_name}}
49- {{^milestone_name}}
50- No milestone set
51- {{/milestone_name}}
52- </span>
53- {{/show_milestone_name}}
54- {{#show_date_last_updated}}
55- <span class="sprite milestone field">
56- Last updated {{last_updated}}
57- </span>
58- {{/show_date_last_updated}}
59- {{#show_assignee}}
60- <span class="sprite person field">
61- {{#assignee}}Assignee: {{assignee}}{{/assignee}}
62- {{^assignee}}Assignee: None{{/assignee}}
63- </span>
64- {{/show_assignee}}
65- {{#show_reporter}}
66- <span class="sprite person field">
67- Reporter: {{reporter}}
68- </span>
69- {{/show_reporter}}
70- {{#show_datecreated}}
71- <span class="sprite milestone field">
72- {{age}}
73- </span>
74- {{/show_datecreated}}
75- {{#show_tag}}
76- <span class="field">Tags:
77- {{^has_tags}}None{{/has_tags}}
78- {{#tags}}
79- <a href="{{url}}" class="tag">{{tag}}</a>&#160;
80- {{/tags}}
81- </span>
82- {{/show_tag}}
83- {{#show_heat}}
84- <span class="bug-heat-icons">
85- {{{bug_heat_html}}}
86- </span>
87- {{/show_heat}}
88- <span class="bug-related-icons">
89- {{{badges}}}
90- </span>
91+ <div class="buginfo-extra">
92+ {{#show_targetname}}
93+ <span class="{{bugtarget_css}} field">
94+ {{bugtarget}}
95+ </span>
96+ {{/show_targetname}}
97+ {{#show_milestone_name}}
98+ <span class="sprite milestone field">
99+ {{#milestone_name}}
100+ {{milestone_name}}
101+ {{/milestone_name}}
102+ {{^milestone_name}}
103+ No milestone set
104+ {{/milestone_name}}
105+ </span>
106+ {{/show_milestone_name}}
107+ {{#show_date_last_updated}}
108+ <span class="sprite milestone field">
109+ Last updated {{last_updated}}
110+ </span>
111+ {{/show_date_last_updated}}
112+ {{#show_assignee}}
113+ <span class="sprite person field">
114+ {{#assignee}}Assignee: {{assignee}}{{/assignee}}
115+ {{^assignee}}Assignee: None{{/assignee}}
116+ </span>
117+ {{/show_assignee}}
118+ {{#show_reporter}}
119+ <span class="sprite person field">
120+ Reporter: {{reporter}}
121+ </span>
122+ {{/show_reporter}}
123+ {{#show_datecreated}}
124+ <span class="sprite milestone field">
125+ {{age}}
126+ </span>
127+ {{/show_datecreated}}
128+ {{#show_tag}}
129+ <span class="field">Tags:
130+ {{^has_tags}}None{{/has_tags}}
131+ {{#tags}}
132+ <a href="{{url}}" class="tag">{{tag}}</a>&#160;
133+ {{/tags}}
134+ </span>
135+ {{/show_tag}}
136+ {{#show_heat}}
137+ <span class="bug-heat-icons">
138+ {{{bug_heat_html}}}
139+ </span>
140+ {{/show_heat}}
141+ <span class="bug-related-icons">
142+ {{{badges}}}
143+ </span>
144+ </div>
145 </div>
146
147 </div>