Merge lp:~huwshimi/juju-gui/panel-css-fixes into lp:juju-gui/experimental

Proposed by Huw Wilkins
Status: Merged
Merged at revision: 1220
Proposed branch: lp:~huwshimi/juju-gui/panel-css-fixes
Merge into: lp:juju-gui/experimental
Diff against target: 30 lines (+5/-1)
1 file modified
lib/views/juju-inspector.less (+5/-1)
To merge this branch: bzr merge lp:~huwshimi/juju-gui/panel-css-fixes
Reviewer Review Type Date Requested Status
Juju GUI Hackers Pending
Review via email: mp+197636@code.launchpad.net

Description of the change

Panel CSS fixes

Fixed the inspector unit details header not displaying all information.
Was: http://ubuntuone.com/1PcYJQYYW2wfvAaFTrCANz
Should be: http://ubuntuone.com/0aEn7C4sjP4kd8MXRifKi9

Fixed the browser open/close tab appearing under the inspector unit details panel.

https://codereview.appspot.com/36930043/

To post a comment you must log in.
Revision history for this message
Huw Wilkins (huwshimi) wrote :

Reviewers: mp+197636_code.launchpad.net,

Message:
Please take a look.

Description:
Panel CSS fixes

Fixed the inspector unit details header not displaying all information.
Was: http://ubuntuone.com/1PcYJQYYW2wfvAaFTrCANz
Should be: http://ubuntuone.com/0aEn7C4sjP4kd8MXRifKi9

Fixed the browser open/close tab appearing under the inspector unit
details panel.

https://code.launchpad.net/~huwshimi/juju-gui/panel-css-fixes/+merge/197636

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/36930043/

Affected files (+7, -1 lines):
   A [revision details]
   M lib/views/juju-inspector.less

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: lib/views/juju-inspector.less
=== modified file 'lib/views/juju-inspector.less'
--- lib/views/juju-inspector.less 2013-11-27 05:36:45 +0000
+++ lib/views/juju-inspector.less 2013-12-04 03:00:05 +0000
@@ -43,6 +43,7 @@

      .left-breakout {
          .type9;
+ z-index: 500;
          left: auto;
          right: @inspector-width;

@@ -53,6 +54,9 @@
              margin-top: 30px;
          }
          .unit-overview {
+ .header {
+ height: auto;
+ }
              .unit-info-tabs {
                  padding: 30px;

@@ -86,7 +90,7 @@
      .juju-inspector {
          .create-border-radius(@border-radius);
          position: relative;
- z-index: 500;
+ z-index: 501;
          width: @inspector-width;
          min-height: 100px;
          border: 0;

Revision history for this message
Jeff Pihach (hatch) wrote :
Revision history for this message
Huw Wilkins (huwshimi) wrote :

*** Submitted:

Panel CSS fixes

Fixed the inspector unit details header not displaying all information.
Was: http://ubuntuone.com/1PcYJQYYW2wfvAaFTrCANz
Should be: http://ubuntuone.com/0aEn7C4sjP4kd8MXRifKi9

Fixed the browser open/close tab appearing under the inspector unit
details panel.

R=jeff.pihach
CC=
https://codereview.appspot.com/36930043

https://codereview.appspot.com/36930043/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/views/juju-inspector.less'
2--- lib/views/juju-inspector.less 2013-11-27 05:36:45 +0000
3+++ lib/views/juju-inspector.less 2013-12-04 03:12:00 +0000
4@@ -43,6 +43,7 @@
5
6 .left-breakout {
7 .type9;
8+ z-index: 500;
9 left: auto;
10 right: @inspector-width;
11
12@@ -53,6 +54,9 @@
13 margin-top: 30px;
14 }
15 .unit-overview {
16+ .header {
17+ height: auto;
18+ }
19 .unit-info-tabs {
20 padding: 30px;
21
22@@ -86,7 +90,7 @@
23 .juju-inspector {
24 .create-border-radius(@border-radius);
25 position: relative;
26- z-index: 500;
27+ z-index: 501;
28 width: @inspector-width;
29 min-height: 100px;
30 border: 0;

Subscribers

People subscribed via source and target branches