Merge lp:~humpolec-team/humpolec/UbuntuInstaller_lp1260597 into lp:humpolec

Proposed by Yuan-Chen Cheng
Status: Merged
Merged at revision: 10
Proposed branch: lp:~humpolec-team/humpolec/UbuntuInstaller_lp1260597
Merge into: lp:humpolec
Diff against target: 28 lines (+6/-8)
1 file modified
assets/system-image-upgrader (+6/-8)
To merge this branch: bzr merge lp:~humpolec-team/humpolec/UbuntuInstaller_lp1260597
Reviewer Review Type Date Requested Status
Rex Tsai Approve
Yuan-Chen Cheng Needs Resubmitting
Review via email: mp+198878@code.launchpad.net

Description of the change

remove /data/.layout_version on format system, remove /data/SWAP.img, /data/system-data and /data/user-data on format data.

build and tested.

To post a comment you must log in.
Revision history for this message
Rex Tsai (chihchun) wrote :

why dont we just rm -rf "/data/SWAP.img" "/data/system-data" "/data/user-data" ?

review: Needs Information
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :
review: Needs Resubmitting
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

fix accordingly.

review: Needs Resubmitting
Revision history for this message
Rex Tsai (chihchun) wrote :

looks good.

review: Approve
10. By Yuan-Chen Cheng

remove /data/.layout_version on format system, remove /data/SWAP.img, /data/system-data and /data/user-data on format data

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'assets/system-image-upgrader'
2--- assets/system-image-upgrader 2013-12-12 02:02:35 +0000
3+++ assets/system-image-upgrader 2013-12-13 07:43:32 +0000
4@@ -152,18 +152,16 @@
5 system)
6 FULL_IMAGE=1
7 rm -f /data/system.img
8+ rm -f /data/.layout_version
9 busybox dd if=/dev/zero of=/data/system.img seek=500K bs=4096 count=1
10 busybox mkfs.ext2 -F /data/system.img
11 ;;
12
13-# too dangerous, so comment it out !
14-# data)
15-# for entry in /data/*; do
16-# if [ "$entry" != "system.img" ]; then
17-# rm -Rf $entry
18-# fi
19-# done
20-# ;;
21+ data)
22+ rm -f /data/SWAP.img
23+ rm -Rf /data/system-data
24+ rm -Rf /data/user-data
25+ ;;
26
27 *)
28 echo "Unknown format target: $2"

Subscribers

People subscribed via source and target branches

to all changes: