Merge lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar into lp:humpolec

Proposed by Rex Tsai
Status: Merged
Merge reported by: Rex Tsai
Merged at revision: not available
Proposed branch: lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar
Merge into: lp:humpolec
Diff against target: 49 lines (+21/-9)
1 file modified
res/drawable/ubuntu_progress.xml (+21/-9)
To merge this branch: bzr merge lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng Approve
Review via email: mp+200184@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rex Tsai (chihchun) wrote :

Teste on Nexus 10, fixed the tiled progressbar. Make it looks better on all screen.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

I test it on n10 and it fix the tiled progress bar. And it still works fine in n4.

The change make the orange progress bar not fill y-axis (exists before this change) more easy to see.

It will be even better if that also can be fixed.

review: Approve
Revision history for this message
Rex Tsai (chihchun) wrote :

y-axis issue need to be investigated, I will merge and close current MP first. :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'res/drawable/ubuntu_progress.xml'
--- res/drawable/ubuntu_progress.xml 2013-12-10 14:26:08 +0000
+++ res/drawable/ubuntu_progress.xml 2013-12-30 12:57:09 +0000
@@ -19,24 +19,36 @@
19-->19-->
2020
21<layer-list xmlns:android="http://schemas.android.com/apk/res/android" >21<layer-list xmlns:android="http://schemas.android.com/apk/res/android" >
2222
23 <item23 <item android:id="@android:id/background">
24 android:id="@android:id/background"24 <shape>
25 android:drawable="@drawable/ubuntu_progress_background">25 <corners android:radius="5dip" />
26 <gradient
27 android:angle="90"
28 android:centerColor="#ffffffff"
29 android:centerY="0.75"
30 android:endColor="#ffAEA79F"
31 android:startColor="#ffAEA79F" />
32 </shape>
26 </item>33 </item>
27 <item android:id="@android:id/secondaryProgress">34 <item android:id="@android:id/secondaryProgress">
28 <clip>35 <clip>
29 <shape>36 <shape>
30 <corners android:radius="5dip" />37 <corners android:radius="5dip" />
31
32 <gradient38 <gradient
33 android:endColor="#aaffffff"39 android:endColor="#dd4814"
34 android:startColor="#aaffffff" />40 android:startColor="#dd4814" />
35 </shape>41 </shape>
36 </clip>42 </clip>
37 </item>43 </item>
38 <item android:id="@android:id/progress">44 <item android:id="@android:id/progress">
39 <clip android:drawable="@drawable/ubuntu_progress_foreground" />45 <clip>
46 <shape>
47 <corners android:radius="5dip" />
48 <gradient
49 android:endColor="#dd4814"
50 android:startColor="#dd4814" />
51 </shape>
52 </clip>
40 </item>53 </item>
41
42</layer-list>54</layer-list>

Subscribers

People subscribed via source and target branches

to all changes: