Merge lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar into lp:humpolec

Proposed by Rex Tsai
Status: Merged
Merge reported by: Rex Tsai
Merged at revision: not available
Proposed branch: lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar
Merge into: lp:humpolec
Diff against target: 49 lines (+21/-9)
1 file modified
res/drawable/ubuntu_progress.xml (+21/-9)
To merge this branch: bzr merge lp:~humpolec-team/humpolec/UbuntuInstaller-progressbar
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng Approve
Review via email: mp+200184@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rex Tsai (chihchun) wrote :

Teste on Nexus 10, fixed the tiled progressbar. Make it looks better on all screen.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

I test it on n10 and it fix the tiled progress bar. And it still works fine in n4.

The change make the orange progress bar not fill y-axis (exists before this change) more easy to see.

It will be even better if that also can be fixed.

review: Approve
Revision history for this message
Rex Tsai (chihchun) wrote :

y-axis issue need to be investigated, I will merge and close current MP first. :-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'res/drawable/ubuntu_progress.xml'
2--- res/drawable/ubuntu_progress.xml 2013-12-10 14:26:08 +0000
3+++ res/drawable/ubuntu_progress.xml 2013-12-30 12:57:09 +0000
4@@ -19,24 +19,36 @@
5 -->
6
7 <layer-list xmlns:android="http://schemas.android.com/apk/res/android" >
8-
9- <item
10- android:id="@android:id/background"
11- android:drawable="@drawable/ubuntu_progress_background">
12+
13+ <item android:id="@android:id/background">
14+ <shape>
15+ <corners android:radius="5dip" />
16+ <gradient
17+ android:angle="90"
18+ android:centerColor="#ffffffff"
19+ android:centerY="0.75"
20+ android:endColor="#ffAEA79F"
21+ android:startColor="#ffAEA79F" />
22+ </shape>
23 </item>
24 <item android:id="@android:id/secondaryProgress">
25 <clip>
26 <shape>
27 <corners android:radius="5dip" />
28-
29 <gradient
30- android:endColor="#aaffffff"
31- android:startColor="#aaffffff" />
32+ android:endColor="#dd4814"
33+ android:startColor="#dd4814" />
34 </shape>
35 </clip>
36 </item>
37 <item android:id="@android:id/progress">
38- <clip android:drawable="@drawable/ubuntu_progress_foreground" />
39+ <clip>
40+ <shape>
41+ <corners android:radius="5dip" />
42+ <gradient
43+ android:endColor="#dd4814"
44+ android:startColor="#dd4814" />
45+ </shape>
46+ </clip>
47 </item>
48-
49 </layer-list>

Subscribers

People subscribed via source and target branches

to all changes: