Merge lp:~humpolec-team/humpolec/UbuntuInstaller-lp1262028 into lp:humpolec

Proposed by Rex Tsai
Status: Merged
Approved by: Ondrej Kubik
Approved revision: 25
Merged at revision: 25
Proposed branch: lp:~humpolec-team/humpolec/UbuntuInstaller-lp1262028
Merge into: lp:humpolec
Diff against target: 77 lines (+11/-6)
4 files modified
res/layout/ubuntu_dualboot_install.xml (+4/-3)
res/values/strings.xml (+1/-1)
src/com/canonical/ubuntu/installer/InstallActivity.java (+4/-1)
src/com/canonical/ubuntu/installer/LaunchActivity.java (+2/-1)
To merge this branch: bzr merge lp:~humpolec-team/humpolec/UbuntuInstaller-lp1262028
Reviewer Review Type Date Requested Status
Ondrej Kubik Approve
Review via email: mp+199631@code.launchpad.net

Description of the change

UX
* Kill old activity when launch a new one. (LP: #1262028)
* s/UbuntuInstaller/Ubuntu Dual Boot/ (LP: #1262212)
* Make UbuntuTextView expand the view.

To post a comment you must log in.
Revision history for this message
Rex Tsai (chihchun) wrote :

Another way to manage task stack, it's add "android:noHistory = "true"" into Androidmanifest.xml. Then the app will not keep old tasks. Back button always go back to home screen.

Revision history for this message
Ondrej Kubik (ondrak) wrote :

+1. We should exit current activity when switching to new one, otherwise it messes up stack.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'res/layout/ubuntu_dualboot_install.xml'
2--- res/layout/ubuntu_dualboot_install.xml 2013-12-12 02:02:35 +0000
3+++ res/layout/ubuntu_dualboot_install.xml 2013-12-19 09:42:54 +0000
4@@ -58,16 +58,17 @@
5 <com.canonical.ubuntu.widget.UbuntuTextView
6 android:id="@+id/terminal"
7 android:layout_width="match_parent"
8- android:layout_height="150dp"
9+ android:layout_height="match_parent"
10 android:layout_above="@id/progress_frame"
11+ android:layout_below="@+id/title"
12 android:layout_gravity="center"
13 android:layout_margin="16dp"
14 android:background="@color/terminalbg"
15 android:ellipsize="middle"
16 android:gravity="left"
17+ android:maxLines="1000"
18 android:padding="10dp"
19- android:maxLines = "1000"
20- android:scrollbars = "vertical"
21+ android:scrollbars="vertical"
22 android:text=""
23 android:textColor="@color/terminaltext"
24 u1f:customFont="Ubuntu-R.ttf" />
25
26=== modified file 'res/values/strings.xml'
27--- res/values/strings.xml 2013-12-19 05:43:04 +0000
28+++ res/values/strings.xml 2013-12-19 09:42:54 +0000
29@@ -1,7 +1,7 @@
30 <?xml version="1.0" encoding="utf-8"?>
31 <resources>
32
33- <string name="app_name">UbuntuInstaller</string>
34+ <string name="app_name">Ubuntu Dual Boot</string>
35 <string name="action_settings">Settings</string>
36 <string name="action_detele_download">Delete download</string>
37 <string name="action_install">Install</string>
38
39=== modified file 'src/com/canonical/ubuntu/installer/InstallActivity.java'
40--- src/com/canonical/ubuntu/installer/InstallActivity.java 2013-12-19 05:43:04 +0000
41+++ src/com/canonical/ubuntu/installer/InstallActivity.java 2013-12-19 09:42:54 +0000
42@@ -132,8 +132,9 @@
43 private void checkIfUbuntuIsInstalled() {
44 // check is there is Ubuntu installed
45 if (UbuntuInstallService.isUbuntuInstalled(this.getApplicationContext())) {
46- // go to launch screen
47+ // go to launch screen, and kill this activity.
48 LaunchActivity.startFrom(this);
49+ finish();
50 }
51 }
52
53@@ -364,7 +365,9 @@
54 Utils.showToast(context, "Install completed");
55 mProgressBar.setProgress(100);
56 deleteDownload();
57+ // go to launch screen, and kill this activity.
58 LaunchActivity.startFrom(context);
59+ finish();
60 } else {
61 Utils.showToast(context, "Installation failed:");
62 String reason = intent.getStringExtra(UbuntuInstallService.INSTALL_RESULT_EXTRA_STR);
63
64=== modified file 'src/com/canonical/ubuntu/installer/LaunchActivity.java'
65--- src/com/canonical/ubuntu/installer/LaunchActivity.java 2013-12-19 05:43:04 +0000
66+++ src/com/canonical/ubuntu/installer/LaunchActivity.java 2013-12-19 09:42:54 +0000
67@@ -155,8 +155,9 @@
68 private void ensureUbuntuIsInstalled() {
69 VersionInfo v = UbuntuInstallService.getInstalledVersion(this.getApplicationContext());
70 if (v == null) {
71- // go back to install screen
72+ // go back to install screen, and release myself.
73 InstallActivity.startFrom(this);
74+ finish();
75 } else {
76 mUbuntuVersion = v;
77 }

Subscribers

People subscribed via source and target branches

to all changes: