Merge lp:~humpolec-team/humpolec/UbuntuInstaller-check-storage-size into lp:humpolec

[Yuan-Chen Cheng]

check storage size before download

[lp:~humpolec-team/humpolec/UbuntuInstaller-check-storage-size]

16. By Yuan-Chen Cheng on 2013-12-16

revert format change by ecipse

[Rex Tsai (chihchun)]

* UbuntuInstallService.java line 11: s/save/safe/
* line 119: s/eought/enough/
* long getAvailableBlocksLong is available at API 18, our minimum support is API 17. If we are move to API 18, maybe we should use getAvailableBytes ()[1].

[1] http://developer.android.com/reference/android/os/StatFs.html#getAvailableBytes%28%29

review: Needs Fixing

[lp:~humpolec-team/humpolec/UbuntuInstaller-check-storage-size]

17. By Yuan-Chen Cheng on 2013-12-16

typo fix and use api 17

[Yuan-Chen Cheng (ycheng-twn)]

fix accordingly

review: Needs Resubmitting

[Rex Tsai (chihchun)]

Looks good.

review: Approve

=== modified file 'src/com/canonical/ubuntu/installer/UbuntuInstallService.java'
--- src/com/canonical/ubuntu/installer/UbuntuInstallService.java	2013-12-13 16:57:41 +0000
+++ src/com/canonical/ubuntu/installer/UbuntuInstallService.java	2013-12-16 09:10:46 +0000
@@ -108,6 +108,12 @@
     private static final String URL_IMAGE_MASTER = "gpg/image-master.tar.xz";
     private static final String URL_IMAGE_SIGNING = "gpg/image-signing.tar.xz";
     private static final String ASC_SUFFIX = ".asc";
+
+    // 2G for file system, 512M for swap.
+    private static long INSTALL_SIZE_REQUIRED = (2048L + 512L) * 1024L * 1024L;
+    // 15M extra space to keep it safe.
+    private static long EXTRA_SIZE_REQUIRED = 15 * 1024 * 1024;
+
     
     // =================================================================================================
     // Packed assets
@@ -144,6 +150,7 @@
     private static final int PROGRESS_MKSWAP_ADJUSTMENT = 17; // equivalent of time tar --checkpoint=200
     private PowerManager mPowerManager;
     private PowerManager.WakeLock mWakeLock;
+    private boolean workPathInCache = false;
     private String mRootOfWorkPath;
     private boolean mIsCanceled;
     
@@ -172,8 +179,10 @@
         if (testDir.mkdir()) {
             testDir.delete();
             mRootOfWorkPath = "/cache";
+            workPathInCache = true;
         } else {
             mRootOfWorkPath = getFilesDir().toString(); //  "/data/data/com.canonical.ubuntuinstaller/files";
+            workPathInCache = false;
         }
     }
 
@@ -591,23 +600,23 @@
             // get right version, otherwise first since that is most recent one
             Image choosenRelease = null;
             if (version != -1) {
-            // look for given release
-            for (Image i : releases) {
-            if (i.version == version) {
-            choosenRelease = i;
-            break;
-            }
-            }
-            if (choosenRelease == null) {
+                // look for given release
+                for (Image i : releases) {
+                    if (i.version == version) {
+                        choosenRelease = i;
+                        break;
+                    }
+                }
+                if (choosenRelease == null) {
                     Log.e(TAG, "wrong release vwersion");
                     result.putExtra(DOWNLOAD_RESULT_EXTRA_INT, -1);
                     result.putExtra(DOWNLOAD_RESULT_EXTRA_STR, "wrong release vwersion");
-                    return result;            
-            }
+                    return result;
+                }
             } else {
-            choosenRelease = releases.get(0);
+                choosenRelease = releases.get(0);
             }
-            JsonChannelParser.File updateFiles[] = choosenRelease.files;           
+            JsonChannelParser.File updateFiles[] = choosenRelease.files;
             // sort update files
             List<JsonChannelParser.File> filesArray = new LinkedList<JsonChannelParser.File>();
             for(JsonChannelParser.File f: updateFiles) {
@@ -619,7 +628,7 @@
             // get list of keyrings to download
             String keyrings[] = {
                     String.format("%s/%s",BASE_URL, URL_IMAGE_MASTER),
-                    String.format("%s/%s",BASE_URL, URL_IMAGE_SIGNING),                    
+                    String.format("%s/%s",BASE_URL, URL_IMAGE_SIGNING),
             };            
             String keyringsFilenames[] = new String[keyrings.length * 2];
                               
@@ -640,6 +649,22 @@
             mProgress = 0;
             broadcastProgress(mLastSignalledProgress, null);
             mTotalSize = Utils.calculateDownloadSize(filesArray);
+
+            boolean isStorageEnough = isStorageSpaceEnoughtBFDownload(mTotalSize);
+            if (! isStorageEnough) {
+                String msg = "Need more storage: ";
+                if (workPathInCache) {
+                    msg += "/cache need " + String.valueOf(mTotalSize) + " bytes for download and /data need 2.5G for system";
+                } else {
+                    msg += "/data need 2.5G for system plus " + String.valueOf(mTotalSize) + " bytes for download";
+                }
+                Log.i(TAG, msg);
+
+                result.putExtra(DOWNLOAD_RESULT_EXTRA_INT, -1);
+                result.putExtra(DOWNLOAD_RESULT_EXTRA_STR, msg);
+                return result;
+            }
+
             // mProgressSteps = mTotalDownloadSize / 100; // we want 1% steps
             try {
                 int i = 0;
@@ -648,7 +673,7 @@
                     // download signature
                     keyringsFilenames[i++] = doDownloadUrl(new URL(url+ASC_SUFFIX),release);
                 }
-                
+
                 // download all update images
                 i = 0;
                 for (JsonChannelParser.File file : filesArray){
@@ -837,4 +862,31 @@
         }
         sendBroadcast(i);
     }
+    
+    /**
+     * Check whether storage free space is enough.
+     * @param downloadSize: download size from json. 0 means file already downloaded.
+     * @return true if stoarge size is ok to go.
+     */
+    private boolean isStorageSpaceEnoughtBFDownload(long downloadSize) {
+        long dataSizeRequired = INSTALL_SIZE_REQUIRED;
+
+        if (workPathInCache) {
+            if (downloadSize > 0) {
+                long cacheFreeSpace = Utils.getFreeSpaceInBytes("/cache");
+                if (cacheFreeSpace < EXTRA_SIZE_REQUIRED + downloadSize) {
+                    return false;
+                }
+            }
+        } else {
+            dataSizeRequired += downloadSize;
+        }
+
+        long dataFreeSpace = Utils.getFreeSpaceInBytes("/data");
+        if (dataFreeSpace < EXTRA_SIZE_REQUIRED + dataSizeRequired) {
+            return false;
+        }
+        return true;
+    }
+
 }

=== modified file 'src/com/canonical/ubuntu/installer/Utils.java'
--- src/com/canonical/ubuntu/installer/Utils.java	2013-12-13 01:06:14 +0000
+++ src/com/canonical/ubuntu/installer/Utils.java	2013-12-16 09:10:46 +0000
@@ -21,6 +21,7 @@
 
 import android.content.Context;
 import android.content.res.AssetManager;
+import android.os.StatFs;
 import android.util.Log;
 import android.widget.Toast;
 
@@ -177,4 +178,15 @@
     	}
     	return size;
     }
+
+    @SuppressWarnings("deprecation")
+    public static long getFreeSpaceInBytes(String fsPath) {
+        StatFs stats = new StatFs(fsPath);
+        // not using getAvailableBytes() for it's not available in android 4.2
+        int availableBlocks = stats.getAvailableBlocks();
+        int blockSizeInBytes = stats.getBlockSize();
+        long freeSpaceInBytes = ((long)availableBlocks) * ((long)blockSizeInBytes);
+        return freeSpaceInBytes;
+    }
+
 }