Merge ~hui.wang/pulseaudio/+git/pulseaudio:ubuntu-xenial into ~ubuntu-audio-dev/pulseaudio:ubuntu-xenial

Proposed by Hui Wang
Status: Needs review
Proposed branch: ~hui.wang/pulseaudio/+git/pulseaudio:ubuntu-xenial
Merge into: ~ubuntu-audio-dev/pulseaudio:ubuntu-xenial
Diff against target: 57 lines (+35/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/0803-build-sys-add-the-Dell-dock-TB16-configuration.patch (+27/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Resubmitting
Review via email: mp+334346@code.launchpad.net

Description of the change

This merge request will work together with my previous merge request (Cherrypick one upstream commit to support audio on the Dell Dock TB16) to fix the bug #1718824.

The previous merge request has been merged to ubuntu-xenial branch, and the conf file has been added to the source repository, but it forgot to add the conf file to build sys, as a result the conf file will not be installed to target dir (/usr/share/pulseaudio/alsa-mixer/profile-sets).

This new merge request just backporting a very simple patch to add the conf file to build sys, it will not introduce any regression. And this simple patch was already merged to pulseaudio upstream.

For artful, we also need to add a similar patch. but there are 3 branches in git://git.launchpad.net/~ubuntu-audio-dev/pulseaudio (ubuntu, ubuntu-artful and ubuntu-pulse11-wip), I don't know which branch should I send the merge request to, could you please tell me.

thx.
Hui.

To post a comment you must log in.
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Sorry for the delay, I was on vacation.

It appears during that time someone made a little mess of the pulseaudio packages in ubuntu-xenial. I've fixed that up now, but you'll need to merge my changes from git branch ubuntu-xenial and then resubmit this proposal for ubuntu-xenial.

P.S. The branch for artful is 'ubuntu-artful'.

review: Needs Resubmitting
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Please also mention "LP: #1718824" in your commit message when resubmitting.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

P.P.S. You are a member of ~ubuntu-audio-dev so don't need to do merge proposals. You can commit directly to the launchpad branch. :)

Revision history for this message
Hui Wang (hui.wang) wrote :

Got it, thank you.

Unmerged commits

df2f3ed... by Hui Wang

Backport one upstream commit to add the conf file of TB16 to build sys

The commit number is 2f1dcea3 of pulseaudio upstream.

Otherwise the conf file will not be installed to:
/usr/share/pulseaudio/alsa-mixer/profile-sets/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 6083bb3..3864631 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+pulseaudio (1:8.0-0ubuntu3.6) UNRELEASED; urgency=medium
7+
8+ * Backport the fix to add the conf file to build-sys
9+ - 2f1dcea3: add the Dell dock TB16 configuration to build-sys (LP: #1718824)
10+
11+ -- Hui Wang <hui.wang@canonical.com> Tue, 28 Nov 2017 08:39:27 +0800
12+
13 pulseaudio (1:8.0-0ubuntu3.5) UNRELEASED; urgency=medium
14
15 * Cherrypick fixes for supporting audio on Dell dock TB16:
16diff --git a/debian/patches/0803-build-sys-add-the-Dell-dock-TB16-configuration.patch b/debian/patches/0803-build-sys-add-the-Dell-dock-TB16-configuration.patch
17new file mode 100644
18index 0000000..2675a9f
19--- /dev/null
20+++ b/debian/patches/0803-build-sys-add-the-Dell-dock-TB16-configuration.patch
21@@ -0,0 +1,27 @@
22+From 6bdf74c27d92828f71f7343158460393ba260541 Mon Sep 17 00:00:00 2001
23+From: Hui Wang <hui.wang@canonical.com>
24+Date: Thu, 23 Nov 2017 08:47:26 +0800
25+Subject: [PATCH] build-sys: add the Dell dock TB16 configuration
26+
27+Signed-off-by: Hui Wang <hui.wang@canonical.com>
28+---
29+ src/Makefile.am | 3 ++-
30+ 1 file changed, 2 insertions(+), 1 deletion(-)
31+
32+diff --git a/src/Makefile.am b/src/Makefile.am
33+index b0ca2bc..7a2d361 100644
34+--- a/src/Makefile.am
35++++ b/src/Makefile.am
36+@@ -1285,7 +1285,8 @@ dist_alsaprofilesets_DATA = \
37+ modules/alsa/mixer/profile-sets/native-instruments-traktorkontrol-s4.conf \
38+ modules/alsa/mixer/profile-sets/native-instruments-korecontroller.conf \
39+ modules/alsa/mixer/profile-sets/kinect-audio.conf \
40+- modules/alsa/mixer/profile-sets/sb-omni-surround-5.1.conf
41++ modules/alsa/mixer/profile-sets/sb-omni-surround-5.1.conf \
42++ modules/alsa/mixer/profile-sets/dell-dock-tb16-usb-audio.conf
43+
44+ if HAVE_UDEV
45+ dist_udevrules_DATA = \
46+--
47+2.7.4
48+
49diff --git a/debian/patches/series b/debian/patches/series
50index a36df8b..d7ae0e8 100644
51--- a/debian/patches/series
52+++ b/debian/patches/series
53@@ -60,3 +60,4 @@
54
55 # Adding analogue audio on the Dell usb Dock TB16
56 0802-alsa-mixer-Add-support-for-usb-audio-in-the-Dell-doc.patch
57+0803-build-sys-add-the-Dell-dock-TB16-configuration.patch

Subscribers

People subscribed via source and target branches