Merge lp:~hugosantosred/ocb-addons/6.1-lp1015717 into lp:ocb-addons/6.1
Proposed by
Hugo Santos (Factorlibre)
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Stefan Rijnhart (Opener) | ||||
Proposed branch: | lp:~hugosantosred/ocb-addons/6.1-lp1015717 | ||||
Merge into: | lp:ocb-addons/6.1 | ||||
Diff against target: |
28 lines (+18/-0) 1 file modified
stock/stock.py (+18/-0) |
||||
To merge this branch: | bzr merge lp:~hugosantosred/ocb-addons/6.1-lp1015717 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Numérigraphe (community) | Disapprove | ||
Stefan Rijnhart (Opener) | Needs Fixing | ||
Nhomar - Vauxoo | Disapprove | ||
Review via email:
|
Description of the change
Improvement in code for bug lp:1015717.
Now check availability button in stock picking checks if is there any qty of product in the location and splits move in two lines. One with assigned state and one waiting availability.
To post a comment you must log in.
Unmerged revisions
- 6732. By Hugo Santos (Factorlibre)
-
[IMP] Add context to write and copy
- 6731. By Hugo Santos (Factorlibre)
-
lp:1015717 Now checks picking move type before splitting moves
- 6730. By Hugo Santos (Factorlibre)
-
[IMP] Split waiting for availability lines in picking one with units available and one with the units left
Hello.
My comments in the bug.
https:/ /bugs.launchpad .net/openobject -server/ +bug/996816
IMHO this is not an aceptable patch, because it change totally the flow of work in the picking in the stable version.
This should be done in a simple extra module here:
https:/ /code.launchpad .net/~stock- logistic- core-editors/ stock-logistic- flows/7. 0
and
https:/ /code.launchpad .net/~stock- logistic- core-editors/ stock-logistic- flows/6. 1
Functionally speaking what you did in this approach is a "PoV" of how this problem must be solved, not a generic a clear approach, but again it is just my opinion sorry dudes.
Regards.