Merge lp:~htorque/indicator-application/fix-small-memleak into lp:indicator-application/0.5

[Hernando Torque]

Inline use of dbus_g_method_get_sender causes a small memory leak. This patch frees the string returned by it.

[Charles Kerr (charlesk)]

Hi Hernando,

Thanks for the patch, looks good.

I've filed bug #953585 (and gave you credit there), and linked this merge request to it.

review: Approve

[Hernando Torque (htorque)]

Thanks!

=== modified file 'src/application-service-watcher.c'
--- src/application-service-watcher.c	2010-10-08 16:04:27 +0000
+++ src/application-service-watcher.c	2012-03-12 22:00:25 +0000
@@ -249,9 +249,11 @@
 	ApplicationServiceWatcherPrivate * priv = APPLICATION_SERVICE_WATCHER_GET_PRIVATE(appwatcher);
 
 	if (service[0] == '/') {
+		char * sender = dbus_g_method_get_sender(method);
 		application_service_appstore_application_add(priv->appstore,
-		                                             dbus_g_method_get_sender(method),
+		                                             sender,
 		                                             service);
+		g_free(sender);
 	} else {
 		application_service_appstore_application_add(priv->appstore,
 		                                             service,
@@ -293,9 +295,11 @@
 {
 	ApplicationServiceWatcherPrivate * priv = APPLICATION_SERVICE_WATCHER_GET_PRIVATE(appwatcher);
 
+	char * sender = dbus_g_method_get_sender(method);
 	application_service_appstore_approver_add(priv->appstore,
-	                                          dbus_g_method_get_sender(method),
+	                                          sender,
 	                                          path);
+	g_free(sender);
 
 	dbus_g_method_return(method, G_TYPE_NONE);
 	return TRUE;