Merge lp:~hsoft/server-env-tools/mass_editing_7.0 into lp:~serpentcs/server-env-tools/mass_editing_7.0

[Virgil Dupras]

I began tackling Stephan's list of issues, starting with the first one (using a m2m field instead of a serialized ID list).

[Serpent Consulting Services (serpent-consulting-services)]

Good one!

[Nhomar - Vauxoo (nhomar)]

I am merging to trunk!.

Due to i merged serpent branch, i tested and it is working excenlent.

review: Approve

[Holger Brunn (Therp) (hbrunn)]

review: Approve (code review)

[Stefan Rijnhart (Opener) (stefan-opener)]

Looks like this has been merged in rev. 38 of lp:server-env-tools/7.0. Don't know why Launchpad did not pick it up.

[Stefan Rijnhart (Opener) (stefan-opener)]

Ah, I see. The series branch was not the target of this MP. Serpent or Virgil, can you please set this MP to merged?

=== modified file 'mass_editing/mass_editing.py'
--- mass_editing/mass_editing.py	2013-05-07 13:36:37 +0000
+++ mass_editing/mass_editing.py	2013-05-08 12:44:28 +0000
@@ -50,7 +50,7 @@
                                                  of the related document model"),
         'ref_ir_value':fields.many2one('ir.values', 'Sidebar Button', readonly=True,
                                        help="Sidebar button to open the sidebar action"),
-        'model_list': fields.char('Model List', size=256)
+        'model_ids': fields.many2many('ir.model', string='Model List')
     }
 
     _sql_constraints = [
@@ -60,15 +60,15 @@
     def onchange_model(self, cr, uid, ids, model_id, context=None):
         if context is None: context = {}
         if not model_id:
-            return {'value': {'model_list': ''}}
-        model_list = [model_id]
+            return {'value': {'model_ids': [(6, 0, [])]}}
+        model_ids = [model_id]
         model_obj = self.pool.get('ir.model')
         active_model_obj = self.pool.get(model_obj.browse(cr, uid, model_id).model)
         if active_model_obj._inherits:
             for key, val in active_model_obj._inherits.items():
-                model_ids = model_obj.search(cr, uid, [('model', '=', key)], context=context)
-                model_list += model_ids
-        return {'value': {'model_list': str(model_list)}}
+                found_model_ids = model_obj.search(cr, uid, [('model', '=', key)], context=context)
+                model_ids += found_model_ids
+        return {'value': {'model_ids': [(6, 0, model_ids)]}}
 
     def create_action(self, cr, uid, ids, context=None):
         vals = {}

=== modified file 'mass_editing/mass_editing_view.xml'
--- mass_editing/mass_editing_view.xml	2013-02-14 20:31:22 +0000
+++ mass_editing/mass_editing_view.xml	2013-05-08 12:44:28 +0000
@@ -10,11 +10,11 @@
                 <form string="Object">
                     <field name="name"/>
                     <field name="model_id" on_change="onchange_model(model_id)"/>
-                    <field name="model_list" invisible="1"/>
+                    <field name="model_ids" invisible="1"/>
                     <notebook colspan="4">
                         <page string="Fields">
                             <field name="field_ids" colspan="4" nolabel="1"
-                                domain="[('ttype', 'not in', ['one2many', 'reference', 'function']), ('model_id', 'in', model_list)]"/>
+                                domain="[('ttype', 'not in', ['one2many', 'reference', 'function']), ('model_id', 'in', model_ids[0][2])]"/>
                         </page>
                         <page string="Advanced">
                             <group colspan="2" col="2">