Merge ~hsbasu/ubuntu/+source/update-manager:fix-download-page into ubuntu/+source/update-manager:ubuntu/devel

[Himadri Sekhar Basu]

Fix scroll window on update downloading page

- Currently the download progress box does not
  expand vertically when in fullscreen, however
  the expansion in vertical direction with
  increasing window height is the proper
  behaviour. This fix provides this desired
  behaviour.
- Fixes LP: #1772486, LP: #1856404

Fixes LP: #1772486, LP: #1856404

[Erich Eickmeyer (eeickmeyer)]

Looks great, approved from a community standpoint.

review: Approve

[Nathan Teodosio (nteodosio)]

Thanks for your merge request, but you targeted https://launchpad.net/~git-ubuntu-import:

> It's important that only the git-ubuntu importer service pushes to these repositories. They are supposed to be a precise reflection of Launchpad publication history of Ubuntu, and developers should be able to rely on this. If users push to these repositories directly, this promise will get broken.

Can you please target https://code.launchpad.net/~ubuntu-core-dev/update-manager/+git/update-manager/+ref/main instead?

Do you know where this download_scrolled is coming from? I cannot find where it's defined. (But if it works, it works, not a blocking question.)

--->
% grep -ri download.scrolled
UpdateManager/backend/InstallBackendAptdaemon.py: self.download_scrolled.show()
UpdateManager/backend/InstallBackendAptdaemon.py: self.download_scrolled.hide()
UpdateManager/backend/InstallBackendAptdaemon.py: self.download_scrolled.hide()
<---

review: Needs Resubmitting

[Himadri Sekhar Basu (hsbasu)]

Hi! Nathan. Thanks for the guidance. I'll resubmit the MR.

Please check https://imgur.com/a/4EQPd4M. download_scrolled is actually a Gtk.ScrolledWindow() defined in the package python3-aptdaemon.gtk3widgets.

[Himadri Sekhar Basu (hsbasu)]

Hi! Created a new MR https://code.launchpad.net/~hsbasu/update-manager/+git/update-manager/+merge/465575

Unmerged commits

9cac4c9... by Himadri Sekhar Basu on 2024-04-23

Fix scroll window on update downloading page

- Currently the download progress box does not
  expand vertically when in fullscreen, however
  the expansion in vertical direction with
  increasing window height is the proper
  behaviour. This fix provides this desired
  behaviour.
- Fixes LP: #1772486, LP: #1856404

diff --git a/UpdateManager/backend/InstallBackendAptdaemon.py b/UpdateManager/backend/InstallBackendAptdaemon.py
index 2959aa6..aced9bf 100644
--- a/UpdateManager/backend/InstallBackendAptdaemon.py
+++ b/UpdateManager/backend/InstallBackendAptdaemon.py
@@ -52,6 +52,7 @@ class UpdateManagerExpander(AptDetailsExpander):
         if status in (STATUS_DOWNLOADING, STATUS_DOWNLOADING_REPO):
             self.set_sensitive(True)
             self.download_scrolled.show()
+            self.download_scrolled.set_vexpand(True)
             if self.terminal:
                 self.terminal.hide()
         elif status == STATUS_COMMITTING: