Code review comment for lp:~hrvojem/percona-xtrabackup/prlcmpr-2.0

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hrvoje,

> + * |xtrabackup| was using MySQL's datadir as it's target-dir. Target directory is now a required option. Bug fixed :bug:`489290` (*Sergei Glushchenko*).

No, that bug was fixed in a different way. Target directory now defaults to the current directory, rather than MySQL's datadir.

> + * |xtrabackup| function didn't work with parallel backups. Bug fixed: :bug:`826632` (*Alexey Kopytov*).

You meant to say incremental backups didn't work with the --parallel option?

Otherwise the MP looks good.

review: Needs Fixing

« Back to merge proposal