The change itself looks good, but I suggest to merge multiple revisions into a single one before creating a MP, so we don't pollute our revision history with revisions like "added X", "added X fixed", "added X fixed again", etc.
If you just want to fix a previous commit, you can do "bzr uncommit" (that will revert the committed status of the last revision, but leave the changes intact), do necessary fixes, and then commit again.
If you have already pushed your previous changes to a remote branch, you can use the --overwrite option to replace that branch (and thus, wrong revision) with your local one, e.g.
You can also collapse multiple revisions into a single one by using the -r option in "bzr uncommit", or just running "bzr uncommit" repeatedly, until the original revision is uncommited.
The change itself looks good, but I suggest to merge multiple revisions into a single one before creating a MP, so we don't pollute our revision history with revisions like "added X", "added X fixed", "added X fixed again", etc.
If you just want to fix a previous commit, you can do "bzr uncommit" (that will revert the committed status of the last revision, but leave the changes intact), do necessary fixes, and then commit again.
If you have already pushed your previous changes to a remote branch, you can use the --overwrite option to replace that branch (and thus, wrong revision) with your local one, e.g.
bzr push --overwrite lp:~hrvojem/percona-xtrabackup/mngtools
You can also collapse multiple revisions into a single one by using the -r option in "bzr uncommit", or just running "bzr uncommit" repeatedly, until the original revision is uncommited.