Merge lp:~hrvojem/percona-xtrabackup/bug972185 into lp:percona-xtrabackup/2.0

Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 412
Proposed branch: lp:~hrvojem/percona-xtrabackup/bug972185
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 25 lines (+1/-3)
2 files modified
doc/source/innobackupex/innobackupex_option_reference.rst (+1/-1)
doc/source/innobackupex/streaming_backups_innobackupex.rst (+0/-2)
To merge this branch: bzr merge lp:~hrvojem/percona-xtrabackup/bug972185
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+100594@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hrvoje,

There is another mention of the limitation in 2.0 docs:

"
If both :option:`--stream` and :option:`--incremental` are passed to innobackupex, the incremental parameters are ignored and a full backup is created.
"

see https://code.launchpad.net/~hrvojem/percona-xtrabackup/bug924313/+merge/92772

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Just noticed that "the only currently supported format is 'tar'" on the same line is also wrong for 2.0.

But that's probably should be fixed separately, when documenting the xbstream format?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/innobackupex/innobackupex_option_reference.rst'
2--- doc/source/innobackupex/innobackupex_option_reference.rst 2012-02-14 08:31:46 +0000
3+++ doc/source/innobackupex/innobackupex_option_reference.rst 2012-04-03 13:23:30 +0000
4@@ -121,7 +121,7 @@
5
6 .. option:: --stream
7
8- This option accepts a string argument that specifies the format in which to do the streamed backup. The backup will be done to ``STDOUT`` in the specified format. Currently, the only supported format is :command:`tar`. Uses :doc:`tar4ibd <../tar4ibd/tar4ibd_binary>`, which is available in *XtraBackup* distributions. If you specify a path after this option, it will be interpreted as the value of :option:`tmpdir`. If both :option:`--stream` and :option:`--incremental` are passed to innobackupex, the incremental parameters are ignored and a full backup is created.
9+ This option accepts a string argument that specifies the format in which to do the streamed backup. The backup will be done to ``STDOUT`` in the specified format. Currently, the only supported format is :command:`tar`. Uses :doc:`tar4ibd <../tar4ibd/tar4ibd_binary>`, which is available in *XtraBackup* distributions. If you specify a path after this option, it will be interpreted as the value of :option:`tmpdir`.
10
11 .. option:: --tmpdir
12
13
14=== modified file 'doc/source/innobackupex/streaming_backups_innobackupex.rst'
15--- doc/source/innobackupex/streaming_backups_innobackupex.rst 2012-02-14 08:31:46 +0000
16+++ doc/source/innobackupex/streaming_backups_innobackupex.rst 2012-04-03 13:23:30 +0000
17@@ -6,8 +6,6 @@
18
19 This allows to pipe the stream to other programs, providing great flexibility to the output of it. For example, compression is achieved by piping the output to a compression utility.
20
21-.. warning:: If both --stream and --incremental are passed to innobackupex, the incremental parameters are ignored and a full backup is created.
22-
23 To use this feature, you must use the :option:`--stream`, providing the format of the stream (only ``tar`` is supported at this moment) and where should the store the temporary files::
24
25 $ innobackupex --stream=tar /tmp

Subscribers

People subscribed via source and target branches