Merge lp:~hrvojem/percona-xtrabackup/bug939075 into lp:percona-xtrabackup/2.0

Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 426
Proposed branch: lp:~hrvojem/percona-xtrabackup/bug939075
Merge into: lp:percona-xtrabackup/2.0
Diff against target: 87 lines (+3/-22)
4 files modified
doc/source/howtos/recipes_ibkx_inc.rst (+1/-1)
doc/source/innobackupex/innobackupex_option_reference.rst (+0/-4)
doc/source/installation/compiling_xtrabackup.rst (+1/-10)
innobackupex (+1/-7)
To merge this branch: bzr merge lp:~hrvojem/percona-xtrabackup/bug939075
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+105037@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Hrvoje,

- along with removign docs for --force-tar, it would make sense to also remove the option itself from innobackupex.

- "The |xtrabackup| binary will _be_ located..."

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/howtos/recipes_ibkx_inc.rst'
2--- doc/source/howtos/recipes_ibkx_inc.rst 2012-02-02 20:21:43 +0000
3+++ doc/source/howtos/recipes_ibkx_inc.rst 2012-05-15 09:39:51 +0000
4@@ -30,7 +30,7 @@
5
6 Now apply the incremental backup to the base backup, by issuing: ::
7
8- innobackupex --apply-log $FULLBACKUP
9+ innobackupex --apply-log --redo-only $FULLBACKUP
10 --incremental-dir=$INCREMENTALBACKUP
11 --use-memory=1G --user=DVADER --password=D4RKS1D3
12
13
14=== modified file 'doc/source/innobackupex/innobackupex_option_reference.rst'
15--- doc/source/innobackupex/innobackupex_option_reference.rst 2012-04-21 07:12:28 +0000
16+++ doc/source/innobackupex/innobackupex_option_reference.rst 2012-05-15 09:39:51 +0000
17@@ -127,10 +127,6 @@
18
19 This option accepts a string argument that specifies the location where a temporary file will be stored. It should be used when :option:`--remote-host` or :option:`--stream` is specified. For these options, the transaction log will first be stored to a temporary file, before streaming or copying to a remote host. This option specifies the location where that temporary file will be stored. If the option is not specifed, the default is to use the value of ``tmpdir`` read from the server configuration.
20
21-.. option:: --force-tar
22-
23- This option forces the use of :command:`tar` when creating a streamed backup, rather than :program:`tar4ibd`, which is the default.
24-
25 .. option:: --scpopt = '-Cp -c arcfour'
26
27 This option accepts a string argument that specifies the command line options to pass to :command:`scp` when the option :option:`--remost-host` is specified. If the option is not specified, the default options are ``-Cp -c arcfour``.
28
29=== modified file 'doc/source/installation/compiling_xtrabackup.rst'
30--- doc/source/installation/compiling_xtrabackup.rst 2011-07-12 04:19:38 +0000
31+++ doc/source/installation/compiling_xtrabackup.rst 2012-05-15 09:39:51 +0000
32@@ -54,14 +54,5 @@
33
34 $ AUTO_DOWNLOAD="yes" ./utils/build.sh xtradb
35
36-and you go for a coffee, at your return |XtraBackup| will be ready to be used. The |xtrabackup| binary will located in the following subdirectory depending on the building target:
37+and you go for a coffee, at your return |XtraBackup| will be ready to be used. The |xtrabackup| binary will be located in the ``percona-xtrabackup/src`` subdirectory.
38
39- ================== =====================================================
40- Target Location
41- ================== =====================================================
42- innodb51_builtin mysql-5.1/storage/innobase/xtrabackup
43- innodb51 mysql-5.1/storage/innodb_plugin/xtrabackup
44- innodb55 mysql-5.5/storage/innobase/xtrabackup
45- xtradb51 Percona-Server-5.1/storage/innodb_plugin/xtrabackup
46- xtradb55 Percona-Server-5.5/storage/innobase/xtrabackup
47- ================== =====================================================
48
49=== modified file 'innobackupex'
50--- innobackupex 2012-04-30 04:27:01 +0000
51+++ innobackupex 2012-05-15 09:39:51 +0000
52@@ -103,7 +103,6 @@
53 my $option_tmpdir = '';
54
55 my $option_tar4ibd = '';
56-my $option_force_tar = '';
57 my $option_scp_opt = '-Cp -c arcfour';
58 my $option_ssh_opt = '';
59
60@@ -1757,7 +1756,6 @@
61 'ibbackup=s' => \$option_ibbackup_binary,
62 'scpopt=s' => \$option_scp_opt,
63 'sshopt=s' => \$option_ssh_opt,
64- 'force-tar', => \$option_force_tar,
65 'parallel=i' => \$option_parallel,
66 'safe-slave-backup' => \$option_safe_slave_backup,
67 'safe-slave-backup-timeout' => $option_safe_slave_backup_timeout,
68@@ -2628,7 +2626,7 @@
69 [--include=REGEXP] [--user=NAME]
70 [--password=WORD] [--port=PORT] [--socket=SOCKET]
71 [--no-timestamp] [--ibbackup=IBBACKUP-BINARY]
72- [--slave-info] [--stream=tar|xbstream] [--force-tar]
73+ [--slave-info] [--stream=tar|xbstream]
74 [--scpopt=OPTIONS-FOR-SCP] [--sshopt=OPTIONS-FOR-SSH]
75 [--defaults-file=MY.CNF]
76 [--databases=LIST] [--remote-host=HOSTNAME] [--no-lock]
77@@ -2716,10 +2714,6 @@
78
79 This option specifies the directory in which to save an extra copy of the "xtrabackup_checkpoints" file. The option accepts a string argument. It is passed directly to xtrabackup's --extra-lsndir option. See the xtrabackup documentation for details.
80
81-=item --force-tar
82-
83-This option forces the use of tar when creating a streamed backup, rather than tar4ibd, which is the default.
84-
85 =item --help
86
87 This option displays a help screen and exits.

Subscribers

People subscribed via source and target branches