Merge lp:~hrvojem/percona-xtrabackup/bug924313 into lp:percona-xtrabackup/2.0
Proposed by
Hrvoje Matijakovic
Status: | Merged |
---|---|
Approved by: | Alexey Kopytov |
Approved revision: | no longer in the source branch. |
Merged at revision: | 391 |
Proposed branch: | lp:~hrvojem/percona-xtrabackup/bug924313 |
Merge into: | lp:percona-xtrabackup/2.0 |
Diff against target: |
82 lines (+8/-6) 5 files modified
doc/source/conf.py (+1/-1) doc/source/innobackupex/how_innobackupex_works.rst (+1/-1) doc/source/innobackupex/innobackupex_option_reference.rst (+3/-3) doc/source/innobackupex/streaming_backups_innobackupex.rst (+2/-0) src/xtrabackup.c (+1/-1) |
To merge this branch: | bzr merge lp:~hrvojem/percona-xtrabackup/bug924313 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+92772@code.launchpad.net |
To post a comment you must log in.
Looks good, except that the request in bug #924313 was that we make it clear from our documentation that we don't currently support streaming incremental backups. That is, --incremental, --incremental- basedir and --incremental-lsn are ignored when --stream is specified on the innobackupex command line.
I suggest we mention that in the corresponding options descriptions in http:// www.percona. com/doc/ percona- xtrabackup/ innobackupex/ innobackupex_ option_ reference. html and in http:// www.percona. com/doc/ percona- xtrabackup/ innobackupex/ streaming_ backups_ innobackupex. html
Please also not that we are going to fix this in 1.9.1. And that's the first case when the manual will get out of sync with 1.6. I'm not sure what to do about that. We can either create a separate 1.6 manual, or just ignore it and say that the online XtraBackup docs describe only 2.0.