Merge lp:~hrvojem/percona-xtrabackup/bug1295444-2.2 into lp:percona-xtrabackup/2.2

Proposed by Hrvoje Matijakovic on 2014-12-18
Status: Merged
Approved by: Alexey Kopytov on 2015-01-13
Approved revision: 5060
Merged at revision: 5060
Proposed branch: lp:~hrvojem/percona-xtrabackup/bug1295444-2.2
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 41 lines (+13/-5)
2 files modified
storage/innobase/xtrabackup/doc/source/innobackupex/improved_ftwrl.rst (+1/-1)
storage/innobase/xtrabackup/doc/source/innobackupex/privileges.rst (+12/-4)
To merge this branch: bzr merge lp:~hrvojem/percona-xtrabackup/bug1295444-2.2
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) 2014-12-18 Approve on 2015-01-13
Review via email: mp+245110@code.launchpad.net
To post a comment you must log in.
Alexey Kopytov (akopytov) wrote :
review: Needs Information
Hrvoje Matijakovic (hrvojem) wrote :

> Should we merge (or link to) http://www.percona.com/doc/percona-
> xtrabackup/2.2/innobackupex/storing_history.html#privileges?

I'll merge these as well

Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'storage/innobase/xtrabackup/doc/source/innobackupex/improved_ftwrl.rst'
2--- storage/innobase/xtrabackup/doc/source/innobackupex/improved_ftwrl.rst 2013-09-11 06:23:12 +0000
3+++ storage/innobase/xtrabackup/doc/source/innobackupex/improved_ftwrl.rst 2015-01-13 15:12:08 +0000
4@@ -18,7 +18,7 @@
5
6 Another possibility is to specify the type of query to wait on. In this case :option:`innobackupex --lock-wait-query-type`. Possible values are ``all`` and ``update``. When ``all`` is used |innobackupex| will wait for all long running queries (execution time longer than allowed by :option:`innobackupex --lock-wait-threshold`) to finish before running the ``FLUSH TABLES WITH READ LOCK``. When ``update`` is used |innobackupex| will wait on ``UPDATE/ALTER/REPLACE/INSERT`` queries to finish.
7
8-Although time needed for specific query to complete is hard to predict, we can assume that queries that are running for a long time already will likely not be completed soon, and queries which are running for a short time will likely be completed shortly. |innobackupex| can use the value of :option:`innobackupex --lock-wait-threshold` option to specify which query is long running and will likely block global lock for a while.
9+Although time needed for specific query to complete is hard to predict, we can assume that queries that are running for a long time already will likely not be completed soon, and queries which are running for a short time will likely be completed shortly. |innobackupex| can use the value of :option:`innobackupex --lock-wait-threshold` option to specify which query is long running and will likely block global lock for a while. In order to use this option xtrabackup user should have ``PROCESS`` and ``SUPER`` privileges.
10
11 Killing the blocking queries
12 ----------------------------
13
14=== modified file 'storage/innobase/xtrabackup/doc/source/innobackupex/privileges.rst'
15--- storage/innobase/xtrabackup/doc/source/innobackupex/privileges.rst 2013-08-30 09:55:04 +0000
16+++ storage/innobase/xtrabackup/doc/source/innobackupex/privileges.rst 2015-01-13 15:12:08 +0000
17@@ -49,13 +49,21 @@
18
19 The database user needs the following privileges on the tables / databases to be backed up:
20
21- * ``RELOAD`` and ``LOCK TABLES`` (unless the :option:`--no-lock <innobackupex --no-lock>` option is specified) in order to ``FLUSH TABLES WITH READ LOCK`` prior to start copying the files and
22+ * ``RELOAD`` and ``LOCK TABLES`` (unless the :option:`--no-lock <innobackupex --no-lock>` option is specified) in order to ``FLUSH TABLES WITH READ LOCK`` and ``FLUSH ENGINE LOGS`` prior to start copying the files, and ``LOCK TABLES FOR BACKUP`` and ``LOCK BINLOG FOR BACKUP`` require this privilege when `Backup Locks <http://www.percona.com/doc/percona-server/5.6/management/backup_locks.html>`_ are used,
23
24 * ``REPLICATION CLIENT`` in order to obtain the binary log position,
25
26- * ``CREATE TABLESPACE`` in order to import tables (see :ref:`imp_exp_ibk`) and
27-
28- * ``SUPER`` in order to start/stop the slave threads in a replication environment.
29+ * ``CREATE TABLESPACE`` in order to import tables (see :ref:`imp_exp_ibk`),
30+
31+ * ``PROCESS`` in order to see all threads which are running on the server (see :ref:`improved_ftwrl`),
32+
33+ * ``SUPER`` in order to start/stop the slave threads in a replication environment, use `XtraDB Changed Page Tracking <https://www.percona.com/doc/percona-server/5.6/management/changed_page_tracking.html>`_ for :ref:`xb_incremental` and for :ref:`improved_ftwrl`,
34+
35+ * ``CREATE`` privilege in order to create the :ref:`PERCONA_SCHEMA.xtrabackup_history <xtrabackup_history>` database and table,
36+
37+ * ``INSERT`` privilege in order to add history records to the :ref:`PERCONA_SCHEMA.xtrabackup_history <xtrabackup_history>` table,
38+
39+ * ``SELECT`` privilege in order to use :option:`innobackupex --incremental-history-name` or :option:`innobackupex --incremental-history-uuid` in order for the feature to look up the ``innodb_to_lsn`` values in the :ref:`PERCONA_SCHEMA.xtrabackup_history <xtrabackup_history>` table.
40
41 The explanation of when these are used can be found in :ref:`how_ibk_works`.
42

Subscribers

People subscribed via source and target branches