Percona Server moved to https://jira.percona.com/projects/PS

Merge lp:~hrvojem/percona-server/rn-5.6.13-60.5 into lp:percona-server/5.6

  1. rn-5.6.13-60.5
  2. Merge into 5.6
Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 419
Proposed branch: lp:~hrvojem/percona-server/rn-5.6.13-60.5
Merge into: lp:percona-server/5.6
Diff against target: 314 lines (+101/-22)
7 files modified
doc/source/changed_in_56.rst (+2/-0)
doc/source/conf.py (+1/-1)
doc/source/flexibility/buff_read_ahead_area.rst (+24/-0)
doc/source/index.rst (+1/-0)
doc/source/release-notes/Percona-Server-5.6.13-60.5.rst (+33/-0)
doc/source/release-notes/release-notes_index.rst (+1/-0)
doc/source/upstream-bug-fixes.rst (+39/-21)
To merge this branch: bzr merge lp:~hrvojem/percona-server/rn-5.6.13-60.5
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+182549@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Lines 38-44 are not true anymore because the current fix is different from the 5.5 port. Currently the read ahead area size is precalculated once instead of hardcoding it at 64, and it is not Facebook patch port anymore.

Line 51: it's a new implementation, so not sure, something about 5.5 feature re-implemented in 5.6.

Author/Origin is not Facebook anymore. But it is a Facebook bug report that motivated it. Facebook link at "Other reading" still applies.

Line 89: not "second"

review: Needs Fixing
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Just in case, the note about the minimum buffer pool size being 32 MB de facto is not correct anymore too.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

It is wrong to say that it is precomputed as soon as buffer pool size becomes > 16 MB. It is precomputed for all buffer sizes.

review: Needs Fixing
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/changed_in_56.rst'
2--- doc/source/changed_in_56.rst 2013-08-28 06:12:06 +0000
3+++ doc/source/changed_in_56.rst 2013-08-28 09:39:44 +0000
4@@ -25,6 +25,7 @@
5 * ``SHOW ENGINE INNODB STATUS`` section "OLDEST VIEW" has been replaced by the :table:`XTRADB_READ_VIEW` INFORMATION_SCHEMA table.
6 * ``SHOW ENGINE INNODB STATUS`` sections on memory usage for InnoDB/XtraDB hash tables has been replaced by the :table:`XTRADB_INTERNAL_HASH_TABLES` INFORMATION_SCHEMA table.
7 * The :table:`INNODB_RSEG` table has been renamed to :table:`XTRADB_RSEG`.
8+ * :ref:`buff_read_ahead_area` has been implemented differently. Buffer read-ahead area size is now precalculated once per buffer pool instance initialization instead of hardcoding it at 64MB (like it was done in previous |Percona Server| versions).
9
10 Features available in |Percona Server| 5.5 that have been replaced with |MySQL| 5.6 features
11 ============================================================================================
12@@ -75,6 +76,7 @@
13 :ref:`mysql_syslog` :rn:`5.6.11-60.3`
14 :ref:`show_engines` :rn:`5.6.11-60.3`
15 :ref:`thread_based_profiling` :rn:`5.6.11-60.3`
16+ :ref:`buff_read_ahead_area` :rn:`5.6.13-60.5`
17 ========================================== ===================
18
19 List of status variables that are no longer available in |Percona Server| 5.6
20
21=== modified file 'doc/source/conf.py'
22--- doc/source/conf.py 2013-08-28 06:17:38 +0000
23+++ doc/source/conf.py 2013-08-28 09:39:44 +0000
24@@ -54,7 +54,7 @@
25 # The short X.Y version.
26 version = '5.6'
27 # The full version, including alpha/beta/rc tags.
28-release = '5.6.12-60.4'
29+release = '5.6.13-60.5'
30
31 # The language for content autogenerated by Sphinx. Refer to documentation
32 # for a list of supported languages.
33
34=== added file 'doc/source/flexibility/buff_read_ahead_area.rst'
35--- doc/source/flexibility/buff_read_ahead_area.rst 1970-01-01 00:00:00 +0000
36+++ doc/source/flexibility/buff_read_ahead_area.rst 2013-08-28 09:39:44 +0000
37@@ -0,0 +1,24 @@
38+.. _buff_read_ahead_area:
39+
40+====================================
41+ Fixed Size for the Read Ahead Area
42+====================================
43+
44+|InnoDB| dynamically calculates the size of the read-ahead area in case it has to trigger its read-ahead algorithm. When the workload involves heavy I/O operations, this size is computed so frequently that it has a non-negligible impact on the CPU usage. With this fix, buffer read-ahead area size is precalculated once per buffer pool instance initialization, and this value is used each time read-ahead is invoked. This implementation should remove a bottleneck experienced by some users.
45+
46+Version Specific Information
47+============================
48+
49+ * :rn:`5.6.13-60.5` :
50+ |Percona Server| 5.5 feature re-implemented
51+
52+Other Information
53+=================
54+
55+ * Bugs fixed:
56+ :bug:`606811`
57+
58+Other Reading
59+=============
60+
61+ * `BUF_READ_AHEAD_AREA Bottleneck <http://www.facebook.com/notes/mysqlfacebook/using-pmp-to-double-mysql-throughput-part-2/405092575932>`_
62
63=== modified file 'doc/source/index.rst'
64--- doc/source/index.rst 2013-07-12 08:38:41 +0000
65+++ doc/source/index.rst 2013-08-28 09:39:44 +0000
66@@ -83,6 +83,7 @@
67 flexibility/improved_memory_engine
68 flexibility/max_binlog_files
69 flexibility/mysqldump_ignore_create_error
70+ flexibility/buff_read_ahead_area
71
72 Reliability Improvements
73 ========================
74
75=== added file 'doc/source/release-notes/Percona-Server-5.6.13-60.5.rst'
76--- doc/source/release-notes/Percona-Server-5.6.13-60.5.rst 1970-01-01 00:00:00 +0000
77+++ doc/source/release-notes/Percona-Server-5.6.13-60.5.rst 2013-08-28 09:39:44 +0000
78@@ -0,0 +1,33 @@
79+.. rn:: 5.6.13-60.5
80+
81+==============================
82+ |Percona Server| 5.6.13-60.5
83+==============================
84+
85+Percona is glad to announce the third Release Candidate release of |Percona Server| 5.6.13-60.5 on August 28th, 2013 (Downloads are available `here <http://www.percona.com/downloads/Percona-Server-5.6/Percona-Server-5.6.12-60.4/>`_ and from the :doc:`Percona Software Repositories </installation>`.
86+
87+Based on `MySQL 5.6.13 <http://dev.mysql.com/doc/relnotes/mysql/5.6/en/news-5-6-13.html>`_, including all the bug fixes in it, |Percona Server| 5.6.13-60.5 is the third RC release in the |Percona Server| 5.6 series. All of |Percona|'s software is open-source and free, all the details of the release can be found in the `5.6.13-60.5 milestone at Launchpad <https://launchpad.net/percona-server/+milestone/5.6.13-60.5>`_.
88+
89+Ported Features
90+===============
91+
92+ :ref:`buff_read_ahead_area` has been ported from |Percona Server| 5.5
93+
94+Bug Fixes
95+==========
96+
97+ If binary log was enabled, :ref:`Fake Changes <innodb_fake_changes_page>` transactions were binlogged. This could lead to data corruption issues with deeper replication topologies. Bug fixed :bug:`1190580`.
98+
99+ Querying :table:`INFORMATION_SCHEMA.PARTITIONS` could cause key distribution statistics for partitioned tables to be reset to those corresponding to the last partition. Fixed the upstream bug :mysqlbug:`69179`. Bug fixed :bug:`1192354`.
100+
101+ Changes made to the ``RPM`` scripts for previous |Percona Server| version caused installer to fail if there were different :term:`datadir` options in multiple configuration files. Bug fixed :bug:`1201036`.
102+
103+ Fixed the upstream bug :mysqlbug:`42415` that would cause ``UPDATE/DELETE`` statements with the ``LIMIT`` clause to be unsafe for Statement Based Replication even when ``ORDER BY`` primary key was present. Fixed by implementing an algorithm to do more elaborate analysis on the nature of the query to determine whether the query will cause uncertainty for replication or not. Bug fixed :bug:`1132194`.
104+
105+ When an upgrade was performed between major versions (e.g. by uninstalling a 5.1 RPM and then installing a 5.5 one), ``mysql_install_db`` was still called on the existing data directory which lead to re-creation of the ``test`` database. Bug fixed :bug:`1169522`.
106+
107+ Fixed the upstream bug :mysqlbug:`69639` which caused compile errors for |Percona Server| with ``DTrace version Sun D 1.11`` provided by recent ``SmartOS`` versions. Bug fixed :bug:`1196460`.
108+
109+ Fixed a regression introduced in |Percona Server| :rn:`5.6.12-60.4`, where server wouldn't be able to start if :ref:`atomic_fio` was enabled. Bug fixed :bug:`1214735`.
110+
111+Other bugs fixed: bug fixed :bug:`1188162`, bug fixed :bug:`1203308` and bug fixed :bug:`1189743`.
112
113=== modified file 'doc/source/release-notes/release-notes_index.rst'
114--- doc/source/release-notes/release-notes_index.rst 2013-08-27 06:28:12 +0000
115+++ doc/source/release-notes/release-notes_index.rst 2013-08-28 09:39:44 +0000
116@@ -6,6 +6,7 @@
117 :maxdepth: 1
118 :glob:
119
120+ Percona-Server-5.6.13-60.5
121 Percona-Server-5.6.12-60.4
122 Percona-Server-5.6.11-60.3
123 Percona-Server-5.6.10-60.2
124
125=== modified file 'doc/source/upstream-bug-fixes.rst'
126--- doc/source/upstream-bug-fixes.rst 2013-08-27 06:28:12 +0000
127+++ doc/source/upstream-bug-fixes.rst 2013-08-28 09:39:44 +0000
128@@ -5,21 +5,39 @@
129 =============================================================
130
131 +-------------------------------------------------------------------------------------------------------------+
132+|:Upstream bug: :mysqlbug:`69179` - accessing information_schema.partitions causes plans to change |
133+|:Launchpad bug: :bug:`1192354` |
134+|:Upstream state: Verified (checked on 2013-08-28) |
135+|:Fix Released: :rn:`5.6.13-60.5` |
136+|:Upstream fix: N/A |
137++-------------------------------------------------------------------------------------------------------------+
138+|:Upstream bug: :mysqlbug:`42415` - UPDATE/DELETE with LIMIT clause unsafe for SBL even with ORDER BY PK ... |
139+|:Launchpad bug: :bug:`1132194` |
140+|:Upstream state: Verified (checked on 2013-08-28) |
141+|:Fix Released: :rn:`5.6.13-60.5` |
142+|:Upstream fix: N/A |
143++-------------------------------------------------------------------------------------------------------------+
144+|:Upstream bug: :mysqlbug:`69639` - mysql failed to build with dtrace Sun D 1.11 |
145+|:Launchpad bug: :bug:`1196460` |
146+|:Upstream state: Open (checked on 2013-08-28) |
147+|:Fix Released: :rn:`5.6.13-60.5` |
148+|:Upstream fix: N/A |
149++-------------------------------------------------------------------------------------------------------------+
150 |:Upstream bug: :mysqlbug:`69524` - Some tests for table cache variables fail if open files limit is too low |
151 |:Launchpad bug: :bug:`1182572` |
152-|:Upstream state: Verified (checked on 2013-06-26) |
153+|:Upstream state: Verified (checked on 2013-08-28) |
154 |:Fix Released: :rn:`5.6.12-60.4` |
155 |:Upstream fix: N/A |
156 +-------------------------------------------------------------------------------------------------------------+
157 |:Upstream bug: :mysqlbug:`68354` - Server crashes on update/join FEDERATED + local table when only 1 local...|
158 |:Launchpad bug: :bug:`1182572` |
159-|:Upstream state: Verified (checked on 2013-06-26) |
160+|:Upstream state: N/A |
161 |:Fix Released: :rn:`5.6.12-60.4` |
162 |:Upstream fix: N/A |
163 +-------------------------------------------------------------------------------------------------------------+
164 |:Upstream bug: :mysqlbug:`69252` - All the parts.partition_max* tests are broken with MTR --parallel |
165 |:Launchpad bug: :bug:`1180481` |
166-|:Upstream state: Verified (checked on 2013-06-26) |
167+|:Upstream state: Verified (checked on 2013-08-28) |
168 |:Fix Released: :rn:`5.6.11-60.3` |
169 |:Upstream fix: N/A |
170 +-------------------------------------------------------------------------------------------------------------+
171@@ -31,7 +49,7 @@
172 +-------------------------------------------------------------------------------------------------------------+
173 |:Upstream bug: :mysqlbug:`68714` - Remove literal statement digest values from perfschema tests |
174 |:Launchpad bug: :bug:`1157078` |
175-|:Upstream state: Verified (checked on 2013-06-26) |
176+|:Upstream state: Verified (checked on 2013-08-28) |
177 |:Fix Released: :rn:`5.6.11-60.3` |
178 |:Upstream fix: N/A |
179 +-------------------------------------------------------------------------------------------------------------+
180@@ -55,13 +73,13 @@
181 +-------------------------------------------------------------------------------------------------------------+
182 |:Upstream bug: :mysqlbug:`68970` - fsp_reserve_free_extents switches from small to big tblspace handling ... |
183 |:Launchpad bug: :bug:`1169494` |
184-|:Upstream state: Verified (checked on 2013-06-26) |
185+|:Upstream state: Verified (checked on 2013-08-28) |
186 |:Fix Released: :rn:`5.6.11-60.3` |
187 |:Upstream fix: N/A |
188 +-------------------------------------------------------------------------------------------------------------+
189 |:Upstream bug: :mysqlbug:`68713` - create_duplicate_weedout_tmp_table() leaves key_part_flag uninitialized |
190 |:Launchpad bug: :bug:`1157037` |
191-|:Upstream state: Verified (checked on 2013-06-26) |
192+|:Upstream state: Verified (checked on 2013-08-28) |
193 |:Fix Released: :rn:`5.6.11-60.3` |
194 |:Upstream fix: N/A |
195 +-------------------------------------------------------------------------------------------------------------+
196@@ -73,21 +91,21 @@
197 +-------------------------------------------------------------------------------------------------------------+
198 |:Upstream bug: :mysqlbug:`68999` - SSL_OP_NO_COMPRESSION not defined |
199 |:Launchpad bug: :bug:`1183610` |
200-|:Upstream state: Verified (checked on 2013-06-26) |
201+|:Upstream state: Open (checked on 2013-08-28) |
202 |:Fix Released: :rn:`5.6.11-60.3` |
203 |:Upstream fix: N/A |
204 +-------------------------------------------------------------------------------------------------------------+
205 |:Upstream bug: :mysqlbug:`68845` - Unnecessary log_sys->mutex reacquisition in mtr_log_reserve_and_write() |
206 |:Launchpad bug: :bug:`1163439` |
207-|:Upstream state: Verified (checked on 2013-06-26) |
208+|:Upstream state: Verified (checked on 2013-08-28) |
209 |:Fix Released: :rn:`5.6.11-60.3` |
210 |:Upstream fix: N/A |
211 +-------------------------------------------------------------------------------------------------------------+
212 |:Upstream bug: :mysqlbug:`62578` - mysql client aborts connection on terminal resize |
213 |:Launchpad bug: :bug:`925343` |
214-|:Upstream state: Verified (checked on 2013-06-26) |
215+|:Upstream state: Closed |
216 |:Fix Released: :rn:`5.6.11-60.3` |
217-|:Upstream fix: N/A |
218+|:Upstream fix: 5.6.12 |
219 +-------------------------------------------------------------------------------------------------------------+
220 |:Upstream bug: :mysqlbug:`49169` - read_view_open_now is inefficient with many concurrent sessions |
221 |:Launchpad bug: :bug:`1131187` and :bug:`1131189` |
222@@ -109,7 +127,7 @@
223 +-------------------------------------------------------------------------------------------------------------+
224 |:Upstream bug: :mysqlbug:`68476` - Suboptimal code in my_strnxfrm_simple() |
225 |:Launchpad bug: :bug:`1132350` |
226-|:Upstream state: Verified (checked on 2013-06-26) |
227+|:Upstream state: Verified (checked on 2013-08-28) |
228 |:Fix Released: :rn:`5.6.11-60.3` |
229 |:Upstream fix: N/A |
230 +-------------------------------------------------------------------------------------------------------------+
231@@ -145,7 +163,7 @@
232 +-------------------------------------------------------------------------------------------------------------+
233 |:Upstream bug: :mysqlbug:`66237` - Temporary files created by binary log cache are not purged after transa...|
234 |:Launchpad bug: :bug:`1070856` |
235-|:Upstream state: Verified (checked on 2013-06-26) |
236+|:Upstream state: Verified (checked on 2013-08-28) |
237 |:Fix Released: :rn:`5.6.11-60.3` |
238 |:Upstream fix: N/A |
239 +-------------------------------------------------------------------------------------------------------------+
240@@ -163,13 +181,13 @@
241 +-------------------------------------------------------------------------------------------------------------+
242 |:Upstream bug: :mysqlbug:`61180` - korr/store macros in my_global.h assume the argument to be a char pointer |
243 |:Launchpad bug: :bug:`1042517` |
244-|:Upstream state: Verified (checked on 2013-06-26) |
245+|:Upstream state: Verified (checked on 2013-08-28) |
246 |:Fix Released: :rn:`5.6.11-60.3` |
247 |:Upstream fix: N/A |
248 +-------------------------------------------------------------------------------------------------------------+
249 |:Upstream bug: :mysqlbug:`61178` - Incorrect implementation of intersect(ulonglong) in non-optimized Bitmap..|
250 |:Launchpad bug: :bug:`1042517` |
251-|:Upstream state: Verified (checked on 2013-06-26) |
252+|:Upstream state: Verified (checked on 2013-08-28) |
253 |:Fix Released: :rn:`5.6.11-60.3` |
254 |:Upstream fix: N/A |
255 +-------------------------------------------------------------------------------------------------------------+
256@@ -181,7 +199,7 @@
257 +-------------------------------------------------------------------------------------------------------------+
258 |:Upstream bug: :mysqlbug:`64800` - mysqldump with --include-master-host-port putting quotes around port no. |
259 |:Launchpad bug: :bug:`1013432` |
260-|:Upstream state: Verified (checked on 2013-06-26) |
261+|:Upstream state: Verified (checked on 2013-08-28) |
262 |:Fix Released: :rn:`5.6.11-60.3` |
263 |:Upstream fix: N/A |
264 +-------------------------------------------------------------------------------------------------------------+
265@@ -199,7 +217,7 @@
266 +-------------------------------------------------------------------------------------------------------------+
267 |:Upstream bug: :mysqlbug:`64663` - Segfault when adding indexes to InnoDB temporary tables |
268 |:Launchpad bug: :bug:`999147` |
269-|:Upstream state: Verified (checked on 2013-06-26) |
270+|:Upstream state: Verified (checked on 2013-08-28) |
271 |:Fix Released: :rn:`5.6.11-60.3` |
272 |:Upstream fix: N/A |
273 +-------------------------------------------------------------------------------------------------------------+
274@@ -211,13 +229,13 @@
275 +-------------------------------------------------------------------------------------------------------------+
276 |:Upstream bug: :mysqlbug:`25007` - memory tables with dynamic rows format |
277 |:Launchpad bug: N/A |
278-|:Upstream state: Verified (checked on 2013-06-26) |
279+|:Upstream state: Verified (checked on 2013-08-28) |
280 |:Fix Released: :rn:`5.6.11-60.3` |
281 |:Upstream fix: N/A |
282 +-------------------------------------------------------------------------------------------------------------+
283 |:Upstream bug: :mysqlbug:`61595` - mysql-test/include/wait_for_slave_param.inc timeout logic is incorrect |
284 |:Launchpad bug: :bug:`800035` |
285-|:Upstream state: Verified (checked on 2013-06-26) |
286+|:Upstream state: Verified (checked on 2013-08-28) |
287 |:Fix Released: :rn:`5.6.11-60.3` |
288 |:Upstream fix: N/A |
289 +-------------------------------------------------------------------------------------------------------------+
290@@ -229,7 +247,7 @@
291 +-------------------------------------------------------------------------------------------------------------+
292 |:Upstream bug: :mysqlbug:`68116` - InnoDB monitor may hit an assertion error in buf_page_get_gen in debug ...|
293 |:Launchpad bug: :bug:`1100178` |
294-|:Upstream state: Analyzing (checked on 2013-06-26) |
295+|:Upstream state: Analyzing (checked on 2013-08-28) |
296 |:Fix Released: :rn:`5.6.10-60.2` |
297 |:Upstream fix: N/A |
298 +-------------------------------------------------------------------------------------------------------------+
299@@ -241,13 +259,13 @@
300 +-------------------------------------------------------------------------------------------------------------+
301 |:Upstream bug: :mysqlbug:`20001` - Support for temp-tables in INFORMATION_SCHEMA |
302 |:Launchpad bug: N/A |
303-|:Upstream state: Verified (checked on 2013-06-26) |
304+|:Upstream state: Verified (checked on 2013-08-28) |
305 |:Fix Released: :rn:`5.6.5-60.0` |
306 |:Upstream fix: N/A |
307 +-------------------------------------------------------------------------------------------------------------+
308 |:Upstream bug: :mysqlbug:`69146` - Optimization in buf_pool_get_oldest_modification if srv_buf_pool_instances|
309 |:Launchpad bug: :bug:`1176496` |
310-|:Upstream state: Open (checked on 2013-06-26) |
311+|:Upstream state: Open (checked on 2013-08-28) |
312 |:Fix Released: :rn:`5.6.5-60.0` |
313 |:Upstream fix: N/A |
314 +-------------------------------------------------------------------------------------------------------------+

Subscribers

People subscribed via source and target branches