Merge lp:~hrvojem/percona-server/rn-5.5.37-35.0-5.5 into lp:percona-server/5.5
Status: | Merged |
---|---|
Approved by: | Laurynas Biveinis on 2014-04-30 |
Approved revision: | 647 |
Merged at revision: | 655 |
Proposed branch: | lp:~hrvojem/percona-server/rn-5.5.37-35.0-5.5 |
Merge into: | lp:percona-server/5.5 |
Diff against target: |
679 lines (+428/-22) 10 files modified
doc/source/conf.py (+3/-1) doc/source/diagnostics/scalability_metrics_plugin.rst (+99/-0) doc/source/diagnostics/slow_extended_55.rst (+8/-3) doc/source/index.rst (+2/-0) doc/source/installation/apt_repo.rst (+1/-1) doc/source/management/audit_log_plugin.rst (+234/-0) doc/source/release-notes/Percona-Server-5.5.29-30.0.rst (+1/-1) doc/source/release-notes/Percona-Server-5.5.37-35.0.rst (+45/-0) doc/source/release-notes/release-notes_index.rst (+1/-0) doc/source/upstream-bug-fixes.rst (+34/-16) |
To merge this branch: | bzr merge lp:~hrvojem/percona-server/rn-5.5.37-35.0-5.5 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Laurynas Biveinis (community) | 2014-04-29 | Approve on 2014-04-30 | |
Review via email:
|
- 1182535: stray "i"
- 1282008: s/add connection/handle a new client connection
- 1286114: the description needs to be end-user: fixed a
performance issue in extending tablespaces if running under
fusionIO with atomic writes enabled.
- 375: either s/sources files/sources, either s/sources
files/source files
- 33: "to provide additional information" is too vague description
for scalability metrics plugin
- 50: s/Scalability Metrics/The plugin
- 74: I don't understand the "(status variables)" bit?
- s/starting point/the starting point, but I don't particularly
like it. I'd try removing it completely.
- scalability_
of all completed queries? something else?
- 112: define "server's total busy time"
- slow query log docs not updated for 1287650 (look at 140, 141)
- 149: Remove instead of each query having ... and the last
sentence, write "... deterministically. With the current
implement
1/n to get logged."
- 488: link atomic writes
- 490: s/selection of query/selection of queries
- "PS has implemented X" comment has not been addressed. "X has
been implemented for PS" is more correct, but not necessarily
nicer, I'd try to think of some other way to say.
- 33: Percona Server has implemented extra scalability metrics in
5.5.37-35.0. These metrics allow using Little's Law, queueing
theory, and Universal Scalability Law to gain insights into
server performance.
- 33: link to USL on Percona site (the other two things are easily
googlable, this one not particularly).
- 84+: s/since metrics were started/since the metrics collection
was started
- 105: replace high resolution with the actual time unit
- 112: This counter accounts the non-idle server time, that is,
time when at least one query was executing.
- 498: Fixed by randomly selecting the queries to be logged
instead of logging every nth query.
- From the previous review:
- 33: link to USL on Percona site (the other two things are easily
googlable, this one not particularly).
Partial review:
- slow query log rate filtering docs need update for 1016991. ation of Oracle's one.
- 94: I don't like intro "X is free open-source Oracle's Y." I'd
edit to tell what the audit plugin is, independently from
Oracle, and only then mention that it is an alternative
implement
- 151: is shipped with Percona Server but is not installed by
default
- 177: s/can't/can ?
- 305: duplicate of 294
- 350: something else than "PS has implemented X"
- 1262439: fix was not ported from 5.7, check the bug report for
the correct credit.
- 1070255: s/ported/backported
- 1298352: the previous release or previous releases?