Merge lp:~hrvojem/percona-server/bug868002-5.5 into lp:percona-server/5.5

Proposed by Hrvoje Matijakovic on 2012-09-05
Status: Work in progress
Proposed branch: lp:~hrvojem/percona-server/bug868002-5.5
Merge into: lp:percona-server/5.5
Diff against target: 172 lines (+60/-35)
4 files modified
doc/source/diagnostics/slow_extended_55.rst (+43/-20)
doc/source/installation/apt_repo.rst (+7/-8)
doc/source/installation/yum_repo.rst (+9/-6)
doc/source/release-notes/Percona-Server-5.5.27-28.1.rst (+1/-1)
To merge this branch: bzr merge lp:~hrvojem/percona-server/bug868002-5.5
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing on 2012-09-05
Laurynas Biveinis (community) 2012-09-05 Approve on 2012-09-05
Review via email: mp+122859@code.launchpad.net
To post a comment you must log in.
297. By Hrvoje Matijakovic on 2012-09-05

      * replaced RC repositories with Experimental
      * bug fix for Bug #868002
      * updated the RN bug#1038225 description

review: Approve
Alexey Kopytov (akopytov) wrote :

Couple of comments:

1. The log_slow_filter value accepted by the server is qc_miss rather than qc_hit. Which is inconsistent with the "QC_Hit:" value printed in the slow log, but we have to live with that as we cannot change it in stable releases. However, the documentation for log_slow_filter is now incorrect.

2. The bug (more precisely, item(2) from the report) applies to both 5.1 and 5.5. I'm going to target it to 5.1 series.

review: Needs Fixing

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/source/diagnostics/slow_extended_55.rst'
--- doc/source/diagnostics/slow_extended_55.rst 2012-08-03 08:58:37 +0000
+++ doc/source/diagnostics/slow_extended_55.rst 2012-09-05 13:11:20 +0000
@@ -42,8 +42,8 @@
4242
43Filters the slow log by the query's execution plan. The value is a comma-delimited string, and can contain any combination of the following values:43Filters the slow log by the query's execution plan. The value is a comma-delimited string, and can contain any combination of the following values:
4444
45 * ``qc_miss``:45 * ``qc_hit``:
46 The query was not found in the query cache.46 The query was found in the query cache.
4747
48 * ``full_scan``:48 * ``full_scan``:
49 The query performed a full table scan.49 The query performed a full table scan.
@@ -259,20 +259,43 @@
259259
260 # User@Host: mailboxer[mailboxer] @ [192.168.10.165]260 # User@Host: mailboxer[mailboxer] @ [192.168.10.165]
261 # Thread_id: 11167745 Schema: board261 # Thread_id: 11167745 Schema: board
262 # QC_Hit: No Full_scan: No Full_join: No Tmp_table: Yes Disk_tmp_table: No262 # Query_time: 1.009400 Lock_time: 0.000190 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
263 # Filesort: Yes Disk_filesort: No Merge_passes: 0263 # Bytes_sent: 278 Tmp_tables: 0 Tmp_disk_tables: 0 Tmp_table_sizes: 0
264 # Query_time: 0.000659 Lock_time: 0.000070 Rows_sent: 0 Rows_examined: 30 Rows_affected: 0 Rows_read: 30264 # InnoDB_trx_id: 1500
265 # innodb_IO_r_ops: 1 innodb_IO_r_bytes: 16384 innodb_IO_r_wait: 0.028487265 # QC_Hit: No Full_scan: Yes Full_join: No Tmp_table: No Tmp_table_on_disk: No
266 # innodb_rec_lock_wait: 0.000000 innodb_queue_wait: 0.000000266 # Filesort: No Filesort_on_disk: No Merge_passes: 0
267 # innodb_pages_distinct: 5267 # InnoDB_IO_r_ops: 6415 InnoDB_IO_r_bytes: 105103360 InnoDB_IO_r_wait: 0.001279
268 select count(distinct author_id) from art87.article87 force index (forum_id) where forum_id = 240215 and thread_id = ``710575`` 268 # InnoDB_rec_lock_wait: 0.000000 InnoDB_queue_wait: 0.000000
269 # InnoDB_pages_distinct: 6430
270 SET timestamp=1346844943;
271 SELECT id,title,production_year FROM title WHERE title = 'Bambi';
269272
270Another example (:variable:`log_slow_verbosity` ``=profiling``): ::273Another example (:variable:`log_slow_verbosity` ``=profiling``): ::
271274
272 # Query_time: 4.555235 Lock_time: 0.000000 Rows_sent: 1 Rows_examined: 0 Rows_affected: 0 Rows_read: 1275 # Query_time: 0.962742 Lock_time: 0.000202 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
273 # Profile_starting: 4.554799 Profile_starting_cpu: 0.000000 Profile_checking_permissions: 0.000095 Profile_checking_permissions_cpu: 0.000000 Profile_Opening_tables: 0.000088 Profile_Opening_tables_cpu: 0.000000 Profile_init: 0.000056 Profile_init_cpu: 0.000000 Profile_optimizing: 0.000046 Profile_optimizing_cpu: 0.000000 Profile_executing: 0.000098 Profile_executing_cpu: 0.000000 Profile_end: 0.000049 Profile_end_cpu: 0.000000 Profile_query_end: 0.000045 Profile_query_end_cpu: 0.000000 Profile_freeing_items: 0.000084 Profile_freeing_items_cpu: 0.000000 Profile_logging_slow_query: 0.000045 Profile_logging_slow_query_cpu: 0.000000 276 # Bytes_sent: 278 Tmp_tables: 0 Tmp_disk_tables: 0 Tmp_table_sizes: 0
274 # Profile_total: 4.555405 Profile_total_cpu: 0.000000 277 # Profile_starting: 0.000030 Profile_starting_cpu: 0.000028 Profile_Waiting_for_query_cache_lock: 0.000003
275 insert into teee4 select * from teee4 limit 10000000;278 Profile_Waiting_for_query_cache_lock_cpu: 0.000003 Profile_Waiting_on_query_cache_mutex: 0.000003
279 Profile_Waiting_on_query_cache_mutex_cpu: 0.000003 Profile_checking_query_cache_for_query: 0.000076
280 Profile_checking_query_cache_for_query_cpu: 0.000076 Profile_checking_permissions: 0.000011
281 Profile_checking_permissions_cpu: 0.000011 Profile_Opening_tables: 0.000078 Profile_Opening_tables_cpu: 0.000078
282 Profile_System_lock: 0.000022 Profile_System_lock_cpu: 0.000022 Profile_Waiting_for_query_cache_lock: 0.000003
283 Profile_Waiting_for_query_cache_lock_cpu: 0.000002 Profile_Waiting_on_query_cache_mutex: 0.000054
284 Profile_Waiting_on_query_cache_mutex_cpu: 0.000054 Profile_init: 0.000039 Profile_init_cpu: 0.000040
285 Profile_optimizing: 0.000015 Profile_optimizing_cpu: 0.000014 Profile_statistics: 0.000021 Profile_statistics_cpu: 0.000021
286 Profile_preparing: 0.000020 Profile_preparing_cpu: 0.000020 Profile_executing: 0.000003 Profile_executing_cpu: 0.000003
287 Profile_Sending_data: 0.962324 Profile_Sending_data_cpu: 0.961526 Profile_end: 0.000006 Profile_end_cpu: 0.000005
288 Profile_query_end: 0.000004 Profile_query_end_cpu: 0.000004 Profile_closing_tables: 0.000008 Profile_closing_tables_cpu: 0.000008
289 Profile_freeing_items: 0.000007 Profile_freeing_items_cpu: 0.000007 Profile_Waiting_for_query_cache_lock: 0.000000
290 Profile_Waiting_for_query_cache_lock_cpu: 0.000001 Profile_Waiting_on_query_cache_mutex: 0.000001
291 Profile_Waiting_on_query_cache_mutex_cpu: 0.000001 Profile_freeing_items: 0.000017 Profile_freeing_items_cpu: 0.000016
292 Profile_Waiting_for_query_cache_lock: 0.000001 Profile_Waiting_for_query_cache_lock_cpu: 0.000001
293 Profile_Waiting_on_query_cache_mutex: 0.000000 Profile_Waiting_on_query_cache_mutex_cpu: 0.000001
294 Profile_freeing_items: 0.000001 Profile_freeing_items_cpu: 0.000001 Profile_storing_result_in_query_cache: 0.000002
295 Profile_storing_result_in_query_cache_cpu: 0.000002 Profile_logging_slow_query: 0.000001 Profile_logging_slow_query_cpu: 0.000001
296 # Profile_total: 0.962751 Profile_total_cpu: 0.961950
297 # InnoDB_trx_id: 1700
298
276299
277Connection and Schema Identifier300Connection and Schema Identifier
278--------------------------------301--------------------------------
@@ -290,7 +313,7 @@
290313
291The feature also adds information about how many rows were examined for ``SELECT`` queries, and how many were analyzed and affected for ``UPDATE``, ``DELETE``, and ``INSERT`` queries, ::314The feature also adds information about how many rows were examined for ``SELECT`` queries, and how many were analyzed and affected for ``UPDATE``, ``DELETE``, and ``INSERT`` queries, ::
292315
293 # Query_time: 0.000659 Lock_time: 0.000070 Rows_sent: 0 Rows_examined: 30 Rows_affected: 0 Rows_read: 30316 # Query_time: 0.962742 Lock_time: 0.000202 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
294317
295Values and context:318Values and context:
296319
@@ -306,7 +329,7 @@
306Memory Footprint329Memory Footprint
307----------------330----------------
308331
309The feature provides information about the amount of bytes sent for the result of the query and the number of temporary tables created for its execution - differentiated by whether they were created on memory or on disk - with the total number of bytes used by them. ::332The feature provides information about the amount of bytes sent for the result of the query and the number of temporary tables created for its execution - differentiated by whether they were created on memory or on disk - with the total number of bytes used by them. ::
310333
311 # Bytes_sent: 8053 Tmp_tables: 1 Tmp_disk_tables: 0 Tmp_table_sizes: 950528334 # Bytes_sent: 8053 Tmp_tables: 1 Tmp_disk_tables: 0 Tmp_table_sizes: 950528
312335
@@ -330,8 +353,8 @@
330353
331Each query can be executed in various ways. For example, it may use indexes or do a full table scan, or a temporary table may be needed. These are the things that you can usually see by running ``EXPLAIN`` on the query. The feature will now allow you to see the most important facts about the execution in the log file. ::354Each query can be executed in various ways. For example, it may use indexes or do a full table scan, or a temporary table may be needed. These are the things that you can usually see by running ``EXPLAIN`` on the query. The feature will now allow you to see the most important facts about the execution in the log file. ::
332355
333 # QC_Hit: No Full_scan: No Full_join: No Tmp_table: Yes Disk_tmp_table: No356 # QC_Hit: No Full_scan: Yes Full_join: No Tmp_table: No Tmp_table_on_disk: No
334 # Filesort: Yes Disk_filesort: No Merge_passes: 0357 # Filesort: No Filesort_on_disk: No Merge_passes: 0
335358
336The values and their meanings are documented with the :variable:`log_slow_filter` option.359The values and their meanings are documented with the :variable:`log_slow_filter` option.
337360
@@ -340,9 +363,9 @@
340363
341The final part of the output is the |InnoDB| usage statistics. |MySQL| currently shows many per-session statistics for operations with ``SHOW SESSION STATUS``, but that does not include those of |InnoDB|, which are always global and shared by all threads. This feature lets you see those values for a given query. ::364The final part of the output is the |InnoDB| usage statistics. |MySQL| currently shows many per-session statistics for operations with ``SHOW SESSION STATUS``, but that does not include those of |InnoDB|, which are always global and shared by all threads. This feature lets you see those values for a given query. ::
342365
343 # innodb_IO_r_ops: 1 innodb_IO_r_bytes: 16384 innodb_IO_r_wait: 0.028487366 # InnoDB_IO_r_ops: 6415 InnoDB_IO_r_bytes: 105103360 InnoDB_IO_r_wait: 0.001279
344 # innodb_rec_lock_wait: 0.000000 innodb_queue_wait: 0.000000367 # InnoDB_rec_lock_wait: 0.000000 InnoDB_queue_wait: 0.000000
345 # innodb_pages_distinct: 5368 # InnoDB_pages_distinct: 6430
346369
347Values:370Values:
348371
349372
=== modified file 'doc/source/installation/apt_repo.rst'
--- doc/source/installation/apt_repo.rst 2012-06-04 13:39:55 +0000
+++ doc/source/installation/apt_repo.rst 2012-09-05 13:11:20 +0000
@@ -49,14 +49,13 @@
49 * 12.04LTS (precise)49 * 12.04LTS (precise)
5050
5151
52Release Candidate Repository52Percona `apt` Experimental repository
53============================53=====================================
5454
55To subscribe to the release candidate repository, add two lines to the :file:`/etc/apt/sources.list` file, again replacing ``VERSION`` with your server's release version: ::55Percona offers fresh beta builds from the experimental repository. To enable it add the following lines to your :file:`/etc/apt/sources.list` , replacing ``VERSION`` with the name of your distribution: ::
5656
57 deb http://repo.percona.com/apt-rc VERSION main57 deb http://repo.percona.com/apt VERSION main experimental
58 deb-src http://repo.percona.com/apt-rc VERSION main58 deb-src http://repo.percona.com/apt VERSION main experimental
59
6059
61Apt-Pinning the packages60Apt-Pinning the packages
62========================61========================
6362
=== modified file 'doc/source/installation/yum_repo.rst'
--- doc/source/installation/yum_repo.rst 2012-01-09 04:35:32 +0000
+++ doc/source/installation/yum_repo.rst 2012-09-05 13:11:20 +0000
@@ -73,9 +73,12 @@
7373
74* *Amazon Linux AMI* (works the same as *CentOS* 5)74* *Amazon Linux AMI* (works the same as *CentOS* 5)
7575
76Release Candidate Repository76Percona `yum` Experimental repository
77============================77=====================================
7878
79To subscribe to the release candidate repository, install the release candidate (RC) *RPM*: ::79Percona offers fresh beta builds from the experimental repository. To subscribe to the experimental repository, install the experimental *RPM*: ::
8080
81 rpm -Uhv http://www.percona.com/downloads/percona-release/percona-rc-0.0-2.x86_64.rpm81 rpm -Uhv http://repo.percona.com/testing/centos/6/os/noarch/percona-testing-0.0-1.noarch.rpm
82
83.. note::
84 This repository works for both RHEL/CentOS 5 and RHEL/CentOS 6
8285
=== modified file 'doc/source/release-notes/Percona-Server-5.5.27-28.1.rst'
--- doc/source/release-notes/Percona-Server-5.5.27-28.1.rst 2012-09-03 13:31:37 +0000
+++ doc/source/release-notes/Percona-Server-5.5.27-28.1.rst 2012-09-05 13:11:20 +0000
@@ -11,7 +11,7 @@
11Bug Fixes11Bug Fixes
12=========12=========
1313
14 |Percona Server| :rn:`5.5.27-28.0` would crash or deadlock in |XtraDB| buffer pool code. This was caused by incorrect mutex handling in recently introduced |InnoDB| code. Bug fixed :bug:`1038225` (*Laurynas Biveinis*).14 |Percona Server| :rn:`5.5.27-28.0` would crash or deadlock in |XtraDB| buffer pool code. This was caused by incorrect mutex handling in porting of the recently introduced InnoDB code to |XtraDB|. Bug fixed :bug:`1038225` (*Laurynas Biveinis*).
1515
16 Variables :variable:`innodb_adaptive_flushing_method` and :variable:`innodb_flush_neighbor_pages` would not correctly translate some values internally. Bug fixed :bug:`1039384` (*Laurynas Biveinis*).16 Variables :variable:`innodb_adaptive_flushing_method` and :variable:`innodb_flush_neighbor_pages` would not correctly translate some values internally. Bug fixed :bug:`1039384` (*Laurynas Biveinis*).
1717

Subscribers

People subscribed via source and target branches