Merge lp:~hrvojem/percona-server/bug868002-5.5 into lp:percona-server/5.5

Proposed by Hrvoje Matijakovic on 2012-09-05
Status: Work in progress
Proposed branch: lp:~hrvojem/percona-server/bug868002-5.5
Merge into: lp:percona-server/5.5
Diff against target: 172 lines (+60/-35)
4 files modified
doc/source/diagnostics/slow_extended_55.rst (+43/-20)
doc/source/installation/apt_repo.rst (+7/-8)
doc/source/installation/yum_repo.rst (+9/-6)
doc/source/release-notes/Percona-Server-5.5.27-28.1.rst (+1/-1)
To merge this branch: bzr merge lp:~hrvojem/percona-server/bug868002-5.5
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing on 2012-09-05
Laurynas Biveinis (community) 2012-09-05 Approve on 2012-09-05
Review via email: mp+122859@code.launchpad.net
To post a comment you must log in.
297. By Hrvoje Matijakovic on 2012-09-05

      * replaced RC repositories with Experimental
      * bug fix for Bug #868002
      * updated the RN bug#1038225 description

review: Approve
Alexey Kopytov (akopytov) wrote :

Couple of comments:

1. The log_slow_filter value accepted by the server is qc_miss rather than qc_hit. Which is inconsistent with the "QC_Hit:" value printed in the slow log, but we have to live with that as we cannot change it in stable releases. However, the documentation for log_slow_filter is now incorrect.

2. The bug (more precisely, item(2) from the report) applies to both 5.1 and 5.5. I'm going to target it to 5.1 series.

review: Needs Fixing

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'doc/source/diagnostics/slow_extended_55.rst'
2--- doc/source/diagnostics/slow_extended_55.rst 2012-08-03 08:58:37 +0000
3+++ doc/source/diagnostics/slow_extended_55.rst 2012-09-05 13:11:20 +0000
4@@ -42,8 +42,8 @@
5
6 Filters the slow log by the query's execution plan. The value is a comma-delimited string, and can contain any combination of the following values:
7
8- * ``qc_miss``:
9- The query was not found in the query cache.
10+ * ``qc_hit``:
11+ The query was found in the query cache.
12
13 * ``full_scan``:
14 The query performed a full table scan.
15@@ -259,20 +259,43 @@
16
17 # User@Host: mailboxer[mailboxer] @ [192.168.10.165]
18 # Thread_id: 11167745 Schema: board
19- # QC_Hit: No Full_scan: No Full_join: No Tmp_table: Yes Disk_tmp_table: No
20- # Filesort: Yes Disk_filesort: No Merge_passes: 0
21- # Query_time: 0.000659 Lock_time: 0.000070 Rows_sent: 0 Rows_examined: 30 Rows_affected: 0 Rows_read: 30
22- # innodb_IO_r_ops: 1 innodb_IO_r_bytes: 16384 innodb_IO_r_wait: 0.028487
23- # innodb_rec_lock_wait: 0.000000 innodb_queue_wait: 0.000000
24- # innodb_pages_distinct: 5
25- select count(distinct author_id) from art87.article87 force index (forum_id) where forum_id = 240215 and thread_id = ``710575``
26+ # Query_time: 1.009400 Lock_time: 0.000190 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
27+ # Bytes_sent: 278 Tmp_tables: 0 Tmp_disk_tables: 0 Tmp_table_sizes: 0
28+ # InnoDB_trx_id: 1500
29+ # QC_Hit: No Full_scan: Yes Full_join: No Tmp_table: No Tmp_table_on_disk: No
30+ # Filesort: No Filesort_on_disk: No Merge_passes: 0
31+ # InnoDB_IO_r_ops: 6415 InnoDB_IO_r_bytes: 105103360 InnoDB_IO_r_wait: 0.001279
32+ # InnoDB_rec_lock_wait: 0.000000 InnoDB_queue_wait: 0.000000
33+ # InnoDB_pages_distinct: 6430
34+ SET timestamp=1346844943;
35+ SELECT id,title,production_year FROM title WHERE title = 'Bambi';
36
37 Another example (:variable:`log_slow_verbosity` ``=profiling``): ::
38
39- # Query_time: 4.555235 Lock_time: 0.000000 Rows_sent: 1 Rows_examined: 0 Rows_affected: 0 Rows_read: 1
40- # Profile_starting: 4.554799 Profile_starting_cpu: 0.000000 Profile_checking_permissions: 0.000095 Profile_checking_permissions_cpu: 0.000000 Profile_Opening_tables: 0.000088 Profile_Opening_tables_cpu: 0.000000 Profile_init: 0.000056 Profile_init_cpu: 0.000000 Profile_optimizing: 0.000046 Profile_optimizing_cpu: 0.000000 Profile_executing: 0.000098 Profile_executing_cpu: 0.000000 Profile_end: 0.000049 Profile_end_cpu: 0.000000 Profile_query_end: 0.000045 Profile_query_end_cpu: 0.000000 Profile_freeing_items: 0.000084 Profile_freeing_items_cpu: 0.000000 Profile_logging_slow_query: 0.000045 Profile_logging_slow_query_cpu: 0.000000
41- # Profile_total: 4.555405 Profile_total_cpu: 0.000000
42- insert into teee4 select * from teee4 limit 10000000;
43+ # Query_time: 0.962742 Lock_time: 0.000202 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
44+ # Bytes_sent: 278 Tmp_tables: 0 Tmp_disk_tables: 0 Tmp_table_sizes: 0
45+ # Profile_starting: 0.000030 Profile_starting_cpu: 0.000028 Profile_Waiting_for_query_cache_lock: 0.000003
46+ Profile_Waiting_for_query_cache_lock_cpu: 0.000003 Profile_Waiting_on_query_cache_mutex: 0.000003
47+ Profile_Waiting_on_query_cache_mutex_cpu: 0.000003 Profile_checking_query_cache_for_query: 0.000076
48+ Profile_checking_query_cache_for_query_cpu: 0.000076 Profile_checking_permissions: 0.000011
49+ Profile_checking_permissions_cpu: 0.000011 Profile_Opening_tables: 0.000078 Profile_Opening_tables_cpu: 0.000078
50+ Profile_System_lock: 0.000022 Profile_System_lock_cpu: 0.000022 Profile_Waiting_for_query_cache_lock: 0.000003
51+ Profile_Waiting_for_query_cache_lock_cpu: 0.000002 Profile_Waiting_on_query_cache_mutex: 0.000054
52+ Profile_Waiting_on_query_cache_mutex_cpu: 0.000054 Profile_init: 0.000039 Profile_init_cpu: 0.000040
53+ Profile_optimizing: 0.000015 Profile_optimizing_cpu: 0.000014 Profile_statistics: 0.000021 Profile_statistics_cpu: 0.000021
54+ Profile_preparing: 0.000020 Profile_preparing_cpu: 0.000020 Profile_executing: 0.000003 Profile_executing_cpu: 0.000003
55+ Profile_Sending_data: 0.962324 Profile_Sending_data_cpu: 0.961526 Profile_end: 0.000006 Profile_end_cpu: 0.000005
56+ Profile_query_end: 0.000004 Profile_query_end_cpu: 0.000004 Profile_closing_tables: 0.000008 Profile_closing_tables_cpu: 0.000008
57+ Profile_freeing_items: 0.000007 Profile_freeing_items_cpu: 0.000007 Profile_Waiting_for_query_cache_lock: 0.000000
58+ Profile_Waiting_for_query_cache_lock_cpu: 0.000001 Profile_Waiting_on_query_cache_mutex: 0.000001
59+ Profile_Waiting_on_query_cache_mutex_cpu: 0.000001 Profile_freeing_items: 0.000017 Profile_freeing_items_cpu: 0.000016
60+ Profile_Waiting_for_query_cache_lock: 0.000001 Profile_Waiting_for_query_cache_lock_cpu: 0.000001
61+ Profile_Waiting_on_query_cache_mutex: 0.000000 Profile_Waiting_on_query_cache_mutex_cpu: 0.000001
62+ Profile_freeing_items: 0.000001 Profile_freeing_items_cpu: 0.000001 Profile_storing_result_in_query_cache: 0.000002
63+ Profile_storing_result_in_query_cache_cpu: 0.000002 Profile_logging_slow_query: 0.000001 Profile_logging_slow_query_cpu: 0.000001
64+ # Profile_total: 0.962751 Profile_total_cpu: 0.961950
65+ # InnoDB_trx_id: 1700
66+
67
68 Connection and Schema Identifier
69 --------------------------------
70@@ -290,7 +313,7 @@
71
72 The feature also adds information about how many rows were examined for ``SELECT`` queries, and how many were analyzed and affected for ``UPDATE``, ``DELETE``, and ``INSERT`` queries, ::
73
74- # Query_time: 0.000659 Lock_time: 0.000070 Rows_sent: 0 Rows_examined: 30 Rows_affected: 0 Rows_read: 30
75+ # Query_time: 0.962742 Lock_time: 0.000202 Rows_sent: 4 Rows_examined: 1543719 Rows_affected: 0 Rows_read: 4
76
77 Values and context:
78
79@@ -306,7 +329,7 @@
80 Memory Footprint
81 ----------------
82
83-The feature provides information about the amount of bytes sent for the result of the query and the number of temporary tables created for its execution - differentiated by whether they were created on memory or on disk - with the total number of bytes used by them. ::
84+The feature provides information about the amount of bytes sent for the result of the query and the number of temporary tables created for its execution - differentiated by whether they were created on memory or on disk - with the total number of bytes used by them. ::
85
86 # Bytes_sent: 8053 Tmp_tables: 1 Tmp_disk_tables: 0 Tmp_table_sizes: 950528
87
88@@ -330,8 +353,8 @@
89
90 Each query can be executed in various ways. For example, it may use indexes or do a full table scan, or a temporary table may be needed. These are the things that you can usually see by running ``EXPLAIN`` on the query. The feature will now allow you to see the most important facts about the execution in the log file. ::
91
92- # QC_Hit: No Full_scan: No Full_join: No Tmp_table: Yes Disk_tmp_table: No
93- # Filesort: Yes Disk_filesort: No Merge_passes: 0
94+ # QC_Hit: No Full_scan: Yes Full_join: No Tmp_table: No Tmp_table_on_disk: No
95+ # Filesort: No Filesort_on_disk: No Merge_passes: 0
96
97 The values and their meanings are documented with the :variable:`log_slow_filter` option.
98
99@@ -340,9 +363,9 @@
100
101 The final part of the output is the |InnoDB| usage statistics. |MySQL| currently shows many per-session statistics for operations with ``SHOW SESSION STATUS``, but that does not include those of |InnoDB|, which are always global and shared by all threads. This feature lets you see those values for a given query. ::
102
103- # innodb_IO_r_ops: 1 innodb_IO_r_bytes: 16384 innodb_IO_r_wait: 0.028487
104- # innodb_rec_lock_wait: 0.000000 innodb_queue_wait: 0.000000
105- # innodb_pages_distinct: 5
106+ # InnoDB_IO_r_ops: 6415 InnoDB_IO_r_bytes: 105103360 InnoDB_IO_r_wait: 0.001279
107+ # InnoDB_rec_lock_wait: 0.000000 InnoDB_queue_wait: 0.000000
108+ # InnoDB_pages_distinct: 6430
109
110 Values:
111
112
113=== modified file 'doc/source/installation/apt_repo.rst'
114--- doc/source/installation/apt_repo.rst 2012-06-04 13:39:55 +0000
115+++ doc/source/installation/apt_repo.rst 2012-09-05 13:11:20 +0000
116@@ -49,14 +49,13 @@
117 * 12.04LTS (precise)
118
119
120-Release Candidate Repository
121-============================
122-
123-To subscribe to the release candidate repository, add two lines to the :file:`/etc/apt/sources.list` file, again replacing ``VERSION`` with your server's release version: ::
124-
125- deb http://repo.percona.com/apt-rc VERSION main
126- deb-src http://repo.percona.com/apt-rc VERSION main
127-
128+Percona `apt` Experimental repository
129+=====================================
130+
131+Percona offers fresh beta builds from the experimental repository. To enable it add the following lines to your :file:`/etc/apt/sources.list` , replacing ``VERSION`` with the name of your distribution: ::
132+
133+ deb http://repo.percona.com/apt VERSION main experimental
134+ deb-src http://repo.percona.com/apt VERSION main experimental
135
136 Apt-Pinning the packages
137 ========================
138
139=== modified file 'doc/source/installation/yum_repo.rst'
140--- doc/source/installation/yum_repo.rst 2012-01-09 04:35:32 +0000
141+++ doc/source/installation/yum_repo.rst 2012-09-05 13:11:20 +0000
142@@ -73,9 +73,12 @@
143
144 * *Amazon Linux AMI* (works the same as *CentOS* 5)
145
146-Release Candidate Repository
147-============================
148-
149-To subscribe to the release candidate repository, install the release candidate (RC) *RPM*: ::
150-
151- rpm -Uhv http://www.percona.com/downloads/percona-release/percona-rc-0.0-2.x86_64.rpm
152+Percona `yum` Experimental repository
153+=====================================
154+
155+Percona offers fresh beta builds from the experimental repository. To subscribe to the experimental repository, install the experimental *RPM*: ::
156+
157+ rpm -Uhv http://repo.percona.com/testing/centos/6/os/noarch/percona-testing-0.0-1.noarch.rpm
158+
159+.. note::
160+ This repository works for both RHEL/CentOS 5 and RHEL/CentOS 6
161
162=== modified file 'doc/source/release-notes/Percona-Server-5.5.27-28.1.rst'
163--- doc/source/release-notes/Percona-Server-5.5.27-28.1.rst 2012-09-03 13:31:37 +0000
164+++ doc/source/release-notes/Percona-Server-5.5.27-28.1.rst 2012-09-05 13:11:20 +0000
165@@ -11,7 +11,7 @@
166 Bug Fixes
167 =========
168
169- |Percona Server| :rn:`5.5.27-28.0` would crash or deadlock in |XtraDB| buffer pool code. This was caused by incorrect mutex handling in recently introduced |InnoDB| code. Bug fixed :bug:`1038225` (*Laurynas Biveinis*).
170+ |Percona Server| :rn:`5.5.27-28.0` would crash or deadlock in |XtraDB| buffer pool code. This was caused by incorrect mutex handling in porting of the recently introduced InnoDB code to |XtraDB|. Bug fixed :bug:`1038225` (*Laurynas Biveinis*).
171
172 Variables :variable:`innodb_adaptive_flushing_method` and :variable:`innodb_flush_neighbor_pages` would not correctly translate some values internally. Bug fixed :bug:`1039384` (*Laurynas Biveinis*).
173

Subscribers

People subscribed via source and target branches