Merge lp:~hrvojem/percona-pam-for-mysql/dialog-intro into lp:percona-pam-for-mysql

Proposed by Hrvoje Matijakovic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 24
Proposed branch: lp:~hrvojem/percona-pam-for-mysql/dialog-intro
Merge into: lp:percona-pam-for-mysql
Diff against target: 47 lines (+21/-3)
3 files modified
.bzrignore (+1/-0)
doc/source/glossary.rst (+1/-1)
doc/source/intro.rst (+19/-2)
To merge this branch: bzr merge lp:~hrvojem/percona-pam-for-mysql/dialog-intro
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+94546@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

The text looks good, couple of nitpicks:

Line 29: s/plugin.This/plugin. This
Line 43: "mysqlclient", does it mean "MySQL client" or "libmysqlclient"?
Line 43: s/1/one

review: Needs Fixing
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

s/it support/it supports

OK with that change, thank you

review: Approve
24. By Hrvoje Matijakovic

* dialog description added with list of features
* doc/build/ added to .bzrignore

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2012-02-01 14:42:43 +0000
3+++ .bzrignore 2012-03-15 14:49:17 +0000
4@@ -18,3 +18,4 @@
5 build/build-binary.sh
6 *.tar.gz
7 m4/*.m4
8+doc/build
9
10=== modified file 'doc/source/glossary.rst'
11--- doc/source/glossary.rst 2011-10-25 10:51:19 +0000
12+++ doc/source/glossary.rst 2012-03-15 14:49:17 +0000
13@@ -5,4 +5,4 @@
14 .. glossary::
15
16 PAM
17- Pluggable Authentication Module
18+ Pluggable Authentication Module - allows integrating multiple authentication mechanisms which can be written independently of the underlying authentication scheme that's being used in the application.
19
20=== modified file 'doc/source/intro.rst'
21--- doc/source/intro.rst 2011-10-25 10:51:19 +0000
22+++ doc/source/intro.rst 2012-03-15 14:49:17 +0000
23@@ -2,5 +2,22 @@
24 About Percona PAM Authentication Plugin for MySQL
25 ==================================================
26
27-
28-A Free and Open Source PAM authentication plugin for MySQL and Percona Server.
29+Percona PAM Authentication Plugin is a free and Open Source implementation of the MySQL's authentication plugin. This plugin acts as a mediator between the MySQL server, the MySQL client, and the PAM stack. The server plugin requests authentication from the PAM stack, forwards any requests and messages from the PAM stack over the wire to the client (in cleartext) and reads back any replies for the PAM stack.
30+
31+ PAM plugin uses dialog as its client side plugin. Dialog plugin can be loaded to any client application that uses libmysqlclient library.
32+
33+Here are some of the benefits that Percona dialog plugin offers over the default one:
34+
35+ * It correctly recognizes whether PAM wants input to be echoed or not, while the default one always echoes the input on the user's console.
36+ * It can use the password which is passed to |MySQL| client via "-p" parameter.
37+ * Dialog client `installation bug <http://bugs.mysql.com/bug.php?id=60745>`_ has been fixed.
38+ * This plugin works on |MySQL| and |Percona Server|.
39+
40+Percona offers two versions of this plugin:
41+
42+ * Full PAM plugin called *auth_pam*. This plugin uses *dialog.so*. It fully supports the PAM protocol with arbitrary communication between client and server.
43+ * Oracle-compatible PAM called *auth_pam_compat*. This plugin uses *mysql_clear_password* which is a part of Oracle MySQL client. It also has some limitations, such as, it supports only one password input. You must use "-p" option in order to pass the password to auth_pam_compat.
44+
45+These two versions of plugins are physically different. To choose which one you want used, you must use *IDENTIFIED WITH 'auth_pam'* for auth_pam, and *IDENTIFIED WITH 'auth_pam_compat'* for auth_pam_compat.
46+
47+

Subscribers

People subscribed via source and target branches