Merge ~hopem/ua-reviewkit:layered-tags into ua-reviewkit:master

Proposed by Edward Hope-Morley
Status: Work in progress
Proposed branch: ~hopem/ua-reviewkit:layered-tags
Merge into: ua-reviewkit:master
Diff against target: 31 lines (+13/-0)
1 file modified
juju/ua-bundle-check.py (+13/-0)
Reviewer Review Type Date Requested Status
UA Reviewers Pending
Review via email: mp+389849@code.launchpad.net
To post a comment you must log in.

Unmerged commits

941c821... by Edward Hope-Morley

Search layer tags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/juju/ua-bundle-check.py b/juju/ua-bundle-check.py
2index b5475d9..0d54a2f 100755
3--- a/juju/ua-bundle-check.py
4+++ b/juju/ua-bundle-check.py
5@@ -363,6 +363,18 @@ class MasterAssertionHelpers(LocalAssertionHelpers):
6 ret.reason = ("check disabled - please check this one manually")
7 return ret
8 master_value = None
9+
10+ used_tags = []
11+ if self.maas_layer:
12+ tags = self.maas_layer['config'].get('tags')
13+ for tag in tags:
14+ ret = re.compile(".+-{}".format(tag)).match(app_name)
15+ if ret:
16+ used_tags.append(tag)
17+ ret = re.compile(value).match(tags[tag]['kernel_opts'])
18+ if ret and application['options'][opt] != ret[0]:
19+ print(ret[0])
20+ break
21
22 with open(self.master_path) as fd:
23 for line in fd.readlines():
24@@ -532,6 +544,7 @@ class UABundleChecker(object):
25 # substring.
26 result = getattr(self.master_assertion_helpers,
27 method)(application, opt, assertion["value"],
28+ self.app_name,
29 warn_on_fail=warn_on_fail)
30 self.add_result(result)
31 return result.passed

Subscribers

People subscribed via source and target branches