Merge ~hopem/ua-reviewkit:add-ceph-replica-count into ua-reviewkit:master

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 3b833349ceb34a4e27337e9ce8273eb0e695cca4
Proposed branch: ~hopem/ua-reviewkit:add-ceph-replica-count
Merge into: ua-reviewkit:master
Diff against target: 62 lines (+31/-0)
1 file modified
juju/checks/openstack.yaml (+31/-0)
Reviewer Review Type Date Requested Status
Amad Ali (community) Approve
Review via email: mp+386247@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Amad Ali (amad) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/juju/checks/openstack.yaml b/juju/checks/openstack.yaml
2index 9d7030f..fecf9aa 100644
3--- a/juju/checks/openstack.yaml
4+++ b/juju/checks/openstack.yaml
5@@ -72,12 +72,29 @@ checks:
6 ceph-radosgw:
7 charm: "ceph-radosgw"
8 assertions:
9+ ceph-osd-replication-count:
10+ allow_default:
11+ scope: config
12+ eq:
13+ scope: config
14+ source: local
15+ value: 3
16 cinder:
17 charm: "cinder"
18 assertions:
19 ha:
20 assert_ha:
21 scope: application
22+ cinder-ceph:
23+ charm: "cinder-ceph"
24+ assertions:
25+ ceph-osd-replication-count:
26+ allow_default:
27+ scope: config
28+ eq:
29+ scope: config
30+ source: local
31+ value: 3
32 designate:
33 charm: "designate"
34 assertions:
35@@ -90,6 +107,13 @@ checks:
36 ha:
37 assert_ha:
38 scope: application
39+ ceph-osd-replication-count:
40+ allow_default:
41+ scope: config
42+ eq:
43+ scope: config
44+ source: local
45+ value: 3
46 gnocchi:
47 charm: "gnocchi"
48 assertions:
49@@ -156,6 +180,13 @@ checks:
50 description: "ensure that nova instances path (if using bcache) is not backed by same physical disk as rootfs"
51 scope: config
52 source: bucketsconfig
53+ ceph-osd-replication-count:
54+ allow_default:
55+ scope: config
56+ eq:
57+ scope: config
58+ source: local
59+ value: 3
60 octavia:
61 charm: "octavia"
62 assertions:

Subscribers

People subscribed via source and target branches