Merge lp:~hopem/maas-deployer/lp1478015 into lp:~maas-deployers/maas-deployer/next

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 32
Proposed branch: lp:~hopem/maas-deployer/lp1478015
Merge into: lp:~maas-deployers/maas-deployer/next
Diff against target: 26 lines (+4/-1)
2 files modified
maas_deployer/vmaas/templates/cloud-init.cfg (+3/-1)
maas_deployer/vmaas/vm.py (+1/-0)
To merge this branch: bzr merge lp:~hopem/maas-deployer/lp1478015
Reviewer Review Type Date Requested Status
Billy Olsen Approve
Review via email: mp+270664@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

Changes look fine. We should also set the manage_etc_hosts: True in the cloud-init config so that the sudo doesn't always complain about not being able to resolve hostnames. I'll take care of that in the merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'maas_deployer/vmaas/templates/cloud-init.cfg'
2--- maas_deployer/vmaas/templates/cloud-init.cfg 2015-08-28 03:40:34 +0000
3+++ maas_deployer/vmaas/templates/cloud-init.cfg 2015-09-10 12:35:33 +0000
4@@ -9,7 +9,9 @@
5 - {{ ssh_key }}
6 {% endif %}
7
8-hostname: localhost
9+{% if hostname -%}
10+hostname: {{ hostname }}
11+{%- endif %}
12
13 {% if apt_http_proxy -%}
14 apt_proxy: {{ apt_http_proxy }}
15
16=== modified file 'maas_deployer/vmaas/vm.py'
17--- maas_deployer/vmaas/vm.py 2015-08-14 16:59:12 +0000
18+++ maas_deployer/vmaas/vm.py 2015-09-10 12:35:33 +0000
19@@ -426,6 +426,7 @@
20 """
21 base_file = os.path.join(working_dir, 'cloud-init.cfg')
22 parms = {
23+ 'hostname': self.name,
24 'user': self.user,
25 'password': self.password,
26 'ssh_key': self._get_ssh_key(),

Subscribers

People subscribed via source and target branches