Merge lp:~hopem/charms/trusty/cinder-ceph/lp1493931-stable into lp:~openstack-charmers-archive/charms/precise/cinder-ceph/trunk

Proposed by Edward Hope-Morley
Status: Merged
Merged at revision: 35
Proposed branch: lp:~hopem/charms/trusty/cinder-ceph/lp1493931-stable
Merge into: lp:~openstack-charmers-archive/charms/precise/cinder-ceph/trunk
Diff against target: 25 lines (+4/-2)
2 files modified
hooks/cinder_hooks.py (+2/-1)
unit_tests/test_cinder_hooks.py (+2/-1)
To merge this branch: bzr merge lp:~hopem/charms/trusty/cinder-ceph/lp1493931-stable
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
OpenStack Charmers Pending
Review via email: mp+271297@code.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #9344 cinder-ceph for hopem mp271297
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9344/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10186 cinder-ceph for hopem mp271297
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10186/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #6473 cinder-ceph for hopem mp271297
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/6473/

Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/cinder_hooks.py'
2--- hooks/cinder_hooks.py 2015-08-10 16:34:26 +0000
3+++ hooks/cinder_hooks.py 2015-09-16 13:00:05 +0000
4@@ -117,7 +117,8 @@
5 relation_set(
6 relation_id=rel_id,
7 backend_name=service_name(),
8- subordinate_configuration=json.dumps(CephSubordinateContext()())
9+ subordinate_configuration=json.dumps(CephSubordinateContext()()),
10+ stateless=True,
11 )
12
13
14
15=== modified file 'unit_tests/test_cinder_hooks.py'
16--- unit_tests/test_cinder_hooks.py 2015-08-10 16:34:26 +0000
17+++ unit_tests/test_cinder_hooks.py 2015-09-16 13:00:05 +0000
18@@ -136,5 +136,6 @@
19 self.relation_set.assert_called_with(
20 relation_id=None,
21 backend_name='test',
22- subordinate_configuration=json.dumps({'test': 1})
23+ subordinate_configuration=json.dumps({'test': 1}),
24+ stateless=True,
25 )

Subscribers

People subscribed via source and target branches