Merge lp:~hopem/charms/precise/ceph/lp1228316 into lp:~charmers/charms/precise/ceph/trunk
Proposed by
Edward Hope-Morley
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | James Page | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~hopem/charms/precise/ceph/lp1228316 | ||||
Merge into: | lp:~charmers/charms/precise/ceph/trunk | ||||
Diff against target: |
48 lines (+11/-3) 3 files modified
hooks/ceph.py (+5/-0) hooks/hooks.py (+5/-2) revision (+1/-1) |
||||
To merge this branch: | bzr merge lp:~hopem/charms/precise/ceph/lp1228316 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Adam Gandelman (community) | Needs Information | ||
Review via email:
|
To post a comment you must log in.
* The _default_caps are already essentially the default client caps. Is it really required to redefine them?
* Why are the caps now being set in the relation to the remote service?
This still doesn't address the issue of upgrading. Example: I have a cluster with a relation to one client (eg, glance). glance has the previous mon caps 'allow r' I upgrade my cluster to dumpling (which now requires 'allow rw' for clients wishing to mk a pool) and the charm. I add a relation to cinder. cinder gets 'mon rw'. If for some reason things got crazy, and I had to recreate the pools (manual or otherwise), cinder would be able to and glance wouldn't and I would be scratching my head trying to find out why. I'd expect the permissions to be consistent across all relations after the upgrade.
I'd love to see an upgrade-charm hook that iterates through the current ceph relation, check the permissions of each client and add the 'w' bit if required.