Merge lp:~hopem/charm-helpers/lp1525845 into lp:charm-helpers
Proposed by
Edward Hope-Morley
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~hopem/charm-helpers/lp1525845 | ||||
Merge into: | lp:charm-helpers | ||||
Diff against target: |
87 lines (+32/-19) 2 files modified
charmhelpers/contrib/network/ip.py (+21/-19) tests/contrib/network/test_ip.py (+11/-0) |
||||
To merge this branch: | bzr merge lp:~hopem/charm-helpers/lp1525845 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Needs Fixing | ||
Review via email: mp+280432@code.launchpad.net |
This proposal has been superseded by a proposal from 2015-12-14.
To post a comment you must log in.
Some units tests would be nice :-)