Merge ~hook25/ppa-dev-tools:support_env_credentials into ppa-dev-tools:main
Proposed by
Massimiliano Girardi
Status: | Merged |
---|---|
Merge reported by: | Bryce Harrington |
Merged at revision: | fcde0dbd81222edc71971caefa268e54ed7a5d60 |
Proposed branch: | ~hook25/ppa-dev-tools:support_env_credentials |
Merge into: | ppa-dev-tools:main |
Diff against target: |
117 lines (+65/-5) 2 files modified
ppa/lp.py (+37/-4) tests/test_lp.py (+28/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bryce Harrington | Approve | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+443897@code.launchpad.net |
This proposal supersedes a proposal from 2023-05-29.
Commit message
Add LP_CREDENTIALS login and documentation
Description of the change
This adds the possibility of running ppa-dev-tools automatically by making it retrieve the credentials for Launchpad from the LP_CREDENTIALS environment variable and documents another way to do so via the LP_CREDENTIALS_FILE environment variable
To post a comment you must log in.
Good addition, a few nitpicks below but otherwise LGTM.
Other than a couple minor flake8 issues, `make check` passes.
Would you be willing to write a test case to go along with this? We have test_new_ connection( ) that verifies that the login_with() call gets invoked, what we'd need is something analogous to that but that sets the environment variable and verifies that Credentials. from_string( ) gets invoked instead, and login_with() does NOT get invoked.