Merge lp:~hloeung/ubuntu/trusty/pollen/depend-on-ent into lp:ubuntu/trusty/pollen

Proposed by Haw Loeung
Status: Rejected
Rejected by: Jamie Strandboge
Proposed branch: lp:~hloeung/ubuntu/trusty/pollen/depend-on-ent
Merge into: lp:ubuntu/trusty/pollen
Diff against target: 14 lines (+2/-2)
1 file modified
debian/control (+2/-2)
To merge this branch: bzr merge lp:~hloeung/ubuntu/trusty/pollen/depend-on-ent
Reviewer Review Type Date Requested Status
Jamie Strandboge Disapprove
Review via email: mp+198192@code.launchpad.net

Description of the change

check_pollen nagios plugin uses ent so make it a dependency.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Thanks for the patch!

I would agree that this should be moved to Depends if the nagios plugin was in its own package. However, it is not and the rest of the package will function correctly if it is not installed. The Recommends will pull ent in on installs though. From Ubuntu Policy:
"Recommends

    This declares a strong, but not absolute, dependency.

    The Recommends field should list packages that would be found together with this one in all but unusual installations.
"

This seems to be the case here.

review: Disapprove

Unmerged revisions

8. By Haw Loeung

[hloeung] Depend on ent as required by check_pollen nagios plugin.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-09-04 14:25:51 +0000
3+++ debian/control 2013-12-09 02:27:52 +0000
4@@ -11,8 +11,8 @@
5
6 Package: pollen
7 Architecture: amd64 armel armhf i386 x32
8-Depends: ${misc:Depends}, ${shlibs:Depends}, golang-go
9-Recommends: haveged, pollinate, ent
10+Depends: ${misc:Depends}, ${shlibs:Depends}, golang-go, ent
11+Recommends: haveged, pollinate
12 Provides: anerd-server
13 Replaces: anerd-server (<< 3.0)
14 Breaks: anerd-server (<< 3.0)

Subscribers

People subscribed via source and target branches

to all changes: