Merge lp:~hloeung/ubuntu-repository-cache/suppress-output-reduce-cron-spam into lp:ubuntu-repository-cache

Proposed by Haw Loeung
Status: Merged
Approved by: Haw Loeung
Approved revision: 334
Merged at revision: 334
Proposed branch: lp:~hloeung/ubuntu-repository-cache/suppress-output-reduce-cron-spam
Merge into: lp:ubuntu-repository-cache
Diff against target: 20 lines (+2/-2)
1 file modified
lib/ubuntu_repository_cache/metadata_sync.py (+2/-2)
To merge this branch: bzr merge lp:~hloeung/ubuntu-repository-cache/suppress-output-reduce-cron-spam
Reviewer Review Type Date Requested Status
Paul Collins Approve
Canonical IS Reviewers Pending
Review via email: mp+402542@code.launchpad.net

Commit message

Suppress output reducing cron mail spam

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Paul Collins (pjdc) wrote :

Might want to consider whether we still want mail if there's stderr.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 334

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/ubuntu_repository_cache/metadata_sync.py'
2--- lib/ubuntu_repository_cache/metadata_sync.py 2021-03-02 02:40:04 +0000
3+++ lib/ubuntu_repository_cache/metadata_sync.py 2021-05-11 02:34:07 +0000
4@@ -14,7 +14,7 @@
5 from datetime import datetime
6 from itertools import cycle
7
8-from subprocess import CalledProcessError, check_call, check_output, STDOUT
9+from subprocess import CalledProcessError, check_call, check_output, DEVNULL, STDOUT
10
11 from .util import (
12 FileSemaphore,
13@@ -281,7 +281,7 @@
14
15 log("Executing hook: {}".format(cmd))
16
17- check_call(cmd)
18+ check_call(cmd, stdout=DEVNULL)
19
20 return meta_ver
21

Subscribers

People subscribed via source and target branches