Ubuntu Repository Cache Charm

Merge lp:~hloeung/ubuntu-repository-cache/only-reload-apache2-when-needed-4 into lp:ubuntu-repository-cache

  1. only-reload-apache2-when-needed-4
  2. Merge into layer-ubuntu-repository-cache
Proposed by Haw Loeung
Status: Merged
Approved by: Paul Collins
Approved revision: 312
Merged at revision: 312
Proposed branch: lp:~hloeung/ubuntu-repository-cache/only-reload-apache2-when-needed-4
Merge into: lp:ubuntu-repository-cache
Diff against target: 10 lines (+0/-1)
1 file modified
lib/ubuntu_repository_cache/service.py (+0/-1)
To merge this branch: bzr merge lp:~hloeung/ubuntu-repository-cache/only-reload-apache2-when-needed-4
Reviewer Review Type Date Requested Status
Paul Collins lgtm Approve
Canonical IS Reviewers Pending
Review via email: mp+398419@code.launchpad.net

Commit message

Don't call apache.start() in service.unpause()

service.unpause() calls render_configs() which calls apache.render_configs(). Within that, it will call apache.start() so it is not needed here. It also handles config changes requiring graceful reload better.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Paul Collins (pjdc) :
review: Approve (lgtm)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 312

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/ubuntu_repository_cache/service.py'
2--- lib/ubuntu_repository_cache/service.py 2021-02-19 03:36:02 +0000
3+++ lib/ubuntu_repository_cache/service.py 2021-02-22 00:51:25 +0000
4@@ -148,7 +148,6 @@
5 # Change servicing of metadata to use local metadata
6 util.unset_failover()
7 render_configs()
8- apache.start()
9 open_ports()
10 write_status('running')
11

Subscribers

People subscribed via source and target branches