Merge lp:~hloeung/ubuntu-repository-cache/fix-nrpe-checks into lp:ubuntu-repository-cache

Proposed by Haw Loeung
Status: Merged
Approved by: Thomas Cuthbert
Approved revision: 347
Merged at revision: 347
Proposed branch: lp:~hloeung/ubuntu-repository-cache/fix-nrpe-checks
Merge into: lp:ubuntu-repository-cache
Diff against target: 71 lines (+9/-8)
4 files modified
lib/ubuntu_repository_cache/apache.py (+4/-4)
lib/ubuntu_repository_cache/mirror.py (+1/-1)
lib/ubuntu_repository_cache/squid.py (+3/-3)
tox.ini (+1/-0)
To merge this branch: bzr merge lp:~hloeung/ubuntu-repository-cache/fix-nrpe-checks
Reviewer Review Type Date Requested Status
Thomas Cuthbert (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+423581@code.launchpad.net

Commit message

Fixed nrpe checks, escaping spaces

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Thomas Cuthbert (tcuthbert) wrote :

LGTM+1

review: Approve
348. By Haw Loeung

Minor fix

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 347

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/ubuntu_repository_cache/apache.py'
2--- lib/ubuntu_repository_cache/apache.py 2022-05-30 01:55:13 +0000
3+++ lib/ubuntu_repository_cache/apache.py 2022-05-30 03:41:43 +0000
4@@ -359,8 +359,8 @@
5 '--hostname ubuntu-archive-asm.trafficmanager.net '
6 '--url "/{}/" '
7 '--string "dists/" '
8- '--expect 200\\\ OK '
9- '--header Accept-Encoding:\\\ \\\*'
10+ '--expect 200\\ OK '
11+ '--header Accept-Encoding:\\ \\*'
12 ).format(path_base),
13 )
14
15@@ -372,7 +372,7 @@
16 '--hostname localhost '
17 '--url "/{}/" '
18 '--string "dists/" '
19- '--expect 200\\\ OK '
20- '--header Accept-Encoding:\\\ \\\*'
21+ '--expect 200\\ OK '
22+ '--header Accept-Encoding:\\ \\*'
23 ).format(path_base),
24 )
25
26=== modified file 'lib/ubuntu_repository_cache/mirror.py'
27--- lib/ubuntu_repository_cache/mirror.py 2021-03-01 04:50:56 +0000
28+++ lib/ubuntu_repository_cache/mirror.py 2022-05-30 03:41:43 +0000
29@@ -102,7 +102,7 @@
30
31 @util.run_as_user('www-sync')
32 def rsync_from_peer(source_dir, dest_dir, peer_ip, link_dir=None, user='www-sync'):
33- '''Use rsync to pull a directory from a configured peer. '''
34+ '''Use rsync to pull a directory from a configured peer.'''
35
36 rsync_source = '{}@{}:{}'.format(user, peer_ip, source_dir)
37 LOG('Syncing {} to {}.'.format(rsync_source, dest_dir))
38
39=== modified file 'lib/ubuntu_repository_cache/squid.py'
40--- lib/ubuntu_repository_cache/squid.py 2022-05-30 01:55:13 +0000
41+++ lib/ubuntu_repository_cache/squid.py 2022-05-30 03:41:43 +0000
42@@ -248,7 +248,7 @@
43
44
45 def update_checks(nrpe_config):
46- ''''Update Nagios checks for squid serving archive pool content'''
47+ '''Update Nagios checks for squid serving archive pool content'''
48
49 path_base = hookenv.config()['path-base']
50 nrpe_config.add_check(
51@@ -259,7 +259,7 @@
52 '--hostname localhost '
53 '--url "/{}/pool/" '
54 '--string "main/" '
55- '--expect 200\\\ OK '
56- '--header Accept-Encoding:\\\ \\\*'
57+ '--expect 200\\ OK '
58+ '--header Accept-Encoding:\\ \\*'
59 ).format(path_base),
60 )
61
62=== modified file 'tox.ini'
63--- tox.ini 2021-02-16 23:48:45 +0000
64+++ tox.ini 2022-05-30 03:41:43 +0000
65@@ -32,5 +32,6 @@
66 .bzr,
67 __pycache__,
68 .tox,
69+ build,
70 max-line-length = 120
71 max-complexity = 14

Subscribers

People subscribed via source and target branches