Ubuntu Repository Cache Charm

Merge lp:~hloeung/ubuntu-repository-cache/cleanup-for-charm-build into lp:ubuntu-repository-cache

  1. cleanup-for-charm-build
  2. Merge into layer-ubuntu-repository-cache
Proposed by Haw Loeung
Status: Merged
Approved by: Haw Loeung
Approved revision: 317
Merged at revision: 315
Proposed branch: lp:~hloeung/ubuntu-repository-cache/cleanup-for-charm-build
Merge into: lp:ubuntu-repository-cache
Diff against target: 16 lines (+5/-2)
1 file modified
Makefile (+5/-2)
To merge this branch: bzr merge lp:~hloeung/ubuntu-repository-cache/cleanup-for-charm-build
Reviewer Review Type Date Requested Status
Colin Misare Approve
Canonical IS Reviewers Pending
Review via email: mp+398499@code.launchpad.net

Commit message

unittests now uses hookenv.Config() so ensure .juju-persistent-config isn't included or is properly cleaned

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Colin Misare (cmisare) wrote :

LGTM

review: Approve
lp:~hloeung/ubuntu-repository-cache/cleanup-for-charm-build updated
317. By Haw Loeung

Also clean up pycache cruft

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 315

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2020-08-11 04:12:28 +0000
3+++ Makefile 2021-02-23 00:08:23 +0000
4@@ -45,7 +45,10 @@
5 .venv/bin/pip install flake8 nose mock ipdb coverage backoff==1.4.0
6
7 clean:
8- rm -rf .venv
9- rm -rf .tox
10+ @echo "Cleaning files"
11+ @rm -rf .venv
12+ @rm -rf .tox
13+ @rm -rf ./tests/unit/__pycache__ ./reactive/__pycache__ ./lib/ubuntu_repository_cache/__pycache__ ./lib/ubuntu_repository_cache/tests/__pycache__ ./files/__pycache__
14+ @rm -rf ./.coverage ./.juju-persistent-config ./.unit-state.db
15
16 .PHONY: proof test lint

Subscribers

People subscribed via source and target branches