Merge ~hloeung/ubuntu-repository-cache:fixes into ubuntu-repository-cache:master

Proposed by Haw Loeung
Status: Merged
Approved by: Loïc Gomez
Approved revision: 543e6ab8a3a44124db10061acb639892293888fa
Merged at revision: 3bd749b65f9657e00a8ae090a575c6dc74030994
Proposed branch: ~hloeung/ubuntu-repository-cache:fixes
Merge into: ubuntu-repository-cache:master
Diff against target: 80 lines (+2/-5)
6 files modified
lib/ubuntu_repository_cache/metadata_cleanup.py (+0/-1)
lib/ubuntu_repository_cache/metadata_peers_sync.py (+0/-1)
lib/ubuntu_repository_cache/metadata_sync.py (+0/-1)
lib/ubuntu_repository_cache/tests/test_apache.py (+0/-1)
reactive/ubuntu_repository_cache.py (+1/-1)
tests/unit/test_ubuntu_repository_cache.py (+1/-0)
Reviewer Review Type Date Requested Status
Canonical IS Reviewers Pending
Ubuntu Repository Cache Charmers, Canonical Pending
Review via email: mp+436813@code.launchpad.net

Commit message

Ignore systemd/system/snapd.mounts.target.wants/snap-* in bzrignore to reduce cron spam

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 3bd749b65f9657e00a8ae090a575c6dc74030994

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/ubuntu_repository_cache/metadata_cleanup.py b/lib/ubuntu_repository_cache/metadata_cleanup.py
2index 6d74cf5..2e2d350 100644
3--- a/lib/ubuntu_repository_cache/metadata_cleanup.py
4+++ b/lib/ubuntu_repository_cache/metadata_cleanup.py
5@@ -20,7 +20,6 @@ def main(environment, log):
6
7
8 if __name__ == "__main__":
9-
10 # Use the logging infrastructure to print messages with timestamps to
11 # stdout. This is a cheap way to get good timestamps. Ideally we should
12 # move to leverage the logging infrastructure better. ~tribaal
13diff --git a/lib/ubuntu_repository_cache/metadata_peers_sync.py b/lib/ubuntu_repository_cache/metadata_peers_sync.py
14index 7ab5bd1..e129bfc 100644
15--- a/lib/ubuntu_repository_cache/metadata_peers_sync.py
16+++ b/lib/ubuntu_repository_cache/metadata_peers_sync.py
17@@ -82,7 +82,6 @@ def ubuntu_repository_cache_sync(environment, log):
18
19
20 if __name__ == "__main__":
21-
22 # Use the logging infrastructure to print messages with timestamps to
23 # stdout. This is a cheap way to get good timestamps. Ideally we should
24 # move to leverage the logging infrastructure better. ~tribaal
25diff --git a/lib/ubuntu_repository_cache/metadata_sync.py b/lib/ubuntu_repository_cache/metadata_sync.py
26index cbc01b3..d428f3d 100644
27--- a/lib/ubuntu_repository_cache/metadata_sync.py
28+++ b/lib/ubuntu_repository_cache/metadata_sync.py
29@@ -621,7 +621,6 @@ def _verify_distribution(path, release):
30
31
32 if __name__ == "__main__":
33-
34 # Use the logging infrastructure to print messages with timestamps to
35 # stdout. This is a cheap way to get good timestamps. Ideally we should
36 # move to leverage the logging infrastructure better. ~tribaal
37diff --git a/lib/ubuntu_repository_cache/tests/test_apache.py b/lib/ubuntu_repository_cache/tests/test_apache.py
38index aef2b7a..8de4501 100644
39--- a/lib/ubuntu_repository_cache/tests/test_apache.py
40+++ b/lib/ubuntu_repository_cache/tests/test_apache.py
41@@ -24,7 +24,6 @@ class ApacheTestCase(unittest.TestCase):
42
43 @mock.patch('multiprocessing.cpu_count')
44 def test_tune_mpm_configs(self, cpu_count):
45-
46 cpu_count.return_value = 4
47 config = {
48 'startservers': 0,
49diff --git a/reactive/ubuntu_repository_cache.py b/reactive/ubuntu_repository_cache.py
50index c6f7246..101c686 100755
51--- a/reactive/ubuntu_repository_cache.py
52+++ b/reactive/ubuntu_repository_cache.py
53@@ -421,6 +421,7 @@ systemd/system/default.target.wants/snap-*.mount
54 systemd/system/default.target.wants/snap-*.service
55 systemd/system/snap-*.mount
56 systemd/system/snap.*.service
57+systemd/system/snapd.mounts.target.wants/snap-*.mount
58 # end section ignore due to LP#1598304
59 '''
60 _write_file('\n'.join(new) + ignore_snaps, bzrignore_path, perms=0o600)
61@@ -483,7 +484,6 @@ def _write_file(source, dest_path, perms=0o644, owner=None, group=None):
62
63
64 def _update_aliases(admin_email='', aliases_path='/etc/aliases'):
65-
66 aliases = []
67 try:
68 with open(aliases_path, 'r') as f:
69diff --git a/tests/unit/test_ubuntu_repository_cache.py b/tests/unit/test_ubuntu_repository_cache.py
70index e73e27c..1dd66fb 100644
71--- a/tests/unit/test_ubuntu_repository_cache.py
72+++ b/tests/unit/test_ubuntu_repository_cache.py
73@@ -133,6 +133,7 @@ systemd/system/default.target.wants/snap-*.mount
74 systemd/system/default.target.wants/snap-*.service
75 systemd/system/snap-*.mount
76 systemd/system/snap.*.service
77+systemd/system/snapd.mounts.target.wants/snap-*.mount
78 # end section ignore due to LP#1598304
79 '''
80 with open(bzrignore_path, 'r', encoding='utf-8') as f:

Subscribers

People subscribed via source and target branches