Ubuntu Repository Cache Charm

Merge ~hloeung/ubuntu-repository-cache:fixes into ubuntu-repository-cache:master

  1. Git
  2. lp:~hloeung/ubuntu-repository-cache
  3. fixes
  4. Merge into master
Proposed by Haw Loeung
Status: Merged
Approved by: Thomas Cuthbert
Approved revision: 5abde4bbe15e97aae9138a1bb871435d0dd1c236
Merged at revision: 5f642002ba5174fb1a5eace22e6dd04d5b56407a
Proposed branch: ~hloeung/ubuntu-repository-cache:fixes
Merge into: ubuntu-repository-cache:master
Diff against target: 40 lines (+4/-4)
1 file modified
reactive/ubuntu_repository_cache.py (+4/-4)
Reviewer Review Type Date Requested Status
Thomas Cuthbert (community) Approve
Canonical IS Reviewers Pending
Review via email: mp+430591@code.launchpad.net

Commit message

Fix 'cluster_relation_*() takes 0 positional arguments but 1 was given'

To post a comment you must log in.
Revision history for this message
Thomas Cuthbert (tcuthbert) wrote :

LGTM +1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 5f642002ba5174fb1a5eace22e6dd04d5b56407a

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/ubuntu_repository_cache.py b/reactive/ubuntu_repository_cache.py
2index c04fca9..12ff100 100755
3--- a/reactive/ubuntu_repository_cache.py
4+++ b/reactive/ubuntu_repository_cache.py
5@@ -207,7 +207,7 @@ def website_relation_joined():
6
7
8 @reactive.hook('cluster-relation-joined')
9-def cluster_relation_joined():
10+def cluster_relation_joined(context=None):
11 '''Join a peer cluster relationship'''
12
13 LOG('Cluster relation joined for %s' % SERVICE)
14@@ -226,7 +226,7 @@ def cluster_relation_joined():
15
16
17 @reactive.hook('cluster-relation-changed')
18-def cluster_relation_changed():
19+def cluster_relation_changed(context=None):
20 '''Handle peer cluster relationship changes'''
21
22 LOG('Cluster relation changed for %s' % SERVICE)
23@@ -240,7 +240,7 @@ def cluster_relation_changed():
24
25
26 @reactive.hook('cluster-relation-departed')
27-def cluster_relation_departed():
28+def cluster_relation_departed(context=None):
29 '''Handle peer cluster relationship departures'''
30
31 LOG('Cluster relation departed for %s' % SERVICE)
32@@ -253,7 +253,7 @@ def cluster_relation_departed():
33
34
35 @reactive.hook('cluster-relation-broken')
36-def cluster_relation_broken():
37+def cluster_relation_broken(context=None):
38 '''Leave a peer cluster relationship'''
39
40 LOG('Cluster relation broken for %s' % SERVICE)

Subscribers

People subscribed via source and target branches