Merge ~hloeung/ubuntu-mirror-charm:master into ubuntu-mirror-charm:master

Proposed by Haw Loeung
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: ~hloeung/ubuntu-mirror-charm:master
Merge into: ubuntu-mirror-charm:master
Diff against target: 25 lines (+7/-0)
2 files modified
hooks/hooks.py (+6/-0)
hooks/update-status (+1/-0)
Reviewer Review Type Date Requested Status
Alexandre Gomes Approve
Canonical IS Reviewers Pending
Review via email: mp+389761@code.launchpad.net

Commit message

Reduce noise about missing update-status hook

To post a comment you must log in.
Revision history for this message
Alexandre Gomes (alejdg) wrote :

+1

review: Approve
Revision history for this message
Canonical IS Mergebot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Unmerged commits

4ad76e4... by Haw Loeung on 2020-08-24

Reduce noise about missing update-status hook

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/hooks/hooks.py b/hooks/hooks.py
2index 0b80434..0f6ce2b 100755
3--- a/hooks/hooks.py
4+++ b/hooks/hooks.py
5@@ -992,6 +992,12 @@ def upgrade_charm():
6 install()
7
8
9+@hooks.hook("update-status")
10+def update_status():
11+ # Do nothing to reduce noise about missing hook.
12+ return
13+
14+
15 @hooks.hook("nrpe-external-master-relation-changed")
16 def nrpe_external_master_relation_changed():
17 conf = Config()
18diff --git a/hooks/update-status b/hooks/update-status
19new file mode 120000
20index 0000000..9416ca6
21--- /dev/null
22+++ b/hooks/update-status
23@@ -0,0 +1 @@
24+hooks.py
25\ No newline at end of file

Subscribers

People subscribed via source and target branches