prometheus-snap

Merge ~hloeung/prometheus-snap:prometheus2 into ~canonical-is-sa/prometheus-snap:prometheus2

  1. Git
  2. lp:~hloeung/prometheus-snap
  3. prometheus2
  4. Merge into prometheus2
Proposed by Haw Loeung
Status: Merged
Approved by: Benjamin Allot
Approved revision: 27649ccd8355bb0e98a1dcd1a756428d103d375b
Merged at revision: 8595033a8d3980a4ae573dbd2c79d16c9e422894
Proposed branch: ~hloeung/prometheus-snap:prometheus2
Merge into: ~canonical-is-sa/prometheus-snap:prometheus2
Diff against target: 12 lines (+1/-1)
1 file modified
snap_config_wrapper (+1/-1)
Reviewer Review Type Date Requested Status
Benjamin Allot Approve
Canonical IS Reviewers Pending
Review via email: mp+396456@code.launchpad.net

Commit message

4k max. open files is not enough

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Benjamin Allot (ballot) wrote :

LGTM for now.

Long term would be to use have a sane default but allow a customization if needed.

review: Approve
Revision history for this message
Benjamin Allot (ballot) wrote :

LGTM for now.

Long term would be to use have a sane default but allow a customization if needed. (same comment as https://code.launchpad.net/~hloeung/prometheus-snap/+git/prometheus-snap/+merge/396456)

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 8595033a8d3980a4ae573dbd2c79d16c9e422894

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snap_config_wrapper b/snap_config_wrapper
2index bf7dfac..ae4d288 100755
3--- a/snap_config_wrapper
4+++ b/snap_config_wrapper
5@@ -4,6 +4,6 @@ test -e $SNAP_DATA/prometheus.yml || cp $SNAP/etc/prometheus/prometheus.yml.exam
6 test -e $SNAP_DATA/daemon_arguments || cp $SNAP/etc/prometheus/daemon_arguments.example $SNAP_DATA/daemon_arguments
7 test -d $SNAP_DATA/promreg || mkdir $SNAP_DATA/promreg
8
9-ulimit -n 4096
10+ulimit -n 65536
11 . $SNAP_DATA/daemon_arguments
12 $SNAP/bin/prometheus $ARGS --config.file=$SNAP_DATA/prometheus.yml --storage.tsdb.path=$SNAP_COMMON

Subscribers

People subscribed via source and target branches

to all changes: