Merge ~hloeung/charm-nrpe:master into ~nrpe-charmers/charm-nrpe:master

Proposed by Haw Loeung
Status: Merged
Approved by: Paul Collins
Approved revision: 10a673a31b75fd7afd3b8e314884c84832885a31
Merged at revision: 8cecde43d69d86ed6399737ad608e9bad79305b1
Proposed branch: ~hloeung/charm-nrpe:master
Merge into: ~nrpe-charmers/charm-nrpe:master
Diff against target: 44 lines (+6/-1)
3 files modified
.gitignore (+1/-0)
hooks/nrpe_helpers.py (+2/-0)
hooks/nrpe_utils.py (+3/-1)
Reviewer Review Type Date Requested Status
Paul Collins lgtm Approve
Canonical IS Reviewers Pending
Review via email: mp+374494@code.launchpad.net

Commit message

Export nagios definitions if nagios_master set - LP#1830159

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Paul Collins (pjdc) :
review: Approve (lgtm)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 8cecde43d69d86ed6399737ad608e9bad79305b1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.gitignore b/.gitignore
2index 4dcb392..0dce009 100644
3--- a/.gitignore
4+++ b/.gitignore
5@@ -3,3 +3,4 @@
6 *.pyc
7 __pycache__/
8 .venv/
9+builds/
10diff --git a/hooks/nrpe_helpers.py b/hooks/nrpe_helpers.py
11index c3adc6e..abd6398 100644
12--- a/hooks/nrpe_helpers.py
13+++ b/hooks/nrpe_helpers.py
14@@ -273,6 +273,8 @@ class RsyncEnabled(helpers.RelationContext):
15 def __init__(self):
16 self['export_nagios_definitions'] = \
17 hookenv.config('export_nagios_definitions')
18+ if hookenv.config('nagios_master') and hookenv.config('nagios_master') != 'None':
19+ self['export_nagios_definitions'] = True
20
21 def is_ready(self):
22 return self['export_nagios_definitions']
23diff --git a/hooks/nrpe_utils.py b/hooks/nrpe_utils.py
24index c6342d1..6e2e9ab 100644
25--- a/hooks/nrpe_utils.py
26+++ b/hooks/nrpe_utils.py
27@@ -35,6 +35,8 @@ def determine_packages():
28 ]
29 if hookenv.config('export_nagios_definitions'):
30 pkgs.append('rsync')
31+ if hookenv.config('nagios_master') and hookenv.config('nagios_master') != 'None':
32+ pkgs.append('rsync')
33 return pkgs
34
35
36@@ -163,7 +165,7 @@ class TolerantPortManagerCallback(PortManagerCallback):
37 for opening ports
38
39 For context, see:
40- https://bugs.launchpad.net/juju/+bug/1750079 and
41+ https://bugs.launchpad.net/juju/+bug/1750079 and
42 https://github.com/juju/charm-helpers/pull/152
43 """
44 def __call__(self, manager, service_name, event_name):

Subscribers

People subscribed via source and target branches